wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-28 01:10:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resize popup to 403px

Browse source 
Restores the max-size introduced in I6036968a2, after conflicting
changes to the popup layout.

Bug: T246029
Change-Id: I82ea48929b44d97d78112bd96ad75724ae6f46af
This commit is contained in:
Adam Wight 2020-10-30 14:00:36 +01:00 committed by Thiemo Kreuz
parent 789cedc168
commit 50c0e46b0a
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -67,7 +67,7 @@
"bundlesize": [ "bundlesize": [
{ {
"path": "resources/dist/index.js", "path": "resources/dist/index.js",
"maxSize": "13.82kB" "maxSize": "13.6kB"
} }
] ]
} }

5
src/ui/templates/referencePreview/referencePreview.less
View file

@ -28,12 +28,11 @@
.mwe-popups-extract { .mwe-popups-extract {
margin-right: 0; margin-right: 0;
margin-bottom: @lineHeight; margin-bottom: @popupPadding;
max-height: inherit; max-height: inherit;
.mwe-popups-scroll { .mwe-popups-scroll {
// 8px caused by different margin-bottom, 55px here vs. 47px upstream max-height: 403px - 2 * @popupPadding;
max-height: 200px - 8px + 7 * @lineHeight;
overflow: auto; overflow: auto;
padding-right: @popupPadding; padding-right: @popupPadding;
} }

4
webpack.config.js
View file

@ -112,8 +112,8 @@ module.exports = ( env, argv ) => ( {
// Minified uncompressed size limits for chunks / assets and entrypoints. Keep these numbers // Minified uncompressed size limits for chunks / assets and entrypoints. Keep these numbers
// up-to-date and rounded to the nearest 10th of a kibibyte so that code sizing costs are // up-to-date and rounded to the nearest 10th of a kibibyte so that code sizing costs are
// well understood. Related to bundlesize minified, gzipped compressed file size tests. // well understood. Related to bundlesize minified, gzipped compressed file size tests.
maxAssetSize: 42.6 * 1024, maxAssetSize: 41.4 * 1024,
maxEntrypointSize: 42.6 * 1024, maxEntrypointSize: 41.4 * 1024,
// The default filter excludes map files but we rename ours. // The default filter excludes map files but we rename ours.
assetFilter: ( filename ) => !filename.endsWith( srcMapExt ) assetFilter: ( filename ) => !filename.endsWith( srcMapExt )