wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-23 23:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use double dash in refrence preview tests

Browse source 
The default way to build these ids is without a double dash afaik.

Change-Id: I068d97de517f9da09c203d543cf6eb51cf306465
This commit is contained in:
WMDE-Fisch 2020-01-23 18:41:50 +01:00
parent 06b19134c3
commit 4f263bebfc
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
tests/node-qunit/gateway/reference.test.js
View file

@ -10,22 +10,22 @@ QUnit.module( 'ext.popups/gateway/reference', {
); );
this.$references = $( '<ul>' ).append( this.$references = $( '<ul>' ).append(
$( '<li>' ).attr( 'id', 'cite_note--1' ).append( $( '<li>' ).attr( 'id', 'cite_note-1' ).append(
$( '<span>' ).addClass( 'mw-reference-text' ).text( 'Footnote 1' ) $( '<span>' ).addClass( 'mw-reference-text' ).text( 'Footnote 1' )
), ),
$( '<li>' ).attr( 'id', 'cite_note--2' ).append( $( '<li>' ).attr( 'id', 'cite_note-2' ).append(
$( '<span>' ).addClass( 'reference-text' ).append( $( '<span>' ).addClass( 'reference-text' ).append(
$( '<cite>' ).addClass( 'citation web unknown' ).text( 'Footnote 2' ) $( '<cite>' ).addClass( 'citation web unknown' ).text( 'Footnote 2' )
) )
), ),
$( '<li>' ).attr( 'id', 'cite_note--3' ).append( $( '<li>' ).attr( 'id', 'cite_note-3' ).append(
$( '<span>' ).addClass( 'reference-text' ).append( $( '<span>' ).addClass( 'reference-text' ).append(
$( '<cite>' ).addClass( 'news' ).text( 'Footnote 3' ), $( '<cite>' ).addClass( 'news' ).text( 'Footnote 3' ),
$( '<cite>' ).addClass( 'news citation' ), $( '<cite>' ).addClass( 'news citation' ),
$( '<cite>' ).addClass( 'citation' ) $( '<cite>' ).addClass( 'citation' )
) )
), ),
$( '<li>' ).attr( 'id', 'cite_note--4' ).append( $( '<li>' ).attr( 'id', 'cite_note-4' ).append(
$( '<span>' ).addClass( 'reference-text' ).append( $( '<span>' ).addClass( 'reference-text' ).append(
$( '<cite>' ).addClass( 'news' ).text( 'Footnote 4' ), $( '<cite>' ).addClass( 'news' ).text( 'Footnote 4' ),
$( '<cite>' ).addClass( 'web' ) $( '<cite>' ).addClass( 'web' )
@ -42,13 +42,13 @@ QUnit.module( 'ext.popups/gateway/reference', {
QUnit.test( 'Reference preview gateway returns the correct data', function ( assert ) { QUnit.test( 'Reference preview gateway returns the correct data', function ( assert ) {
const gateway = createReferenceGateway(), const gateway = createReferenceGateway(),
title = createStubTitle( 1, 'Foo', 'cite note--1' ); title = createStubTitle( 1, 'Foo', 'cite note-1' );
return gateway.fetchPreviewForTitle( title ).then( ( result ) => { return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
assert.propEqual( assert.propEqual(
result, result,
{ {
url: '#cite_note--1', url: '#cite_note-1',
extract: 'Footnote 1', extract: 'Footnote 1',
type: 'reference', type: 'reference',
referenceType: null, referenceType: null,
@ -60,13 +60,13 @@ QUnit.test( 'Reference preview gateway returns the correct data', function ( ass
QUnit.test( 'Reference preview gateway accepts alternative text node class name', function ( assert ) { QUnit.test( 'Reference preview gateway accepts alternative text node class name', function ( assert ) {
const gateway = createReferenceGateway(), const gateway = createReferenceGateway(),
title = createStubTitle( 1, 'Foo', 'cite note--2' ); title = createStubTitle( 1, 'Foo', 'cite note-2' );
return gateway.fetchPreviewForTitle( title ).then( ( result ) => { return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
assert.propEqual( assert.propEqual(
result, result,
{ {
url: '#cite_note--2', url: '#cite_note-2',
extract: '<cite class="citation web unknown">Footnote 2</cite>', extract: '<cite class="citation web unknown">Footnote 2</cite>',
type: 'reference', type: 'reference',
referenceType: 'web unknown', referenceType: 'web unknown',
@ -78,13 +78,13 @@ QUnit.test( 'Reference preview gateway accepts alternative text node class name'
QUnit.test( 'Reference preview gateway accepts duplicated types', function ( assert ) { QUnit.test( 'Reference preview gateway accepts duplicated types', function ( assert ) {
const gateway = createReferenceGateway(), const gateway = createReferenceGateway(),
title = createStubTitle( 1, 'Foo', 'cite note--3' ); title = createStubTitle( 1, 'Foo', 'cite note-3' );
return gateway.fetchPreviewForTitle( title ).then( ( result ) => { return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
assert.propEqual( assert.propEqual(
result, result,
{ {
url: '#cite_note--3', url: '#cite_note-3',
extract: '<cite class="news">Footnote 3</cite><cite class="news citation"></cite><cite class="citation"></cite>', extract: '<cite class="news">Footnote 3</cite><cite class="news citation"></cite><cite class="citation"></cite>',
type: 'reference', type: 'reference',
referenceType: 'news', referenceType: 'news',
@ -96,13 +96,13 @@ QUnit.test( 'Reference preview gateway accepts duplicated types', function ( ass
QUnit.test( 'Reference preview gateway rejects conflicting types', function ( assert ) { QUnit.test( 'Reference preview gateway rejects conflicting types', function ( assert ) {
const gateway = createReferenceGateway(), const gateway = createReferenceGateway(),
title = createStubTitle( 1, 'Foo', 'cite note--4' ); title = createStubTitle( 1, 'Foo', 'cite note-4' );
return gateway.fetchPreviewForTitle( title ).then( ( result ) => { return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
assert.propEqual( assert.propEqual(
result, result,
{ {
url: '#cite_note--4', url: '#cite_note-4',
extract: '<cite class="news">Footnote 4</cite><cite class="web"></cite>', extract: '<cite class="news">Footnote 4</cite><cite class="web"></cite>',
type: 'reference', type: 'reference',
referenceType: null, referenceType: null,
@ -114,13 +114,13 @@ QUnit.test( 'Reference preview gateway rejects conflicting types', function ( as
QUnit.test( 'Reference preview gateway returns source element id', function ( assert ) { QUnit.test( 'Reference preview gateway returns source element id', function ( assert ) {
const gateway = createReferenceGateway(), const gateway = createReferenceGateway(),
title = createStubTitle( 1, 'Foo', 'cite note--1' ); title = createStubTitle( 1, 'Foo', 'cite note-1' );
return gateway.fetchPreviewForTitle( title, this.$sourceElement[ 0 ] ).then( ( result ) => { return gateway.fetchPreviewForTitle( title, this.$sourceElement[ 0 ] ).then( ( result ) => {
assert.propEqual( assert.propEqual(
result, result,
{ {
url: '#cite_note--1', url: '#cite_note-1',
extract: 'Footnote 1', extract: 'Footnote 1',
type: 'reference', type: 'reference',
referenceType: null, referenceType: null,
@ -143,7 +143,7 @@ QUnit.test( 'Reference preview gateway rejects non-existing references', functio
QUnit.test( 'Reference preview gateway is abortable', function ( assert ) { QUnit.test( 'Reference preview gateway is abortable', function ( assert ) {
const gateway = createReferenceGateway(), const gateway = createReferenceGateway(),
title = createStubTitle( 1, 'Foo', 'cite note--1' ), title = createStubTitle( 1, 'Foo', 'cite note-1' ),
promise = gateway.fetchPreviewForTitle( title ); promise = gateway.fetchPreviewForTitle( title );
assert.strictEqual( typeof promise.abort, 'function' ); assert.strictEqual( typeof promise.abort, 'function' );