wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-12 09:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Don't render popup on "javascript:..." links."

Browse source
This commit is contained in:
Prtksxna 2014-08-13 11:08:46 +00:00 committed by Gerrit Code Review
parent 51979476dd 0f724cc45f
commit 4cba605476
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
resources/ext.popups.core.js
View file

@ -124,7 +124,7 @@
}; };
/** /**
* Register the hover event on links * Register a hover event that may render a popup on an appropriate link.
* *
* @method setupTriggers * @method setupTriggers
*/ */
@ -134,11 +134,14 @@
$this = $( this ), $this = $( this ),
href = $this.attr( 'href' ); href = $this.attr( 'href' );
// No popup if scrolling or on certain kinds of links.
if ( if (
mw.popups.scrolled || // Prevents hovering on popups while scrolling mw.popups.scrolled || // Prevents hovering on popups while scrolling
href.indexOf( '?' ) !== -1 || href.indexOf( '?' ) !== -1 ||
href.indexOf( 'javascript:' ) === 0 || // jshint ignore:line
href.indexOf( location.origin + location.pathname + '#' ) === 0 href.indexOf( location.origin + location.pathname + '#' ) === 0
) { ) {
// TODO No popup for this, but removeTooltips() has already blanked the title.
return; return;
} }