wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-28 01:10:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Regression: correctly log the click action total interaction time"

Browse source
This commit is contained in:
jenkins-bot 2016-10-04 10:23:46 +00:00 committed by Gerrit Code Review
parent fcde4eaed5 3c0ea0f9cd
commit 46274a5518
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/ext.popups.renderer/desktopRenderer.js
View file

@ -147,8 +147,10 @@
linkInteractionToken: linkInteractionToken
};
$link.on( 'mouseleave blur', mw.popups.render.leaveInactive )
.off( 'click', logClickAction ).on( 'click', logClickAction );
$link
.on( 'mouseleave blur', mw.popups.render.leaveInactive )
.off( 'click', mw.popups.render.clickHandler )
.on( 'click', mw.popups.render.clickHandler );
if ( mw.popups.render.cache[ $link.attr( 'href' ) ] ) {
openTimer = mw.popups.render.wait( mw.popups.render.POPUP_DELAY )

5
resources/ext.popups.targets/desktopTarget.js
View file

@ -138,11 +138,6 @@
mw.popups.$content = $content;
$elements = mw.popups.selectPopupElements();
// On clicking a link the open popup (if any) should be hidden. (T143051)
$elements.on( 'click', function () {
mw.popups.render.closePopup();
} );
$elements.on( 'mouseenter focus', function ( event ) {
var $link = $( this );