wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-23 23:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Consider using more common image sizes for Page previews

Browse source 
Modified necessary files to increase size of popup from 300px to 320px

Bug: T173434
Change-Id: I47bbe9defe961008163551d5be4fc7b1ca08d0d1
This commit is contained in:
smarita 2017-09-23 14:59:02 +05:30 committed by smartyrad
parent 0c64c25c29
commit 3ec185cb01
6 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.json vendored
View file

Binary file not shown.

2
resources/ext.popups/styles/ext.popups.core.less
View file

@ -6,7 +6,7 @@
*/
@popupPadding: 16px;
@popupWidth: 300px;
@popupWidth: 320px;
@popupTallWidth: 215px;
@cogIconSize: 30px;
@lineHeight: 20px;

2
src/constants.js
View file

@ -14,6 +14,6 @@ var $ = jQuery,
export { BUCKETS };
export default {
THUMBNAIL_SIZE: 300 * pixelRatio,
THUMBNAIL_SIZE: 320 * pixelRatio,
EXTRACT_LENGTH: 525
};

4
src/ui/renderer.js
View file

@ -13,10 +13,10 @@ var mw = window.mediaWiki,
},
landscapeImage: {
h: 200, // Max height
w: 300 // Exact Width
w: 320 // Exact Width
},
landscapePopupWidth: 450,
portraitPopupWidth: 300,
portraitPopupWidth: 320,
pokeySize: 8 // Height of the pokey.
},
$window = $( window );

6
tests/node-qunit/ui/renderer.test.js
View file

@ -492,7 +492,7 @@ QUnit.test( 'createThumbnail - landscape image element', function ( assert ) {
height: 150,
expectedX: 0,
expectedY: 0,
expectedSVGWidth: 300 + 3,
expectedSVGWidth: 320 + 3,
expectedSVGHeight: 150,
message: 'Height smaller than the predefined height (200).'
},
@ -501,7 +501,7 @@ QUnit.test( 'createThumbnail - landscape image element', function ( assert ) {
height: 250,
expectedX: 0,
expectedY: ( 250 - 200 ) / -2,
expectedSVGWidth: 300 + 3,
expectedSVGWidth: 320 + 3,
expectedSVGHeight: 200,
message: 'Height bigger than the predefined height (200).'
}
@ -745,7 +745,7 @@ QUnit.test( '#createLayout - empty preview, keyboard event, link is on the cente
{
offset: {
top: 1110,
left: 392
left: 372
},
flippedX: true,
flippedY: true