Merge "Tests: Migrate userSettings.test.js to node-qunit"

This commit is contained in:
jenkins-bot 2017-03-02 11:57:52 +00:00 committed by Gerrit Code Review
commit 3791f245a7
2 changed files with 96 additions and 93 deletions

View file

@ -0,0 +1,96 @@
var stubs = require( './stubs' ),
createStubUser = stubs.createStubUser,
createStubMap = stubs.createStubMap,
createUserSettings = require( '../../src/userSettings' );
QUnit.module( 'ext.popups/userSettings', {
setup: function () {
var stubUser = createStubUser( /* isAnon = */ true );
this.storage = createStubMap();
this.userSettings = createUserSettings( this.storage, stubUser );
}
} );
QUnit.test( '#getIsEnabled should return false if Page Previews have been disabled', function ( assert ) {
assert.expect( 2 );
this.userSettings.setIsEnabled( false );
assert.notOk( this.userSettings.getIsEnabled() );
// ---
this.userSettings.setIsEnabled( true );
assert.ok(
this.userSettings.getIsEnabled(),
'#getIsEnabled should return true if Page Previews have been enabled'
);
} );
QUnit.test( '#hasIsEnabled', function ( assert ) {
var getStub;
assert.expect( 3 );
assert.notOk(
this.userSettings.hasIsEnabled(),
'#hasIsEnabled should return false if the storage is empty.'
);
// ---
this.userSettings.setIsEnabled( false );
assert.ok(
this.userSettings.hasIsEnabled(),
'#hasIsEnabled should return true even if "isEnabled" has been set to falsy.'
);
// ---
getStub = this.sandbox.stub( this.storage, 'get' ).returns( false );
assert.notOk(
this.userSettings.hasIsEnabled(),
'#hasIsEnabled should return false if the storage is disabled.'
);
getStub.restore();
} );
QUnit.test( '#getPreviewCount should return the count as a number', function ( assert ) {
assert.expect( 3 );
assert.strictEqual(
this.userSettings.getPreviewCount(),
0,
'#getPreviewCount returns 0 when the storage is empty.'
);
// ---
this.storage.set( 'ext.popups.core.previewCount', false );
assert.strictEqual(
this.userSettings.getPreviewCount(),
-1,
'#getPreviewCount returns -1 when the storage isn\'t available.'
);
// ---
this.storage.set( 'ext.popups.core.previewCount', '111' );
assert.strictEqual(
this.userSettings.getPreviewCount(),
111
);
} );
QUnit.test( '#setPreviewCount should store the count as a string', function ( assert ) {
this.userSettings.setPreviewCount( 222 );
assert.strictEqual( this.storage.get( 'ext.popups.core.previewCount' ), '222' );
} );

View file

@ -1,93 +0,0 @@
( function ( mw ) {
QUnit.module( 'ext.popups/userSettings', {
setup: function () {
var stubUser = mw.popups.tests.stubs.createStubUser( /* isAnon = */ true );
this.storage = new mw.Map();
this.userSettings = mw.popups.createUserSettings( this.storage, stubUser );
}
} );
QUnit.test( '#getIsEnabled should return false if Page Previews have been disabled', 2, function ( assert ) {
this.userSettings.setIsEnabled( false );
assert.notOk( this.userSettings.getIsEnabled() );
// ---
this.userSettings.setIsEnabled( true );
assert.ok(
this.userSettings.getIsEnabled(),
'#getIsEnabled should return true if Page Previews have been enabled'
);
} );
QUnit.test( '#hasIsEnabled', 3, function ( assert ) {
var getStub;
assert.notOk(
this.userSettings.hasIsEnabled(),
'#hasIsEnabled should return false if the storage is empty.'
);
// ---
this.userSettings.setIsEnabled( false );
assert.ok(
this.userSettings.hasIsEnabled(),
'#hasIsEnabled should return true even if "isEnabled" has been set to falsy.'
);
// ---
getStub = this.sandbox.stub( this.storage, 'get' ).returns( false );
assert.notOk(
this.userSettings.hasIsEnabled(),
'#hasIsEnabled should return false if the storage is disabled.'
);
getStub.restore();
} );
QUnit.test( '#getPreviewCount should return the count as a number', function ( assert ) {
assert.expect( 3 );
assert.strictEqual(
this.userSettings.getPreviewCount(),
0,
'#getPreviewCount returns 0 when the storage is empty.'
);
// ---
this.storage.set( 'ext.popups.core.previewCount', false );
assert.strictEqual(
this.userSettings.getPreviewCount(),
-1,
'#getPreviewCount returns -1 when the storage isn\'t available.'
);
// ---
this.storage.set( 'ext.popups.core.previewCount', '111' );
assert.strictEqual(
this.userSettings.getPreviewCount(),
111
);
} );
QUnit.test( '#setPreviewCount should store the count as a string', function ( assert ) {
assert.expect( 1 );
this.userSettings.setPreviewCount( 222 );
assert.strictEqual( this.storage.get( 'ext.popups.core.previewCount' ), '222' );
} );
}( mediaWiki ) );