wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-09-24 02:39:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Upgrade stylelint-config-wikimedia and remove stylelint

Browse source 
The following upgrade was made:

stylelint-config-wikimedia | 0.4.3 | 0.5.0

The upgraded version stylelint-config-wikimedia includes stylelint as a
dependency (no longer a peer dependency) [1] so our stylelint dependency was
removed.

As a result of this upgrade, several of our .less files were flagged by
the linter and corrected in this patch.

[1] https://github.com/wikimedia/stylelint-config-wikimedia/blob/v0.5.0/package.json#L36

Bug: T209314
Change-Id: Ic6d4b1caf60f4e03fa60076a2ae74d6639117f25
This commit is contained in:
Nick Ray 2018-12-12 20:14:09 -07:00 committed by Nicholas Ray
parent c64497e5df
commit 2ed5587945
4 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
package.json
View file

@ -38,8 +38,7 @@
"nyc": "13.1.0",
"redux": "3.6.0",
"redux-thunk": "2.2.0",
"stylelint": "9.2.0",
"stylelint-config-wikimedia": "0.4.3",
"stylelint-config-wikimedia": "0.5.0",
"svg-inline-loader": "0.8.0",
"tap-mocha-reporter": "3.0.7",
"wdio-junit-reporter": "0.4.4",

1
src/ui/templates/pagePreview/pagePreview.less
View file

@ -11,6 +11,7 @@
margin: 4px 4px 2px 4px; // adjusts position
text-indent: -1em; // offsets .mw-ui-icon-element:before { margin: 0 1em; }
border-radius: @borderRadius;
&:hover {
background-color: @colorGray14;
}

9
src/ui/templates/popup/popup.less
View file

@ -30,8 +30,7 @@
// icons positioned at the top of the popup
.mw-ui-icon-preview-disambiguation,
.mw-ui-icon-preview-generic
{
.mw-ui-icon-preview-generic {
margin: 21px 0 8px 0;
}
@ -56,7 +55,6 @@
// SVG element is forced not to occlude the truncating pseudo-element and
// the settings cog in IE9-11.
margin: @popupPadding;
display: block;
color: @colorText;
text-decoration: none;
@ -108,6 +106,7 @@
p {
margin: 0;
}
ul,
ol,
li,
@ -307,11 +306,13 @@
polyline {
.mwe-popups-translate( 0, 0 );
}
&.flipped-x-y {
polyline {
.mwe-popups-translate( 0, -8px );
}
}
&.flipped-x {
polyline {
.mwe-popups-translate( 0, 8px );
@ -323,11 +324,13 @@
polyline {
.mwe-popups-translate( -100%, 0 );
}
&.flipped-x-y {
polyline {
.mwe-popups-translate( -100%, -8px );
}
}
&.flipped-x {
polyline {
.mwe-popups-translate( -100%, 8px );

1
src/ui/templates/settingsDialog/settingsDialog.less
View file

@ -105,7 +105,6 @@
.mwe-popups-settings-help {
@imageWidth: 180px;
@imageHeight: 140px;
font-size: 13px;
font-weight: 800;
margin: 40px;