Merge "Hygiene: Remove "I am on the ... page" step" into mpga

tests/browser/features/previews.feature

@@ -1,10 +1,9 @@
 @chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org @vagrant
 Feature: Previews
   Background:
-    Given the test page has been created
-    And I am logged in
+    Given I am logged in
     And I have enabled the beta feature
-    And I am on the "Popups test page" page
+    And I am on the test page
     And the RL module has loaded
 
   Scenario: Dwelling on a valid link shows a preview

tests/browser/features/support/step_definitions/common_steps.rb

@@ -1,15 +1,15 @@
-Given(/^the test page has been created$/) do
-  api.create_page 'Popups test page', File.read('samples/links.wikitext')
-end
-
-Given(/^I am on the "(.*?)" page$/) do |page|
-  visit(ArticlePage, using_params: { article_name: page })
-end
+TEST_PAGE_TITLE = 'Popups test page'
 
 Given(/^I have enabled the beta feature$/) do
   visit(SpecialPreferencesPage).enable_page_previews
 end
 
+Given(/^I am on the test page$/) do
+  api.create_page TEST_PAGE_TITLE, File.read('fixtures/test_page.wikitext')
+
+  visit(ArticlePage, using_params: { article_name: TEST_PAGE_TITLE })
+end
+
 Given(/^the RL module has loaded$/) do
   on(ArticlePage) do |page|
     page.wait_until do