wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-13 17:56:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not export private renderer functions

Browse source 
Most of the code is exported because is is tested separately. But
these are all tested via createPreviewWithType(). I think it's just a
minor mistake to have these exported.

Change-Id: Ic4f4dc40fd95a60aba45cb5aa3fcbb6e3bc8c386
This commit is contained in:
Thiemo Kreuz 2019-01-21 13:26:11 +01:00
parent dcbbefe2fc
commit 197aefda3c
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

6
src/ui/renderer.js
View file

@ -164,7 +164,7 @@ export function getExtractWidth( thumbnail ) {
* @param {ext.popups.PreviewModel} model
* @return {ext.popups.Preview}
*/
export function createPagePreview( model ) {
function createPagePreview( model ) {
const thumbnail = createThumbnail( model.thumbnail ),
hasThumbnail = thumbnail !== null,
extract = model.extract;
@ -201,7 +201,7 @@ export function createPagePreview( model ) {
* @param {ext.popups.PreviewModel} model
* @return {ext.popups.Preview}
*/
export function createEmptyPreview( model ) {
function createEmptyPreview( model ) {
const showTitle = false,
extractMsg = mw.msg( 'popups-preview-no-preview' ),
linkMsg = mw.msg( 'popups-preview-footer-read' );
@ -223,7 +223,7 @@ export function createEmptyPreview( model ) {
* @param {ext.popups.PreviewModel} model
* @return {ext.popups.Preview}
*/
export function createDisambiguationPreview( model ) {
function createDisambiguationPreview( model ) {
const showTitle = true,
extractMsg = mw.msg( 'popups-preview-disambiguation' ),
linkMsg = mw.msg( 'popups-preview-disambiguation-link' );