diff --git a/resources/ext.popups.renderer.article.js b/resources/ext.popups.renderer.article.js index 5be74c816..3c7fdea91 100644 --- a/resources/ext.popups.renderer.article.js +++ b/resources/ext.popups.renderer.article.js @@ -558,6 +558,6 @@ } }; - mw.popups.render.article = article; + mw.popups.render.renderers.article = article; } ) ( jQuery, mediaWiki ); diff --git a/resources/ext.popups.renderer.js b/resources/ext.popups.renderer.js index bfcd0c44d..fdf758be1 100644 --- a/resources/ext.popups.renderer.js +++ b/resources/ext.popups.renderer.js @@ -54,6 +54,12 @@ */ mw.popups.render.currentRequest = undefined; + /** + * Object to store all renderers + * @property {Object} renderers + */ + mw.popups.render.renderers = {}; + /** * Close all other popups and render the new one from the cache * or by finding and calling the correct renderer @@ -104,7 +110,7 @@ .done( function () { // TODO: check for link type and call correct renderer // There is only one popup type right now so it isn't necessary - var cachePopup = mw.popups.render.article.init( link ); + var cachePopup = mw.popups.render.renderers.article.init( link ); mw.popups.render.openTimer = mw.popups.render.wait( mw.popups.render.POPUP_DELAY - mw.popups.render.API_DELAY ); diff --git a/tests/qunit/ext.popups.renderer.article.test.js b/tests/qunit/ext.popups.renderer.article.test.js index 6c735f077..342ac1aae 100644 --- a/tests/qunit/ext.popups.renderer.article.test.js +++ b/tests/qunit/ext.popups.renderer.article.test.js @@ -1,13 +1,13 @@ ( function ( $, mw ) { - QUnit.module( 'ext.popups.renderer.article', QUnit.newMwEnvironment() ); + QUnit.module( 'ext.popups.renderer.renderers.article', QUnit.newMwEnvironment() ); QUnit.test( 'render.article.getProcessedElements', function ( assert ) { QUnit.expect( 13 ); function test ( extract, title, expected, msg ) { var $div = $( '
' ).append( - mw.popups.render.article.getProcessedElements( extract, title ) + mw.popups.render.renderers.article.getProcessedElements( extract, title ) ); assert.equal( $div.html(), expected, msg ); }