mediawiki-extensions-Popups/.phpcs.xml

<?xml version="1.0"?>
<ruleset>
	<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />

	<rule ref="Squiz.Strings.DoubleQuoteUsage">
		<exclude name="Squiz.Strings.DoubleQuoteUsage.ContainsVar" />
	</rule>
	<rule ref="Squiz.WhiteSpace.FunctionSpacing">
		<properties>
			<property name="spacing" value="1" />
		</properties>
	</rule>

	<file>.</file>
	<arg name="extensions" value="php,php5,inc" />
	<arg name="encoding" value="UTF-8" />
</ruleset>
Introduce PHPCS check in CI Introduced PHPCS check in CI - using same configuration as in MobileFrontend. Additionally fixed wrong code style. Change-Id: I0c879553d355c2a277fcc4349a93e85c65eb2291 2017-05-16 17:59:29 +00:00			`<?xml version="1.0"?>`
			`<ruleset>`
Add missing "public" visibility in PopupsHooks.php Public is the default, and hook handlers must be public. I assume this was nothing but a mistake. Change-Id: I20eedfd8c4cb954db770afdda3f373e272530b82 2018-05-20 19:13:36 +00:00			`<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />`
Enable Squiz.Strings.DoubleQuoteUsage PHPCS sniff The majority of this was fixed just recently via I8de42df. The sniff makes sure all old and new code conforms to this style. Change-Id: I8aecf3653d021fc8f86abcdc5939529864f86a48 2019-03-01 10:28:20 +00:00
			`<rule ref="Squiz.Strings.DoubleQuoteUsage">`
			`<exclude name="Squiz.Strings.DoubleQuoteUsage.ContainsVar" />`
			`</rule>`
Add some missing newlines to separate PHP code better I believe these additional newlines all make the code easier to read. It's easier to see what belongs together, and what is a separate thing. I found the Squiz.WhiteSpace.FunctionSpacing sniff very helpful to enforce this code style. We enabled this already in almost all WMDE codebases. It is not yet part of the upstream MediaWiki rule set, but discussed. Change-Id: Ibdf788529b28637bf98e7940c2516852c3afcef7 2019-02-26 10:55:57 +00:00			`<rule ref="Squiz.WhiteSpace.FunctionSpacing">`
			`<properties>`
			`<property name="spacing" value="1" />`
			`</properties>`
			`</rule>`
Enable Squiz.Strings.DoubleQuoteUsage PHPCS sniff The majority of this was fixed just recently via I8de42df. The sniff makes sure all old and new code conforms to this style. Change-Id: I8aecf3653d021fc8f86abcdc5939529864f86a48 2019-03-01 10:28:20 +00:00
Introduce PHPCS check in CI Introduced PHPCS check in CI - using same configuration as in MobileFrontend. Additionally fixed wrong code style. Change-Id: I0c879553d355c2a277fcc4349a93e85c65eb2291 2017-05-16 17:59:29 +00:00			`<file>.</file>`
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.FunctionComment.MissingParamComment * MediaWiki.Commenting.FunctionComment.MissingParamTag * MediaWiki.Commenting.FunctionComment.MissingReturn * MediaWiki.Commenting.FunctionComment.ParamNameNoMatch * MediaWiki.FunctionComment.Missing.Public * MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment Change-Id: Id9e98b7a4e87d00c63e7b509506c23f12cf0d380 2017-06-20 07:19:34 +00:00			`<arg name="extensions" value="php,php5,inc" />`
Improve some parameter docs Change-Id: Ic78a889eb7374731a282312c9eadb701483ae298 2017-08-10 11:23:37 +00:00			`<arg name="encoding" value="UTF-8" />`
Introduce PHPCS check in CI Introduced PHPCS check in CI - using same configuration as in MobileFrontend. Additionally fixed wrong code style. Change-Id: I0c879553d355c2a277fcc4349a93e85c65eb2291 2017-05-16 17:59:29 +00:00			`</ruleset>`