wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-14 19:25:33 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Popups/extension.json

233 lines
7.3 KiB
JSON
Raw Normal View History

Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
{
"name": "Popups",
Remove BetaFeature code Popups is out of beta feature and this code is no longer needed. Removing code is the happiest activity a developer can do. Other changes: * Remove redundant type field on extension.json (If not set, the extension will default to the "other" section.) * Repurpose `name` with `namemsg` and make use of existing i18n messages Bug: T193053 Change-Id: Iea832cd1f37b0e7df6ff95efd66e4a1ff2a9004e
2018-04-26 20:43:05 +00:00
"namemsg": "popups-message",
Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
"author": [
"Prateek Saxena",
Update extension authors Change-Id: Iee16b902247396ed9fc849d433f0a0d6fb2f85e7
2018-05-04 23:32:51 +00:00
"[https://www.mediawiki.org/wiki/Reading/Web/Team Readers Web Team]",
Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
"Yair Rand"
],
"url": "https://www.mediawiki.org/wiki/Extension:Popups",
"descriptionmsg": "popups-desc",
Use SPDX 3.0 license identifier SPDX released version 3 of their license list (<https://spdx.org/licenses/>), which changed the FSF licenses to explicitly end in -only or -or-later instead of relying on an easy to miss + symbol. Bug: T183858 Change-Id: If21be3dd6d81dbeb30911bbe3be29e20b55bf6da
2018-03-02 23:33:58 +00:00
"license-name": "GPL-2.0-or-later",
Hygiene: Update required MediaWiki version Per I28003c5898d64031e1efb212cb0bec58ff44b958 Popups require at least MediaWiki version 1.30. Documentation should respect that Change-Id: Ifc87ac5cdcf61ae54cefe3f6ccab7aac5c52e0a6
2017-07-24 14:12:03 +00:00
"requires": {
Require MediaWiki 1.31 in extension.json for AutoloadNamespaces AutoloadNamespaces is a new feature in 1.31 Change-Id: Ice5e01cf780aae12653916c6dc893557354eecfe
2019-12-28 12:44:09 +00:00
"MediaWiki": ">= 1.31.0"
Hygiene: Update required MediaWiki version Per I28003c5898d64031e1efb212cb0bec58ff44b958 Popups require at least MediaWiki version 1.30. Documentation should respect that Change-Id: Ifc87ac5cdcf61ae54cefe3f6ccab7aac5c52e0a6
2017-07-24 14:12:03 +00:00
},
Update extension.json to make use of PSR-4 As far as I can see this codebase is already PSR-4 compatible. Let's make use of it then. Change-Id: I45a8492ce52d96acaf27e73d20e06e68de892686
2019-11-27 09:12:03 +00:00
"AutoloadNamespaces": {
"Popups\\": "includes/"
Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
},
"ConfigRegistry": {
"popups": "GlobalVarConfig::newInstance"
},
"Hooks": {
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
"BeforePageDisplay": "Popups\\PopupsHooks::onBeforePageDisplay",
"ResourceLoaderGetConfigVars": "Popups\\PopupsHooks::onResourceLoaderGetConfigVars",
"GetPreferences": "Popups\\PopupsHooks::onGetPreferences",
"PreferencesFormPreSave": "Popups\\UserPreferencesChangeHandler::onPreferencesFormPreSave",
"UserGetDefaultOptions": "Popups\\PopupsHooks::onUserGetDefaultOptions",
"MakeGlobalVariablesScript": "Popups\\PopupsHooks::onMakeGlobalVariablesScript",
"LocalUserCreated": "Popups\\PopupsHooks::onLocalUserCreated",
"GetBetaFeaturePreferences": "Popups\\PopupsHooks::onGetBetaFeaturePreferences"
Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
},
"MessagesDirs": {
"Popups": [
"i18n"
]
},
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
"attributes": {
"EventLogging": {
"Schemas": {
"Popups": 18904225,
"ReferencePreviewsPopups": 19489344,
"VirtualPageView": 17780078
}
}
Move EventLogging schema registration into extension.json Change-Id: I9dea6584d5e811d761542f207a5f63357479d644 Depends-On: I01aa2887a9b98c2ef52cacc3a892390a72b4a3ba
2015-12-23 00:46:45 +00:00
},
Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
"config": {
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
"PopupsVirtualPageViews": {
"description": "@var bool: Whether the extension should log virtual pageviews.",
"value": false
},
"PopupsHideOptInOnPreferencesPage": {
"description": "@var bool: Whether the option to enable/disable Page Previews should be hidden on Preferences page. False by default",
"value": false
},
"PopupsOptInDefaultState": {
"description": "@var string:['1'|'0'] Default Page Previews visibility for old accounts. Has to be a string as a compatibility with beta feature settings. For more info see @T191888",
Enable by default Popups is enabled on the Wikipedias but disabled by default, which makes it more difficult to enable on third-party wikis. Things should be enabled by default, and them WMF configs should disable features when they are not used/available. Supporting changes: - Rename PopupsContextTest#testAnonUserHasDisabledPagePreviews and remove the associated data provider, which provided only one datum - Set $wgPopupsReferencePreviews to false in PopupsContextTest#testShouldSendModuleToUser in order to isolate the code under test Change-Id: Ib8cc7041d792bed0a19d18e14506627099a69bef
2019-12-11 19:04:21 +00:00
"value": "1"
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
},
"PopupsOptInStateForNewAccounts": {
"description": "@var string:['1'|'0'] Default Page Previews visibility for newly created accounts (from Q2 2018). For more info see @T191888",
Enable by default Popups is enabled on the Wikipedias but disabled by default, which makes it more difficult to enable on third-party wikis. Things should be enabled by default, and them WMF configs should disable features when they are not used/available. Supporting changes: - Rename PopupsContextTest#testAnonUserHasDisabledPagePreviews and remove the associated data provider, which provided only one datum - Set $wgPopupsReferencePreviews to false in PopupsContextTest#testShouldSendModuleToUser in order to isolate the code under test Change-Id: Ib8cc7041d792bed0a19d18e14506627099a69bef
2019-12-11 19:04:21 +00:00
"value": "1"
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
},
"PopupsConflictingNavPopupsGadgetName": {
"description": "@var string: Navigation popups gadget name",
"value": "Navigation_popups"
},
"PopupsGateway": {
"description": "Which gateway to use for fetching Popups data. Available options: [mwApiPlain|restbasePlain|restbaseHTML]. Full and always up to date list is available in src/gateway/index.js",
"value": "mwApiPlain"
},
"PopupsRestGatewayEndpoint": {
"description": "Specify a REST endpoint where summaries should be sourced from. Endpoint must meet the spec at https://www.mediawiki.org/wiki/Specs/Summary/1.2.0",
"value": "/api/rest_v1/page/summary/"
},
"PopupsReferencePreviews": {
"description": "Temporary feature flag to disable reference previews during developement.",
"value": true
},
"PopupsReferencePreviewsBetaFeature": {
"description": "Make Reference Previews a Beta feature.",
"value": true
},
"PopupsEventLogging": {
"description": "Whether we should log events. Note if this is enabled without using that variable events will be logged for all users without any sampling! Be careful!",
"value": false
},
"PopupsStatsvSamplingRate": {
"description": "Sampling rate for logging performance data to statsv.",
"value": 0
},
Popups: Rename new config variable In this patch we introduce a new config variable and update its default to be the same as the production value of $wgPopupsPageBlacklist. When this code is deployed everywhere, we will remove wgPopupsPageBlacklist from mediawiki config and defer to the Popups extension as the source of truth from now on. Bug: T254676 Change-Id: Ifebdcf8f5eec854a2b947dc390eaf47704a5c5eb
2020-07-02 22:09:22 +00:00
"PopupsPageDisabled": {
Talk about "exclusions" instead of "blacklists" AVoid the term if possible, in all internal code. The only remaining use of the word is in the public $wgPopupsPageBlacklist config variable. Change-Id: Ib238731270f473ad44fcff13df617a70433f2452
2020-06-09 06:52:42 +00:00
"description": "List of pages that should not show Popups. Includes subpages. These pages are subject to the HTML cache policy of the wiki. A purge on these pages maybe needed to see the effect of this configuration variable. Every excluded page should be defined by a canonical name, eg: Special:Userlogin",
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
"value": [
Popups: Rename new config variable In this patch we introduce a new config variable and update its default to be the same as the production value of $wgPopupsPageBlacklist. When this code is deployed everywhere, we will remove wgPopupsPageBlacklist from mediawiki config and defer to the Popups extension as the source of truth from now on. Bug: T254676 Change-Id: Ifebdcf8f5eec854a2b947dc390eaf47704a5c5eb
2020-07-02 22:09:22 +00:00
"Special:CreateAccount",
"Special:GlobalRenameRequest",
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
"Special:Userlogin",
Popups: Rename new config variable In this patch we introduce a new config variable and update its default to be the same as the production value of $wgPopupsPageBlacklist. When this code is deployed everywhere, we will remove wgPopupsPageBlacklist from mediawiki config and defer to the Popups extension as the source of truth from now on. Bug: T254676 Change-Id: Ifebdcf8f5eec854a2b947dc390eaf47704a5c5eb
2020-07-02 22:09:22 +00:00
"Special:MergeAccount",
"Special:ChangeCredentials",
"Special:OAuthListConsumers",
"Special:GlobalUserRights",
"Special:Notifications",
"Special:UserRights",
"Special:Upload",
"Special:VipsTest",
"Special:ApiFeatureUsage",
"Special:ExpandTemplates",
"Special:GadgetUsage",
"Special:GraphSandbox",
"Special:TemplateSandbox",
"Special:MostLinkedFiles",
"Special:Book"
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
]
}
Add link preview feature to mobile beta mode Linkpreview will try to fetch a text extract using the api and, if this doesn't fail, show the extract as a drawer with a button "Continue to article". If the query fails, it will redirect the user to the article directly. Bug: T113243 Depends-On: I6d8c5b80e70c3d8d1a92a70cc91e1b90d598cb0f Change-Id: Idbaae9fe2decd89b73e623a25fbd39464c316fb2
2016-01-29 17:06:33 +00:00
},
Prepare Popups for adding of mobile specific Popups implementation For the work on T113243, the Popups extension should be structured in a more flexible way. This is achieved with this change. Following has changed: * The main/core logic of Popups now lives in ext.popups.core to be shareable between implementations * The desktop specific logic lives in ext.popups.desktop now, the frontend init code in ext.popups.desktopTarget and the desktop renderer in ext.popups.renderer.desktopRenderer This change doesn't change the functionality of Popups. Change-Id: I72121e0a1e4b2952f85dc1bc8cf59d06b8d22f47
2016-01-29 16:48:24 +00:00
"ResourceModules": {
Add (i) info icon to collapsible replacement message This avoids pulling in the entirety of OOjs, with the disadvantage that we have to copy a little bit of CSS. I copied parts of this patch from I2a28666. There might be a better way to do this, with less code. E.g. is there a better way to construct these HTML elements? Bug: T220208 Change-Id: I024155f3ff0f57de1d68bbaf37bfb9e81e692bd0
2020-10-28 16:57:43 +00:00
"ext.popups.icons": {
"class": "ResourceLoaderOOUIIconPackModule",
"icons": [
"infoFilled"
]
},
Hovercards: Improve layout of settings dialog to design spec Improving Hovercards' settings dialog to fulfill design specification. Also fixing HTML structure by removing invalid `radiogroup` element and adding missing `</div>` element, fixing related QUnit test. Changes: * Add close icon instead of using text * Style header as a table for alignment * Remove redundant "OK" button and have it replace "Save" instead * Update text of "OK" button to "Done" * Fix description for translation of "Done" button * Fix qunit and selenium tests * Remove unnecessary markup and less * Add mediawiki-ui-button and mediawiki-ui-icon dependencies * Shrink dialog width some per design spec * Fix dialog horizontal position calculation to remove hard-coded value Bug: T138612 Change-Id: I7395e3438836149becdd576942bdaf6f21b4163f
2016-06-24 16:25:20 +00:00
"ext.popups.images": {
"selector": ".mw-ui-icon-{name}:before",
"class": "ResourceLoaderImageModule",
"images": {
Generate cog icon via ResourceLoaderImage module * Merge mwe-popups-icon with mwe-popups-settings-icon * Remove PNG - now generated by the ResourceLoader module * Adjust popup footer paddings/widths and store them in variables * RTL and LTR compatible Bug: T133956 Change-Id: I14ccd7b6731e9ec49f9959411fd17f7c9fdf43be
2017-04-20 21:59:57 +00:00
"popups-settings": "resources/ext.popups.images/cog.svg",
Custom page preview for disambiguation pages Creating a different page preview for disambiguation pages. This patch: - modifies the Preview model to accept a new 'type' property - modifies the Restbase Gateway to pass the 'type' prop to the Preview model - creates a new template to accept both generic/disambig previews - modifies the renderer to render the new template - generates icons for new template through resource loader - adds new i18n strings - modifies event-logging "preview seen" event to send new "disambiguation" previewType - updates event logging schema version - adds tests for Preview model and renderer for new preview type - does way too much? yes, yes it does. Bug: T168392 Change-Id: Idc936cc3eabbdd99a3d98f43c66b4cdbb7d24917
2018-03-07 11:10:53 +00:00
"popups-close": "resources/ext.popups.images/close.svg",
Update OOUI icons to latest versions * web.svg was deprecated in favour of browser.svg. * Update sad-face.svg based on OOUI speechBubble-ltr/rtl * Apply preview-generic/disambiguation grey colour using CSS. Change-Id: I8feea1b526ff85c4ffdee21ef42c616e72881e76
2019-04-12 12:22:37 +00:00
"preview-generic": {
"file": {
"ltr": "resources/ext.popups.images/sad-face-ltr.svg",
"rtl": "resources/ext.popups.images/sad-face-rtl.svg"
}
},
All images are served by ResourceLoaderImageModule This moves the footer icon into the ResourceLoaderImage module providing us a consistent way of serving image assets. This means we no longer need to provide PNGs for icons However, given mw-ui-icon-large is not large enough for the given use case we do have to wrestle with icon styles and override them to get the desired result. I think this is a small price to pay given icons are now discoverable Change-Id: I38b62c01fd930dcbfb73b95e6128885cb483f86e
2018-04-03 23:32:40 +00:00
"footer": {
"file": {
"ltr": "resources/ext.popups.images/footer-ltr.svg",
"rtl": "resources/ext.popups.images/footer-rtl.svg"
}
},
Standardise disambiguation icon All icons should be 20 by 20 by standard. (Previously it was 24 by 24) Bug: T190558 Change-Id: I0956c9c31f1606f0a77b4be29bde5a56b5c5ebb8
2018-03-23 18:45:40 +00:00
"preview-disambiguation": {
"file": {
Update OOUI icons to latest versions * web.svg was deprecated in favour of browser.svg. * Update sad-face.svg based on OOUI speechBubble-ltr/rtl * Apply preview-generic/disambiguation grey colour using CSS. Change-Id: I8feea1b526ff85c4ffdee21ef42c616e72881e76
2019-04-12 12:22:37 +00:00
"ltr": "resources/ext.popups.images/articles-ltr.svg",
"rtl": "resources/ext.popups.images/articles-rtl.svg"
Standardise disambiguation icon All icons should be 20 by 20 by standard. (Previously it was 24 by 24) Bug: T190558 Change-Id: I0956c9c31f1606f0a77b4be29bde5a56b5c5ebb8
2018-03-23 18:45:40 +00:00
}
Add default OOUI reference icon to all reference popups I tried hard to keep the CSS as small and robust as possible. The icon will be align with the text by adding a negativ margin. With that we also decided against using RTL and LTR specific icons that are positioned at the edge of the canvas for now. Bug: T213907 Change-Id: I98888114e1c50e249cf31e71749323bd4f69da3f
2019-01-24 17:48:13 +00:00
},
Add all reference type icons and messages These icons are currently unused because the gateway does not deliver the necessary information. This will be used starting with I6223cbb. This patch aims to introduce all resources needed by the later. Bug: T214908 Change-Id: Ie0c3c059222700169f2605c3123554c74d974256
2019-02-16 09:13:23 +00:00
"reference-generic": "resources/ext.popups.images/reference.svg",
"reference-book": {
"file": {
"ltr": "resources/ext.popups.images/book-ltr.svg",
"rtl": "resources/ext.popups.images/book-rtl.svg"
}
},
"reference-journal": {
"file": {
"ltr": "resources/ext.popups.images/journal-ltr.svg",
"rtl": "resources/ext.popups.images/journal-rtl.svg"
}
},
"reference-news": {
"file": {
"ltr": "resources/ext.popups.images/newspaper-ltr.svg",
"rtl": "resources/ext.popups.images/newspaper-rtl.svg"
}
},
Update OOUI icons to latest versions * web.svg was deprecated in favour of browser.svg. * Update sad-face.svg based on OOUI speechBubble-ltr/rtl * Apply preview-generic/disambiguation grey colour using CSS. Change-Id: I8feea1b526ff85c4ffdee21ef42c616e72881e76
2019-04-12 12:22:37 +00:00
"reference-web": {
"file": {
"ltr": "resources/ext.popups.images/browser-ltr.svg",
"rtl": "resources/ext.popups.images/browser-rtl.svg"
}
}
Hovercards: Improve layout of settings dialog to design spec Improving Hovercards' settings dialog to fulfill design specification. Also fixing HTML structure by removing invalid `radiogroup` element and adding missing `</div>` element, fixing related QUnit test. Changes: * Add close icon instead of using text * Style header as a table for alignment * Remove redundant "OK" button and have it replace "Save" instead * Update text of "OK" button to "Done" * Fix description for translation of "Done" button * Fix qunit and selenium tests * Remove unnecessary markup and less * Add mediawiki-ui-button and mediawiki-ui-icon dependencies * Shrink dialog width some per design spec * Fix dialog horizontal position calculation to remove hard-coded value Bug: T138612 Change-Id: I7395e3438836149becdd576942bdaf6f21b4163f
2016-06-24 16:25:20 +00:00
}
},
Remove ResourceLoaderRegisterModules hook handler We should endeavour to define Resource Loader modules in one place, extension.json. Adding them to the output, however... Changes: * Remove ResourceLoaderRegisterModules hook handler. * Move all dependencies, messages, templates, and styles into "empty" RL module definitions in extension.json so that they don't have to be looked up later. Change-Id: I7ec963e3296de8f411e90079ab13b97c6eba4916
2016-11-08 07:57:30 +00:00
"ext.popups": {
Enable Popups module in mobile, use feature detection to enable This means that users of the mobile site on a desktop browser will now benefit from Popups. Targets is not necessary for `ext.popups.images` as these modules are enabled on mobile by default. Bug: T236097 Change-Id: I401fbb522ec97fdc81259702c8283c95386531af
2020-02-11 07:55:25 +00:00
"targets": [ "desktop", "mobile" ],
Remove popups from critical rendering path Instead load it via mw.loader.using We retain the module name ext.popups as this will be present in cached HTML, however now it will load the bulk of the code inside ext.popups.main Bug: T176211 Change-Id: Ibe212721807d3698dc45ef46b2dbde15ca9d2f70
2017-10-16 20:09:56 +00:00
"scripts": [
"resources/ext.popups/index.js"
]
},
"ext.popups.main": {
Enable Popups module in mobile, use feature detection to enable This means that users of the mobile site on a desktop browser will now benefit from Popups. Targets is not necessary for `ext.popups.images` as these modules are enabled on mobile by default. Bug: T236097 Change-Id: I401fbb522ec97fdc81259702c8283c95386531af
2020-02-11 07:55:25 +00:00
"targets": [ "desktop", "mobile" ],
Use Redux and Redux Thunk Changes: * Create the ext.popups.lib module, which contains redux@3.6.0 and redux-thunk@2.1.0. * Rely on the Resource Loader's minification and mangling (?) mechanisms. * Create an asynchronous bootstrap script, which creates a Redux store when the User Agent is idle. Change-Id: Ib7168217a5673bb2a8378eb30d6aa45043c66e62
2016-11-08 10:05:40 +00:00
"scripts": [
Tooling: Separate built resources from RL resources In order to automatically verify in CI that the built assets are up to date with the commited sources, we need to keep the built assets in a folder separate from the RL assets. * Rename the compiled assets folder to industry standard `dist` Change-Id: I8c5898f9bb29fee7164a7038b835a5f7efd33dbc
2017-02-13 13:47:59 +00:00
"resources/dist/index.js"
Use Redux and Redux Thunk Changes: * Create the ext.popups.lib module, which contains redux@3.6.0 and redux-thunk@2.1.0. * Rely on the Resource Loader's minification and mangling (?) mechanisms. * Create an asynchronous bootstrap script, which creates a Redux store when the User Agent is idle. Change-Id: Ib7168217a5673bb2a8378eb30d6aa45043c66e62
2016-11-08 10:05:40 +00:00
],
Remove ResourceLoaderRegisterModules hook handler We should endeavour to define Resource Loader modules in one place, extension.json. Adding them to the output, however... Changes: * Remove ResourceLoaderRegisterModules hook handler. * Move all dependencies, messages, templates, and styles into "empty" RL module definitions in extension.json so that they don't have to be looked up later. Change-Id: I7ec963e3296de8f411e90079ab13b97c6eba4916
2016-11-08 07:57:30 +00:00
"styles": [
Hygiene: split LESS into components Bug: T165036 Change-Id: I916f27138b5abe6b9fe23719cffb10f20e604b89
2018-03-27 19:10:48 +00:00
"src/ui/index.less"
Prepare Popups for adding of mobile specific Popups implementation For the work on T113243, the Popups extension should be structured in a more flexible way. This is achieved with this change. Following has changed: * The main/core logic of Popups now lives in ext.popups.core to be shareable between implementations * The desktop specific logic lives in ext.popups.desktop now, the frontend init code in ext.popups.desktopTarget and the desktop renderer in ext.popups.renderer.desktopRenderer This change doesn't change the functionality of Popups. Change-Id: I72121e0a1e4b2952f85dc1bc8cf59d06b8d22f47
2016-01-29 16:48:24 +00:00
],
Remove ResourceLoaderRegisterModules hook handler We should endeavour to define Resource Loader modules in one place, extension.json. Adding them to the output, however... Changes: * Remove ResourceLoaderRegisterModules hook handler. * Move all dependencies, messages, templates, and styles into "empty" RL module definitions in extension.json so that they don't have to be looked up later. Change-Id: I7ec963e3296de8f411e90079ab13b97c6eba4916
2016-11-08 07:57:30 +00:00
"messages": [
"popups-settings-title",
"popups-settings-option-simple",
"popups-settings-option-simple-description",
"popups-settings-option-advanced",
"popups-settings-option-advanced-description",
"popups-settings-option-off",
"popups-settings-save",
"popups-settings-cancel",
"popups-settings-enable",
"popups-settings-help",
"popups-settings-help-ok",
previews: Add generic fallback preview Changes: * Make the gateway handle missing pages, which are characterised by the MediaWiki API response having both the missing property set to truthy and the page not having any revisions. * Add the preview-empty template and associated "mwe-popups-is-empty" CSS class, which describe what an empty preview contains and how it should look. Supporting changes: * Move the original preview template into the ext.popups module. Bug: T151054 Change-Id: Ife75bf9c6bafdfe0a6cc3e20eea853b4ac8f951b
2016-11-29 12:34:52 +00:00
"popups-preview-no-preview",
Custom page preview for disambiguation pages Creating a different page preview for disambiguation pages. This patch: - modifies the Preview model to accept a new 'type' property - modifies the Restbase Gateway to pass the 'type' prop to the Preview model - creates a new template to accept both generic/disambig previews - modifies the renderer to render the new template - generates icons for new template through resource loader - adds new i18n strings - modifies event-logging "preview seen" event to send new "disambiguation" previewType - updates event logging schema version - adds tests for Preview model and renderer for new preview type - does way too much? yes, yes it does. Bug: T168392 Change-Id: Idc936cc3eabbdd99a3d98f43c66b4cdbb7d24917
2018-03-07 11:10:53 +00:00
"popups-preview-footer-read",
"popups-preview-disambiguation",
Add reference preview type This adds support for preview popups on reference/footnotes from the Cite extension. For that a new preview type was introduced and integrated into the existing structures. The essential starting points were this code comes into action are added behind the feature flag introduced in the previous patches. Bug: T213415 Change-Id: Ie0ccb03117bd654373d0f458b62cc52018361c67
2018-12-12 18:37:19 +00:00
"popups-preview-disambiguation-link",
Consistently talk about "Reference" instead of "Footnote" During story time on 2019-03-12 it was decided to consistently talk about "References" in all messages. Main motivation is that this is the term the community is most familiar with, and it is also the term that is used in reference section headings most of the time. Bug: T215063 Change-Id: Iaab8d2c0da1546a3c9d27bc8e2e1c784050ed135
2019-03-12 16:23:46 +00:00
"popups-refpreview-reference",
Add all reference type icons and messages These icons are currently unused because the gateway does not deliver the necessary information. This will be used starting with I6223cbb. This patch aims to introduce all resources needed by the later. Bug: T214908 Change-Id: Ie0c3c059222700169f2605c3123554c74d974256
2019-02-16 09:13:23 +00:00
"popups-refpreview-book",
"popups-refpreview-journal",
"popups-refpreview-news",
"popups-refpreview-web",
Remove reference preview "Jump to reference" link Now that the footnote label links to the references section, we don't need this additional link. Bug: T265482 Change-Id: Ib9b2939eb49e7b826c7699a5b7fa0e8255fa9da1
2020-10-29 10:59:05 +00:00
"popups-refpreview-collapsible-placeholder"
Switch to Schema:Popups revid 15597282 Bug: T131315 Change-Id: I2ed18e00afb3e355327b417e68e5930b46d49086
2016-05-16 20:32:11 +00:00
],
"dependencies": [
Add (i) info icon to collapsible replacement message This avoids pulling in the entirety of OOjs, with the disadvantage that we have to copy a little bit of CSS. I copied parts of this patch from I2a28666. There might be a better way to do this, with less code. E.g. is there a better way to construct these HTML elements? Bug: T220208 Change-Id: I024155f3ff0f57de1d68bbaf37bfb9e81e692bd0
2020-10-28 16:57:43 +00:00
"ext.popups.icons",
Add close button to settings dialog * Load the close icon (previously was not loaded) * Take opportunity to simplify selectors in setting panel and remove unnecessary id selectors * Correct size of header to be consistent with mediawiki ui icon Note: there's a slight movement in the heading text's position presumably due to inconsistiencies between the text inside the Done/Save buttons Bug: T154645 Change-Id: Icd978b45051c43f24ee1c9a8574a961b942082f1
2017-02-01 19:49:31 +00:00
"ext.popups.images",
Allow bucketing anons * Logged in users bypass bucketing. They keep working as before. * When Page Previews is configured as a beta feature, logged out users won't see the feature. * If an anonymous user has enabled/disabled the feature using the settings cog then they will see or not see the feature depending on the value of their setting. * The other anonymous users are bucketed. By default 90% of these users see the feature, the other 10% don't. These numbers can be controlled by the config variable `wgPopupsAnonsEnabledSamplingRate`. Bug: T157700 Change-Id: I5307587b10f4849c4e82d3b064ff759121c2de67
2017-02-27 19:31:34 +00:00
"mediawiki.experiments",
Replace deprecated mw.RegExp.escape() with mw.util.escapeRegExp() The signature mw.RegExp.escape() is deprecated since MediaWiki 1.34. By the way, this is the 4th or even 5th time in my short career this tiny, single line (!) helper function is moved around and I need to update all my code. This felt already ridiculous when it happened the 2nd time. Change-Id: I4d05a49120aff64ebc316d0af7736c62385d9307
2019-10-17 07:37:24 +00:00
"mediawiki.jqueryMsg",
Add BOOT action Changes: * Make grunt:qunit run all QUnit tests in those modules whose names being with "ext.popups". * Add ext.popups/index.js, which initialises the mw.popups namespace. * Add ext.popups/userSettings.js, which contains the code that deals with interacting with the User Agent's storage. * Add ext.popups/experiment.js, which contains the code that that decides whether or not the user is in the experiment condition. * Add tests for both units, converting existing tests where appropriate. * Remove the associated code from ext.popups.core/ext.popups.core.js. * Finally, dispatch the BOOT action against the store in ext.popups/boot.js. Change-Id: I697207677304bd49c7cfe1d37bb0a4af7810f387
2016-11-08 19:42:21 +00:00
"mediawiki.storage",
Add LINK_DWELL and LINK_ABANDON actions Supporting changes: * Add mw.popups.processLinks. * Extract the existing unit tests for mw.popups.selectPopupElements and mw.popups.getTitle. * Fix Grunt QUnit timeout. Change-Id: I325bcb15abc6e0b745d78b7308a346a034ab2988
2016-11-09 11:57:24 +00:00
"mediawiki.Title",
Remove ResourceLoaderRegisterModules hook handler We should endeavour to define Resource Loader modules in one place, extension.json. Adding them to the output, however... Changes: * Remove ResourceLoaderRegisterModules hook handler. * Move all dependencies, messages, templates, and styles into "empty" RL module definitions in extension.json so that they don't have to be looked up later. Change-Id: I7ec963e3296de8f411e90079ab13b97c6eba4916
2016-11-08 07:57:30 +00:00
"mediawiki.ui.button",
"mediawiki.ui.icon",
Make implicit dependency on mw.Uri explicit Change-Id: Ica6b16fc3f246e02d7f3b446953cd51bd99e3595
2016-12-12 07:01:25 +00:00
"mediawiki.Uri",
Replace deprecated mw.RegExp.escape() with mw.util.escapeRegExp() The signature mw.RegExp.escape() is deprecated since MediaWiki 1.34. By the way, this is the 4th or even 5th time in my short career this tiny, single line (!) helper function is moved around and I need to update all my code. This felt already ridiculous when it happened the 2nd time. Change-Id: I4d05a49120aff64ebc316d0af7736c62385d9307
2019-10-17 07:37:24 +00:00
"mediawiki.user",
"mediawiki.util"
Switch to Schema:Popups revid 15597282 Bug: T131315 Change-Id: I2ed18e00afb3e355327b417e68e5930b46d49086
2016-05-16 20:32:11 +00:00
]
Prepare Popups for adding of mobile specific Popups implementation For the work on T113243, the Popups extension should be structured in a more flexible way. This is achieved with this change. Following has changed: * The main/core logic of Popups now lives in ext.popups.core to be shareable between implementations * The desktop specific logic lives in ext.popups.desktop now, the frontend init code in ext.popups.desktopTarget and the desktop renderer in ext.popups.renderer.desktopRenderer This change doesn't change the functionality of Popups. Change-Id: I72121e0a1e4b2952f85dc1bc8cf59d06b8d22f47
2016-01-29 16:48:24 +00:00
}
},
"ResourceFileModulePaths": {
"localBasePath": "",
"remoteExtPath": "Popups"
},
Hygiene: Dependency Injection for Popups Changes: - removed ugly PopupsContext::getInstance - removed ugly PopupsContextTestWrapper helper - defined all services inside ServiceWirings - fixed unit tests to test classes directly or use MediawikiServices Change-Id: Ie27e28bb07aebe01014848c290369b1b1f098e9b
2017-07-21 17:06:08 +00:00
"ServiceWiringFiles": [
[hygiene] move ServiceWirings.php to ServiceWiring.php Remove pluralization from the service wiring filename for consistency with similar files in other Web repos. There are multiple services in this file but the point of distinction doesn't seem worthwhile. Change-Id: I6ff4f9caf66a6156f6aa6a8b808f51c356df3414
2020-01-14 15:41:15 +00:00
"includes/ServiceWiring.php"
Hygiene: Dependency Injection for Popups Changes: - removed ugly PopupsContext::getInstance - removed ugly PopupsContextTestWrapper helper - defined all services inside ServiceWirings - fixed unit tests to test classes directly or use MediawikiServices Change-Id: Ie27e28bb07aebe01014848c290369b1b1f098e9b
2017-07-21 17:06:08 +00:00
],
Update extension.json to use manifest_version 2 Bug: T234114 Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
2019-11-27 06:05:26 +00:00
"manifest_version": 2
Add extension.json, empty php entry point Bug: T87961 Change-Id: I52e93fd290b1e5d8438467896a159fc7230c5813
2015-07-02 10:00:21 +00:00
}
Reference in a new issue Copy permalink