mediawiki-extensions-Popups/tests/browser/features/support/step_definitions/common_steps.rb

TEST_PAGE_TITLE = 'Popups test page'

Given(/^I have enabled the beta feature$/) do
  visit(SpecialPreferencesPage).enable_page_previews
end

Given(/^I am on the test page$/) do
  api.create_page TEST_PAGE_TITLE, File.read('fixtures/test_page.wikitext')

  visit(ArticlePage, using_params: { article_name: TEST_PAGE_TITLE }) do |page|
    page.wait_until_rl_module_ready('ext.popups')
  end
end
Hygiene: Remove "I am on the ... page" step Merge the "Given the test page has been created" and "Given I am on the ... page" as they are only ever used together to mean "Given I am on the test page". Supporting changes: * samples/links.wikitext -> fixtures/test_page.wikitext as it's more obvious what the file is. Change-Id: Ide261a8e8c55133ab2a13a80c48e266252f61f5f 2016-12-13 14:25:37 +00:00			`TEST_PAGE_TITLE = 'Popups test page'`
Add browser test for hovering link Basic feature of browsing a page, hovering a link, and showing/hiding a hovercard. Depends-On: Ie94fa399512be041f12b2f7cada20d4206ddaf82 Bug: T133019 Change-Id: Idf39e7e2a3b343babd6d0538225b4ef9002e8ac1 2016-04-13 21:21:38 +00:00
Hygiene: Tidy up "core" acceptance tests Changes: * Rename the somewhat awkwardly named "popups_core" Cucumber feature and its accompanying step definitions to "previews". * Remove as many references to Popups and HoverCards as possible. * Use language consistent with the QUnit unit and integration tests and documentation, e.g. the user dwells on a link. * Remove settings-related step definitions from the previews step definitions. Change-Id: Ibc0d07e8394aeb640f9efaabfe10be5317bf4b8c 2016-12-13 14:13:22 +00:00			`Given(/^I have enabled the beta feature$/) do`
			`visit(SpecialPreferencesPage).enable_page_previews`
Add browser test for hovering link Basic feature of browsing a page, hovering a link, and showing/hiding a hovercard. Depends-On: Ie94fa399512be041f12b2f7cada20d4206ddaf82 Bug: T133019 Change-Id: Idf39e7e2a3b343babd6d0538225b4ef9002e8ac1 2016-04-13 21:21:38 +00:00			`end`
QA: Updates to browser tests to avoid flakiness * Wait until the form submits successfully, verifying it worked by testing for the notification toast. * Drop sleep statements where possible - instead use when_present Use one when asserting something doesn't show to avoid false positives * Allow more time for the hovercard to show (5s) - API requests might take longer than default time. * Assert popups JavaScript loads before continuing with test. This helped trap a bug in testing and will be useful for future. Bug: T133019 Depends-On: Icb1e6ddc8f95da5e4b4de2916d292694c11ba731 Change-Id: Iacd3beedf44cadffcf0285231b2df7e5b64294f6 2016-04-20 12:33:34 +00:00
Hygiene: Remove "I am on the ... page" step Merge the "Given the test page has been created" and "Given I am on the ... page" as they are only ever used together to mean "Given I am on the test page". Supporting changes: * samples/links.wikitext -> fixtures/test_page.wikitext as it's more obvious what the file is. Change-Id: Ide261a8e8c55133ab2a13a80c48e266252f61f5f 2016-12-13 14:25:37 +00:00			`Given(/^I am on the test page$/) do`
			`api.create_page TEST_PAGE_TITLE, File.read('fixtures/test_page.wikitext')`

Hygiene: Remove RL-related step High-level acceptance tests shouldn't expose low-level concepts such as the Resource Loader ("RL"). Merge the "And the RL module has loaded" step into the "Given I am on the test page" step as they are only ever used together. Changes: * Use the ArticlePage#wait_until_rl_module_ready helper method provided by mediawiki_selenium@1.7.3. * Update and include the Gemfile.lock. Change-Id: Ic81eae5dc0caa8ec51c91b21aef544f52d8c49e1 2016-12-13 14:38:57 +00:00			`visit(ArticlePage, using_params: { article_name: TEST_PAGE_TITLE }) do \|page\|`
			`page.wait_until_rl_module_ready('ext.popups')`
QA: Updates to browser tests to avoid flakiness * Wait until the form submits successfully, verifying it worked by testing for the notification toast. * Drop sleep statements where possible - instead use when_present Use one when asserting something doesn't show to avoid false positives * Allow more time for the hovercard to show (5s) - API requests might take longer than default time. * Assert popups JavaScript loads before continuing with test. This helped trap a bug in testing and will be useful for future. Bug: T133019 Depends-On: Icb1e6ddc8f95da5e4b4de2916d292694c11ba731 Change-Id: Iacd3beedf44cadffcf0285231b2df7e5b64294f6 2016-04-20 12:33:34 +00:00			`end`
			`end`