mediawiki-extensions-Popups/.eslintrc.json

{
	"extends": "wikimedia",
	"parserOptions": {
		"sourceType": "module",
		"ecmaVersion": "5"
	},
	"env": {
		"browser": true,
		"jquery": true,
		"commonjs": true,
		"qunit": true
	},
	"globals": {
		"mediaWiki": false,
		"OO": false,
		"moment": false,
		"Redux": false,
		"ReduxThunk": false
	},
	"rules": {
		"dot-notation": [ "error", { "allowKeywords": true } ],
		"no-use-before-define": 0
	}
}
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`{`
			`"extends": "wikimedia",`
Use EcmaScript modules instead of common.js modules Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941 2017-07-28 17:32:46 +00:00			`"parserOptions": {`
Explicitly set ecmaVersion for eslint Before, because of the use of sourceType: "module", ecmaVersion would be assumed to be ES2015, but we write ES5 here at the moment. This enables linting against ES2015 features like let and const. See https://gerrit.wikimedia.org/r/#/c/374789/ for failing POC. Change-Id: Id1d147866c37de3794213378a5e8a08af6f796a1 2017-08-30 11:47:49 +00:00			`"sourceType": "module",`
			`"ecmaVersion": "5"`
Use EcmaScript modules instead of common.js modules Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941 2017-07-28 17:32:46 +00:00			`},`
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`"env": {`
			`"browser": true,`
			`"jquery": true,`
Tooling: Begin to use webpack for JS code generation Generate changeListeners via webpack We now use a build folder to build the JavaScript for our ResourceLoader modules. This is the first change in a line of changes. A source map is provided for debug support. Bug: T156333 Change-Id: I771843d1ddb4b50adedc3fa53b30c2f1d8a76acb 2017-01-26 21:31:41 +00:00			`"commonjs": true,`
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`"qunit": true`
			`},`
			`"globals": {`
			`"mediaWiki": false,`
			`"OO": false,`
			`"moment": false,`
			`"Redux": false,`
			`"ReduxThunk": false`
			`},`
			`"rules": {`
			`"dot-notation": [ "error", { "allowKeywords": true } ],`
			`"no-use-before-define": 0`
			`}`
			`}`