mediawiki-extensions-Popups/.eslintrc.json

{
	"root": true,
	"extends": [
		"wikimedia/client",
		"wikimedia/jquery",
		"wikimedia/language/es6"
	],
	"parserOptions": {
		"sourceType": "module"
	},
	"env": {
		"browser": true,
		"jquery": true,
		"commonjs": true
	},
	"globals": {
		"mediaWiki": "readonly",
		"OO": "readonly"
	},
	"rules": {
		"no-use-before-define": "off"
	}
}
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`{`
Hygiene: limit ESLint inheritance The project ESLint configuration unintentionally inherited unwanted configuration from MediaWiki, which allows global jQuery usage. Cap the project's ESLint hierarchy at the project root. Change-Id: I5177d306feface7fcce0867c624bbcf9e74f19fc 2018-10-05 16:24:24 +00:00			`"root": true,`
build: Update eslint-config-wikimedia to 0.10.0 Also enable jquery ruleset. Change-Id: Ie1f43d0335ea2aad1e2dd5d86b775316105c3d90 2019-01-17 22:17:27 +00:00			`"extends": [`
			`"wikimedia/client",`
eslint: Use wikimedia/language/es6 and remove duplicate rules Change-Id: I3c3e8dc763a2f2a8bed50c7d0d06dfde37a64f54 2019-08-05 12:31:06 +00:00			`"wikimedia/jquery",`
			`"wikimedia/language/es6"`
build: Update eslint-config-wikimedia to 0.10.0 Also enable jquery ruleset. Change-Id: Ie1f43d0335ea2aad1e2dd5d86b775316105c3d90 2019-01-17 22:17:27 +00:00			`],`
Use EcmaScript modules instead of common.js modules Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941 2017-07-28 17:32:46 +00:00			`"parserOptions": {`
eslint: Use wikimedia/language/es6 and remove duplicate rules Change-Id: I3c3e8dc763a2f2a8bed50c7d0d06dfde37a64f54 2019-08-05 12:31:06 +00:00			`"sourceType": "module"`
Use EcmaScript modules instead of common.js modules Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941 2017-07-28 17:32:46 +00:00			`},`
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`"env": {`
			`"browser": true,`
			`"jquery": true,`
build: Update linters Bug: T202739 Change-Id: Ie3f68977598f46f7e12b216f8381b2e9dc6d83ad 2018-09-11 11:53:15 +00:00			`"commonjs": true`
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`},`
			`"globals": {`
Hygiene: improve ESLint globals readability - Drop unused moment, Redux, and ReduxThunk globals. - Instead of using a confusing and deprecated boolean, specify that globals are "readable" / "writable" https://eslint.org/docs/user-guide/configuring#specifying-globals Change-Id: I711a4ea7c51c9a560f20fc28bc99bd932c7e1e25 2019-02-21 14:59:56 +00:00			`"mediaWiki": "readonly",`
			`"OO": "readonly"`
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`},`
			`"rules": {`
eslint: Enforce template-curly-spacing Change-Id: I5640e86cba25f6100c7814c2ef8a845941f73497 2019-08-05 12:42:21 +00:00			`"no-use-before-define": "off"`
Remove jshint/jscs, add eslint and stylelint ...with the wikimedia presets. For automatically fixing most of the JS lint problems run grunt eslint:fix Some rules of stylelint were disabled given they cause problems with existing popups code (like no id selectors for example). Change-Id: I2153047c3ddbea50572dd329989088bb20787515 2016-12-16 11:11:54 +00:00			`}`
			`}`