mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Poem
synced 2024-11-15 19:09:37 +00:00
870611c0bb
* I think the dependency on a more recent PHP version was forgotten. Notice how the code already contained short array syntax. * Make the @license more visible in the class itself. * I'm intentionally only listing the original @author. Copying this author line was forgotten in Ieea24d5. * Remove not needed "return true" from the hook handler. This is the default anyway. * Use the …::class feature when possible. * Remove the unwanted &$parser reference. This is only here for legacy reasons, but does not make any sense any more (Why would a hook handler want to replace the *parser*?), and can be removed from callees (not from callers) with no consequence. * Add strict type hints to function headers for type safety. I checked the caller in Parser::extensionSubstitution() that will call Poem::renderPoem(), and it is impossible for the Parser to be null, and impossible for the frame to be false. Change-Id: I4b4203bf1cef0c057db5e6a7747d441d0b0e4b54 |
||
---|---|---|
.. | ||
Poem.php |