wikimedia/mediawiki-extensions-PdfHandler
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/PdfHandler synced 2024-11-24 00:07:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow using PoolCounter for large PDF local downloads

Browse source 
Change-Id: Ifee3a5764b32ef31e4ed9edb183272ebb89bd11b
This commit is contained in:
Aaron Schulz 2014-03-15 10:50:37 -07:00
parent 7e59dedf95
commit ce77a57144
1 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
PdfHandler_body.php
View file

@ -165,7 +165,24 @@ class PdfHandler extends ImageHandler {
return $this->doThumbError( $width, $height, 'thumbnail_dest_directory' );
}
$srcPath = $image->getLocalRefPath();
// Thumbnail extraction is very inefficient for large files.
// Provide a way to pool count limit the number of downloaders.
if ( $image->getSize() >= 1e7 ) { // 10MB
$work = new PoolCounterWorkViaCallback( 'downloadpdf', sha1( $image->getName() ),
array(
'doWork' => function() use ( $image ) {
return $image->getLocalRefPath();
}
)
);
$srcPath = $work->execute();
} else {
$srcPath = $image->getLocalRefPath();
}
if ( $srcPath === false ) { // could not download original
return $this->doThumbError( $width, $height, 'filemissing' );
}
$cmd = '(' . wfEscapeShellArg(
$wgPdfProcessor,