wikimedia/mediawiki-extensions-PdfHandler
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/PdfHandler synced 2024-11-27 17:50:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded check for return value of explode

Browse source 
explode returns an array with one item,
but the empty string is already checked before the explode

Change-Id: I441309978b25754bad04eeba69993913de4d48c3
This commit is contained in:
Umherirrender 2021-09-19 02:33:35 +02:00
parent b253dc04c4
commit 85fbb12dbe
1 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
includes/PdfImage.php
View file

@ -81,22 +81,20 @@ class PdfImage {
}
$size = explode( 'x', $pageSize, 2 );
if ( $size ) {
$width = intval( trim( $size[0] ) / 72 * $wgPdfHandlerDpi );
$height = explode( ' ', trim( $size[1] ), 2 );
$height = intval( trim( $height[0] ) / 72 * $wgPdfHandlerDpi );
if ( ( $pageRotation / 90 ) & 1 ) {
// Swap width and height for landscape pages
$temp = $width;
$width = $height;
$height = $temp;
}
return [
'width' => $width,
'height' => $height
];
$width = intval( trim( $size[0] ) / 72 * $wgPdfHandlerDpi );
$height = explode( ' ', trim( $size[1] ), 2 );
$height = intval( trim( $height[0] ) / 72 * $wgPdfHandlerDpi );
if ( ( $pageRotation / 90 ) & 1 ) {
// Swap width and height for landscape pages
$temp = $width;
$width = $height;
$height = $temp;
}
return [
'width' => $width,
'height' => $height
];
}
return false;