wikimedia/mediawiki-extensions-PdfHandler
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/PdfHandler synced 2024-11-15 03:44:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unused variables

Browse source 
Fix trailing whitespace

Add/Improve documentation

Explicit member variable declaration
This commit is contained in:
Sam Reed 2012-01-28 17:05:20 +00:00
parent fa676db7c8
commit 2794192eaa
Notes: Sam Reed 2012-01-28 17:05:20 +00:00 
https://mediawiki.org/wiki/Special:Code/MediaWiki/110218
2 changed files with 35 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
CreatePdfThumbnailsJob.class.php
View file

@ -87,7 +87,12 @@ class CreatePdfThumbnailsJob extends Job {
return true;
}
/**
* @param $upload
* @param $mime
* @param $error
* @return bool
*/
public static function insertJobs( $upload, $mime, &$error ) {
global $wgPdfCreateThumbnailsInJobQueue;
if ( !$wgPdfCreateThumbnailsInJobQueue ) {

35
PdfHandler.image.php
View file

@ -26,14 +26,23 @@
class PdfImage {
/**
* @param $filename
*/
function __construct( $filename ) {
$this->mFilename = $filename;
}
/**
* @return bool
*/
public function isValid() {
return true;
}
/**
* @return array|bool
*/
public function getImageSize() {
$data = $this->retrieveMetadata();
$size = self::getPageSize( $data, 1 );
@ -47,6 +56,11 @@ class PdfImage {
return false;
}
/**
* @param $data array
* @param $page
* @return array|bool
*/
public static function getPageSize( $data, $page ) {
global $wgPdfHandlerDpi;
@ -57,15 +71,15 @@ class PdfImage {
} else {
$o = false;
}
if( isset( $data['pages'][$page]['Page rot'] ) ) {
$r = $data['pages'][$page]['Page rot'];
} elseif( isset( $data['Page rot'] ) ) {
$r = $data['Page rot'];
} else {
$r = 0;
}
if ( $o ) {
if( isset( $data['pages'][$page]['Page rot'] ) ) {
$r = $data['pages'][$page]['Page rot'];
} elseif( isset( $data['Page rot'] ) ) {
$r = $data['Page rot'];
} else {
$r = 0;
}
$size = explode( 'x', $o, 2 );
if ( $size ) {
@ -89,6 +103,9 @@ class PdfImage {
return false;
}
/**
* @return array|bool|null
*/
public function retrieveMetaData() {
global $wgPdfInfo, $wgPdftoText;
@ -128,6 +145,10 @@ class PdfImage {
return $data;
}
/**
* @param $dump string
* @return array|bool
*/
protected function convertDumpToArray( $dump ) {
if ( strval( $dump ) == '' ) {
return false;