wikimedia/mediawiki-extensions-PdfHandler
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/PdfHandler synced 2024-09-23 10:23:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Upgrade to newer phan

Browse source 
Bug: T216935
Change-Id: I31b3dd55ffe1d6d5532d25081ac0b2c1ce467237
This commit is contained in:
Kunal Mehta 2019-03-16 22:17:42 -07:00
parent 616459923c
commit 16abfa4af8
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.phan/config.php Normal file
View file

@ -0,0 +1,3 @@
<?php
return require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';

2
composer.json
View file

@ -4,7 +4,7 @@
"jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/mediawiki-codesniffer": "24.0.0",
"mediawiki/minus-x": "0.3.1",
"mediawiki/mediawiki-phan-config": "0.3.0"
"mediawiki/mediawiki-phan-config": "0.5.0"
},
"scripts": {
"fix": [

3
includes/PdfHandler.php
View file

@ -82,7 +82,7 @@ class PdfHandler extends ImageHandler {
* @return bool|string
*/
public function makeParamString( $params ) {
$page = isset( $params['page'] ) ? $params['page'] : 1;
$page = $params['page'] ?? 1;
if ( !isset( $params['width'] ) ) {
return false;
}
@ -256,7 +256,6 @@ class PdfHandler extends ImageHandler {
/**
* @param File $image
* @return bool|array
* @suppress PhanUndeclaredProperty
*/
private function getMetaArray( $image ) {
if ( isset( $image->pdfMetaArray ) ) {

1
includes/PdfImage.php
View file

@ -189,6 +189,7 @@ class PdfImage {
foreach ( $lines as $line ) {
if ( $inMetadata ) {
// Handle XMP differently due to diffence in line break
// @phan-suppress-next-line PhanTypeInvalidDimOffset weird loop
$data['xmp'] .= "\n$line";
continue;
}

3
tests/phan/config.php
View file

@ -1,3 +0,0 @@
<?php
return require __DIR__ . '/../../vendor/mediawiki/mediawiki-phan-config/src/config.php';