Commit graph

75 commits

Author SHA1 Message Date
Max Semenik 1e8444fad1 Improve ExprParser test coverage
Had to change a bit how ExprError is used, to prevent having to turn unit
tests into ingergation tests, adding 5 seconds to run time.

Change-Id: Id4e158f3a4418d320b1c0bdac834ebbba03762af
2019-09-05 15:37:21 -07:00
Max Semenik 8d6e567e5a ParserFunctions class: tweak function declarations
* Force type hints
* Documentation
* Give links to documentation on mw.org to make high-level understanding of
  what each function does easier.

Change-Id: I7708343540b7980e57b68ce9b2d9816d2aee710f
2019-07-20 21:27:52 +00:00
jenkins-bot c8a1f28418 Merge "ParserFunctions class: make everything that doesn't need to be public private" 2019-07-20 21:19:01 +00:00
jenkins-bot dad921ea53 Merge "Remove function existence check" 2019-07-18 02:50:44 +00:00
Max Semenik cca4ec9af0 Remove function existence check
PPFrame::setTTL() is present in every supported MediaWiki version.

Change-Id: I7065723bfbd2170cd7c951d1f9b3c4a0318f9938
2019-07-18 02:38:17 +00:00
Max Semenik 3fd4ac43ac ParserFunctions class: make everything that doesn't need to be public private
Change-Id: I818315e5f0cd80700731d212ba11fbf341582ba1
2019-07-18 02:36:30 +00:00
Max Semenik 8b50403fe8 Get rid of *Obj() functions
They're a rudiment from the time when the extension had to be compatible
with both SFH_OBJECT_ARGS supporting and not versions of MediaWiki.
This is in the past, so unify them now by merging and or deleting the
old versions. The resulting functions don't end with "Obj" anymore.
One "common" function was left alone to be refactored at a later time,
however I've renamed it and made private.

Change-Id: Ice97e587bf7cc0469476c2e53268d2774ddfdd04
2019-07-18 02:35:53 +00:00
Max Semenik 439544224f Replace a single use function with a closure
Change-Id: Id6408bb203fc984f7baaaf3358cea79c281005bf
2019-04-04 17:22:04 -07:00
Max Semenik e721c193d9 Avoid using $wgContLang
Change-Id: If43a6aa5580397264b2ca9dff5ef7d0da859e3d6
2019-04-03 23:25:11 -07:00
Max Semenik e684068ed9 Convert variable used as a constant into constant proper
Change-Id: I1c7914cc9015c18f4c3877b4acc5b3be921ec4d5
2019-04-03 19:20:15 -07:00
Max Semenik 3c54e29505 Improve hook handler documentation
Change-Id: I2ae4271ec5e5a06d81a39ab9e528c6072c0f7731
2019-04-03 19:20:15 -07:00
Max Semenik 8e7a3ce5df Remove b/c code
New code requires 1.32, this extension requires 1.32.

Change-Id: I14b9d0074d057d6fb323d54502d0a4c64fc74879
2019-04-03 19:20:15 -07:00
Max Semenik f53debae7d Namespace this extension
Change-Id: I0c7719f17f74180a4c85f914888262f7e3b13111
2019-04-03 19:20:14 -07:00
Kunal Mehta ab601a2ca7 Upgrade to newer phan
Bug: T216933
Change-Id: If8a63da99343597b7f8c131f3656945eaf67d819
2019-03-16 22:39:09 -07:00
jenkins-bot 111c434c4e Merge "Enable string functions if running parser/PHPUnit tests" 2019-02-07 23:41:04 +00:00
Kunal Mehta 662734cc6f Enable string functions if running parser/PHPUnit tests
Instead of using a global variable specific to Wikimedia CI, always enable
string functions when running parser and PHPUnit tests.

Bug: T180192
Bug: T200650
Change-Id: I27764036e42800be437d69d96ce2b7bc1b1f7cb3
2019-02-07 01:59:13 +00:00
Alexia E. Smith cf1480cb96 Fix E_WARNING with {{#pos:}} if the offset is larger than the string
The mb_strpos() function throws E_WARNING if the offset is longer
than the length of the string.

Bug: T209600
Change-Id: Ib4296ba136eaf5c8461681e9d5f108118b2494f4
2018-11-15 12:50:32 -08:00
RazeSoldier d258457e01 Use "break" instead of "continue" inside a switch
"continue" statements in a switch are equivalent to "break". In PHP 7.3, will generate a warning.

Also change the indentation.

Bug: T206977
Change-Id: I8ad0ef6508e73bcca7dabfe2e88d661dd409bdfb
2018-10-15 15:45:06 +00:00
libraryupgrader 52c6ccb4a0 build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: Ia5c70d201c26b6894b0f0f028a8838fcb72ef784
2018-09-03 06:58:49 +00:00
Aryeh Gregor cc6f6cd01c Don't call SpecialPageFactory methods statically
This is deprecated in 1.32. Bump minimum requirement of MediaWiki to
1.32 since this is a tarball-bundled extension.

Depends-On: Id8a92d57743f790b7d8c377c033cef38d1bb24de
Change-Id: Ie18c7c97405124ccaa3922b4a25fa7b40496039f
2018-08-17 11:04:59 -07:00
Aryeh Gregor a06cf6f41c Don't use deprecated MagicWord static methods
Bug: T200247
Change-Id: I62b5c87af33ae77d3e305de8b39374d7f18199fa
2018-08-01 11:45:04 +03:00
Kunal Mehta 26b8e44180 Remove & from $mwDefault variable assignment
There's no need for it to be a reference in the first place.

Bug: T200772
Change-Id: I1252d481103f3f0ce1ce28b59dcba746f7611598
2018-07-31 09:58:10 -07:00
libraryupgrader 7d78876400 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: I3bb3a973a23be71fd35e0a0a91c533a63ecef4f3
2018-05-26 05:31:24 +00:00
Umherirrender 37805a4fa0 Fix indent of elseif
Removed comments which breaks the elseif in "blocks"
and make phpcs unhappy

Change-Id: I4f05728659b4b7eff9bc2bd1bf90a5ac79244f11
2018-02-25 00:02:10 +00:00
Kunal Mehta 9f94cebdaa Move classes to includes/
Change-Id: Iefaa21bf911fa7dcf11aedd38648bed945b905f9
2018-02-24 14:06:58 -08:00