mediawiki-extensions-PageIm.../tests/phpunit/PageImagesTest.php
Fomafix 4b86859269 Use a return type hint for PageImages::getPageImageInternal()
Now getPageImageInternal returns null instead of false.

Fix the comment in fetchPageImage(): false means no cache.

Also add a return type hint to PageImages::factory().

Change-Id: I696f24390be530e7eea21957e0e46752d1bb3030
2023-10-21 13:06:16 +00:00

145 lines
3.9 KiB
PHP

<?php
namespace PageImages\Tests;
use IContextSource;
use MediaWiki\Request\FauxRequest;
use MediaWiki\Title\Title;
use MediaWikiIntegrationTestCase;
use OutputPage;
use PageImages\PageImages;
use SkinTemplate;
/**
* @covers \PageImages\PageImages
*
* @group PageImages
* @group Database
*
* @license WTFPL
* @author Thiemo Kreuz
*/
class PageImagesTest extends MediaWikiIntegrationTestCase {
private function newPageImages() {
$services = $this->getServiceContainer();
return new PageImages(
$services->getDBLoadBalancerFactory(),
$services->getRepoGroup(),
$services->getUserOptionsLookup()
);
}
public function testPagePropertyNames() {
$this->assertSame( 'page_image', PageImages::PROP_NAME );
$this->assertSame( 'page_image_free', PageImages::PROP_NAME_FREE );
}
public function testConstructor() {
$pageImages = $this->newPageImages();
$this->assertInstanceOf( PageImages::class, $pageImages );
}
public function testGivenNonExistingPageGetPageImageReturnsFalse() {
$title = $this->newTitle();
$this->assertNull( $this->newPageImages()->getPageImageInternal( $title ) );
$this->assertFalse( PageImages::getPageImage( $title ) );
}
public function testGetPropName() {
$this->assertSame( 'page_image', PageImages::getPropName( false ) );
$this->assertSame( 'page_image_free', PageImages::getPropName( true ) );
}
public function testGetPropNames() {
$this->assertSame(
[ PageImages::PROP_NAME_FREE, PageImages::PROP_NAME ],
PageImages::getPropNames( PageImages::LICENSE_ANY )
);
$this->assertSame(
PageImages::PROP_NAME_FREE,
PageImages::getPropNames( PageImages::LICENSE_FREE )
);
}
public function testGivenDeactivedOpenGraphOnBeforePageDisplayDoesNotAddMeta() {
$outputPage = $this->mockOutputPage( [
'PageImagesOpenGraph' => false,
] );
$outputPage->expects( $this->never() )
->method( 'addMeta' );
$skinTemplate = new SkinTemplate();
$this->newPageImages()->onBeforePageDisplay( $outputPage, $skinTemplate );
}
public function testGivenNonExistingPageOnBeforePageDisplayDoesNotAddMeta() {
$outputPage = $this->mockOutputPage( [
'PageImagesOpenGraph' => true,
'PageImagesOpenGraphFallbackImage' => false
] );
$outputPage->expects( $this->never() )
->method( 'addMeta' );
$skinTemplate = new SkinTemplate();
$this->newPageImages()->onBeforePageDisplay( $outputPage, $skinTemplate );
}
public static function provideFallbacks() {
return [
[ 'http://wiki.test/example.png', '/example.png' ],
[ 'http://wiki.test/img/default.png', '/img/default.png' ],
[ 'https://example.org/example.png', 'https://example.org/example.png' ],
];
}
/**
* @dataProvider provideFallbacks
*/
public function testGivenFallbackImageOnBeforePageDisplayAddMeta( $expected, $fallback ) {
$this->setMwGlobals( [ 'wgCanonicalServer' => 'http://wiki.test' ] );
$outputPage = $this->mockOutputPage( [
'PageImagesOpenGraph' => true,
'PageImagesOpenGraphFallbackImage' => $fallback
] );
$outputPage->expects( $this->once() )
->method( 'addMeta' )
->with( $this->equalTo( 'og:image' ), $this->equalTo( $expected ) );
$skinTemplate = new SkinTemplate();
$this->newPageImages()->onBeforePageDisplay( $outputPage, $skinTemplate );
}
/**
* @param array $config
* @return OutputPage
*/
private function mockOutputPage( $config ) {
$context = $this->createMock( IContextSource::class );
$context->method( 'getTitle' )
->willReturn( $this->newTitle() );
$fauxRequest = new FauxRequest();
$config = new \HashConfig( $config );
$context->method( 'getRequest' )
->willReturn( $fauxRequest );
$context->method( 'getConfig' )
->willReturn( $config );
$outputPage = $this->getMockBuilder( OutputPage::class )
->onlyMethods( [ 'addMeta' ] )
->setConstructorArgs( [ $context ] )
->getMock();
return $outputPage;
}
/**
* @return Title
*/
private function newTitle() {
$title = Title::newFromText( 'New' );
$title->resetArticleID( 0 );
return $title;
}
}