Notably:
* Utilize the new ??= operator.
* No need to count when nobody cares about the number.
* More robust ratio calculation.
* More straightforward check for the "notpageimage" class name. We
don't need an array of all the classes when all we care about is a
single, specific class.
* Fix misspelled "no(t)pageimage".
Change-Id: Ibad1d395a5438bc58e026022d08c38fe54c48653
… as well as the properties that are initialized via the constructor.
Also update some PHPDoc comments.
Change-Id: I2f1dc5345b4a9d00e01d701ad04d42b28aa2f96a
Changes to the use statements done automatically via script
Addition of missing use statement done manually
Change-Id: Ie00aedfe607665e8a38ee4ce2475f25b82a1d8cf
That is causing T350726 and we already set the field in one line above
Follows-Up: I63ac37c2b73073e8e323f6627785955196cd148c
Bug: T350726
Change-Id: I9f28e326aefa206fe8f4d3f6a1038740fed9b0d4
There is only one caller,
this also benefits from the type hints on that caller and
some always-false condition could be removed
Change-Id: Id06b590225b3cf3f0baf331f0aaaad9ef522532a
Including regression test for T299798.
Bug: T299798
Depends-On: Idc4ac4eb4e20d8e3e2fdbd093ff75f26d3af0d57
Change-Id: I89fa346651e756d1981a950a8b778020359b86a2
They are documented as being HTML, so look for candidate comments and
strip them, same as we do for the main HTML.
Bug: T298930
Change-Id: I7caf96b8d15f887e0be4c9a24acfd981b3e7a776
I added ParserModifyImageHTML to core to make it easier for PageImages
to identify images in the lead section.
This also allows PageImages to stop writing to LinksUpdate properties.
It is one of only two extensions that do that.
Depends-On: I24528381e8d24ca8d138bceadb9397c83fd31356
Bug: T176520
Bug: T296895
Change-Id: I472f4a023969bfde6298eb56112c16d2ae842199
As we switch ParserCache to JSON, we can no longer serialized
class instances in extension data. PageImages was writing the
full set of properies it received from Parser into it's extension
data, some of which are sometimes class instances. Instead, only
write the nessessary subset of data into extension-data.
This change is completely forward and backward compatible.
Since before this change we were already writing the same array,
but with many additional unused properties.
Bug: T266251
Change-Id: Ieb4a139465159611e6b3a99c4b68c3c174b1944f
