Commit graph

687 commits

Author SHA1 Message Date
Umherirrender 570e1a8599 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Depends-On: I42d38a8e653d27a4d430ab78bba8b4f3988d7a27
Change-Id: I43ec99bf88b3eebc2d9c31007a559de3cb9e0d2d
2019-11-04 19:18:18 +01:00
jenkins-bot 9060029d88 Merge "Optimize ApiQueryPageImages::getTitles" 2019-11-01 02:17:37 +00:00
Umherirrender 0de5777cf7 Optimize ApiQueryPageImages::getTitles
Avoid array_map/array_flip + foreach when doing the simple thing also in
the foreach

Swap Title::newFromText to Title::makeTitle to avoid reparsing the
string

Bug: T237068
Change-Id: I745cb9bd817a4b2274c6f778c38c58846ef318c1
2019-10-31 23:08:13 +00:00
Umherirrender 5c0a57c9f8 Do not query pageimages for special pages and not-existing titles
Save on query on each page view of special page

Change-Id: Id6e79ba891ed917b40fa33f63e0d8f318d1ca269
2019-10-31 20:43:23 +01:00
Kosta Harlan 47660475b9 Tests: Stub getRequest/getConfig for OutputPage mock
Needed due to I4bf53dabb6e6c5446cea99a64db68b300cef2fd4

Bug: T236723
Change-Id: I8505d2dad69aefed5f8ed1f599b3ca1b7e79acf5
2019-10-29 12:23:57 +01:00
Translation updater bot 22d752b007 Localisation updates from https://translatewiki.net.
Change-Id: Ie7a06e459537bd1c51f658ec63511c5739f461c9
2019-10-28 16:35:41 +01:00
James D. Forrester a9518ea914 build: Upgrade mediawiki-codesniffer to v28.0.0
Change-Id: Ic742e7cde506b7d0c1865453cc8895faefe10e90
2019-10-11 11:05:53 -07:00
Max Semenik 0665baacc3 Fix PHPUnit 4 rudiments
Change-Id: Idcba8dce56f7a5deea7f8dd5a126c7bdfa499064
2019-10-04 19:16:34 -07:00
Translation updater bot 3e3ccd8efa Localisation updates from https://translatewiki.net.
Change-Id: I1ee9017291cea901da2af26ff52be7ae7cdc8c20
2019-09-23 09:26:31 +02:00
Translation updater bot ff41968561 Localisation updates from https://translatewiki.net.
Change-Id: I71bb2d78b7ecef7aba286e32774d69b768636099
2019-09-16 09:56:44 +02:00
Translation updater bot 26e5312d77 Localisation updates from https://translatewiki.net.
Change-Id: I70f67b2d014dc8ad08afbcdcd193da86bc3ffd47
2019-08-30 10:04:24 +02:00
Translation updater bot f3440a1951 Localisation updates from https://translatewiki.net.
Change-Id: Ia8099c90d8e62c6d31c7f7b3a765ecb94814689a
2019-08-27 11:05:01 +02:00
Alex Monk 378c5ab4cf Split apihelp messages to a separate file
Bug: T189982
Change-Id: Ibcd42f3d69843e22783507d790118d4ad0d159ad
2019-08-25 02:35:02 +01:00
libraryupgrader 8089aa1b5e build: Updating eslint-utils to 1.4.2
* https://npmjs.com/advisories/1118

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: Ia670947ef5aac549c2b8c239815517ce56b379b3
2019-08-22 21:29:28 +00:00
Simon Legner e1b6ba7da4 PageImages on File namespace should be the file itself
The file page for an image should include the `og:image` meta tag. Thus,
a thumbnail is shown for the image when posting a link via social media.

Relates to Ide250d489a1ceedd7e896a3b44471752f0971fb1.

Change-Id: I81435289a4a6c7749462ba447aa626120a9c821c
2019-08-15 15:11:51 +02:00
Tim Starling 4d11163e5e Use READ_LATEST during LinksUpdate
The hook is called during page move. If you try to fetch the current
page content from the replica, it won't be there with the specified
title, causing an exception.

Bug: T221763
Change-Id: Ib91bf399f251fc715d8f27a4f8f7f4c9db9d30c8
2019-07-25 14:11:05 +10:00
libraryupgrader 7d93ee1fd9 build: Updating mediawiki/mediawiki-codesniffer to 26.0.0
Additional changes:
* Committed package-lock.json (T179229) too.

Change-Id: I11020439a359e50398856e2efe965fe8e788d589
2019-07-14 14:41:28 +00:00
James D. Forrester 2187e20bbe build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Change-Id: Ia55c9d5620a313f598881b50cb516c348dbe69a9
2019-07-09 14:13:10 -07:00
libraryupgrader 02154da1a8 build: Updating mediawiki/mediawiki-phan-config to 0.6.1
Change-Id: Ie5704bbe8d3202d716bafb58dcbe61fa9e0cf5c8
2019-06-10 09:40:16 +00:00
Translation updater bot ceaa875d3f Localisation updates from https://translatewiki.net.
Change-Id: I95373c3e02f1484b2d0dea5d363c7ca16a1b8677
2019-06-02 22:30:30 +02:00
Translation updater bot 7287544bd2 Localisation updates from https://translatewiki.net.
Change-Id: Ic24ff899ede475c5ee666596882fc81d780fb715
2019-05-30 22:53:53 +02:00
James D. Forrester 8be55d3f8e build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
Change-Id: I7ae166bf3e55b5ce6f26bfeea38d87a6c198ec64
2019-05-19 12:22:13 +00:00
James D. Forrester 91a0d3b6e9 build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Change-Id: I142a8d136b65d26ac148dbe825e542af9c796f5f
2019-05-07 10:04:08 -07:00
James D. Forrester 350af7c5c0 build: Update eslint-config-wikimedia from 0.5.0 to 0.11.0
Change-Id: Ie37436a726e1d3b5549b042e12014dbcf1b850eb
2019-04-12 12:42:22 -07:00
Derick Alangi a63145e559 maintenance: Use addDescription() instead of mDescription property
Change-Id: I635ee7d005f4f88ffc0fb3dc5a7f98acad419985
2019-04-06 16:10:26 +01:00
libraryupgrader 75000f5154 build: Updating mediawiki/mediawiki-phan-config to 0.5.0
Change-Id: I7d94649c26fda91cf8072c9530ca8e59f42f8b9a
2019-03-10 22:28:35 -07:00
jenkins-bot 7009da69fa Merge "Add phan" 2019-03-08 20:21:48 +00:00
Umherirrender 5682f9c0e2 Use ::class for class name resolution
Available since php5.5

Change-Id: Iaaffa6b0f3c1314c575b5f46f729c8a2b2630107
2019-03-02 17:50:46 +01:00
Umherirrender 6e81389a00 Add phan
Change-Id: Ib50452c57c9ca2256d22a9952d932bb9b577e3b1
2019-02-28 21:33:10 +01:00
Umherirrender 272b98a34c Pass string as field to IDatabase::selectField
It is documented as string, because it can only select one field,
not a list of fields

Change-Id: Id3e51bdc12a2abea16e4963ea95caf7f9213f853
2019-02-28 21:21:11 +01:00
libraryupgrader 50511d6fa8 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I4ca4095d2c4c3bf18dfae0bb92f993ecefaeee0f
2019-02-07 02:23:14 +00:00
Translation updater bot 4139477986 Localisation updates from https://translatewiki.net.
Change-Id: Id8a9b0b3dd4aa1431bc979c8c2754b80df60adcf
2019-01-28 22:27:11 +01:00
Thiemo Kreuz 71b5c4db22 Relax score calculation in LinksUpdateHookHandler to use floats
This allows to use floats in the $wgPageImagesScores configuration.
Before, decimal places have just been cut off with no warning. I find
this pretty unexpected. When I see the terminology "score" being used,
I always think of float values. I checked all the code that consumes
these scores (it is all internal to LinksUpdateHookHandler), and it's
all fine with floats. I don't see a reason to forcefully cut decimal
places off.

Bug: T212013
Change-Id: I0f1f0ea0865f07b3e58a2fc142dcd838eb687c97
2019-01-10 09:31:20 +01:00
Thiemo Kreuz 0fd9a2b5f4 Fix score calculation in LinksUpdateHookHandler failing on unordered input
This patch is motivated by Iad694e0.

* I rearranged the code a little bit to avoid a duplicate line of code.
* I added a ksort() and a comment explaining it.
* Additional tests demonstrate why the ksort() is needed.
* I had to refactor the tests a little bit to allow for more test cases
  that have been missing before.

Bug: T212013
Change-Id: Ia96dc8c6cf57ddcea410a7300756d0013052ac79
2019-01-10 09:26:54 +01:00
jenkins-bot 835af0936b Merge "Don't use non-images as candidates, e.g. audio files from a <gallery>" 2019-01-09 20:09:33 +00:00
Thiemo Kreuz ba066df1e2 Don't use non-images as candidates, e.g. audio files from a <gallery>
Bug: T212013
Change-Id: Ibed6effb7b46d420264730f4ec2b11c34c0159f4
2019-01-09 13:12:38 +01:00
Thiemo Kreuz baabc300ba Remove bogus @doc… elements from default $wgPageImagesScores setting
Such @doc… keys are not allowed at this level. They make it to the code
and cause confusion there. I added a test case for an edge case where this
really causes wrong results.

Bug: T212013
Change-Id: Ib391e5639ef5a34f9ee44f8c19b99e1dd19207bc
2019-01-09 12:41:21 +01:00
Kunal Mehta b058df99b8 build: Set "root": true, in .eslintrc.json
This ensures that each repository's "npm test" command is fully
independent of wherever it might be in the filesystem.

Bug: T206485
Change-Id: I81139c50ce9cde87ecf4b52ad688719735d1f154
2018-12-17 18:57:17 -08:00
Translation updater bot d72b10c9fd Localisation updates from https://translatewiki.net.
Change-Id: Icea18eb246bae52183a528535c812dd1ae87ee5d
2018-12-07 22:21:44 +01:00
libraryupgrader 1d5e35277f build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I9f0706406568dc51eb8af8db2ed80feefdbe294d
2018-11-16 06:37:25 +00:00
Translation updater bot 989be21df0 Localisation updates from https://translatewiki.net.
Change-Id: I3ed18b46cb117dc779aef6536b65c9c043d0e0af
2018-11-10 22:28:23 +01:00
Translation updater bot 652070938e Localisation updates from https://translatewiki.net.
Change-Id: I0b010a12dec291b252c15c79018dc4bd4dc0436f
2018-11-04 22:42:28 +01:00
Translation updater bot 47aa8bf497 Localisation updates from https://translatewiki.net.
Change-Id: Iaaa9091e0a1aeb52b40b4a33766aedf69f498848
2018-11-03 11:03:15 +01:00
libraryupgrader 8ba6afb479 build: Updating npm dependencies for security issues
* Updated grunt to 1.0.3, addressing:
  * https://npmjs.com/advisories/577
  * CVE-2018-3721

Change-Id: I8534f5e4820b74977399a4b76632d20587c0a0a3
2018-10-11 10:05:09 +00:00
Peter Boehm cd2115f80d Reenable Indexing for Images
PageImages returned no images, found the solution here:
https://www.mediawiki.org/w/index.php?title=Topic:Txp3e225prn7u8mf&topic_showPostId=uf6ic04q8nneq
- thanks to the anonymous helper

Bug: T203965
Change-Id: I6a024d27edf9060f7bf3ffb0d51761b0a86f6696
2018-09-26 23:36:40 +00:00
Fomafix 16b5cfd18e Start showing warning for deprecated PHP entry point
Change-Id: I657672b9eb49a4313bbde5dd8aadfff015182a50
2018-09-11 06:47:43 +02:00
libraryupgrader 672a9fd309 build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I425f35b7ac9ccfdb20080a8492ad0bed78097607
2018-09-08 04:27:54 +00:00
libraryupgrader 1d629c73d8 build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: If9f0d1d185f177228981319650addf2b0f11a919
2018-09-03 06:48:54 +00:00
libraryupgrader d6d4d73d7c build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
Change-Id: I43ba5bf117eb13b1ebca5093983f726619d85a42
2018-09-01 12:32:04 +00:00
jenkins-bot e716b5c13f Merge "Remove backward usage of ApiBase::dieUsage" 2018-08-20 01:03:58 +00:00