Changes to the use statements done automatically via script
Addition of missing use statement done manually
Change-Id: I780e57da1ea02eb333cf61abd999dc737acf20d1
This reverts commit af76b17c7e.
No longer needed now that we've added an option for this.
The disabled test has drifted away from the reality in the meantime,
so update it.
Change-Id: Ifa906ad876eec9f09b151d21acf1de35168e1e03
Changes to the use statements done automatically via script
Addition of missing use statement done manually
Change-Id: Ie00aedfe607665e8a38ee4ce2475f25b82a1d8cf
Creation of dynamic property
PageImages\Tests\ApiQueryPageImagesProxyMock::$pageSet is deprecated in
php8.2
Change-Id: I9ce28b6126638ff3b7bdca6cbc04080448aabc0c
Now getPageImageInternal returns null instead of false.
Fix the comment in fetchPageImage(): false means no cache.
Also add a return type hint to PageImages::factory().
Change-Id: I696f24390be530e7eea21957e0e46752d1bb3030
The public static function PageImages::getPageImage must stay unchanged
because this function is called by other extensions.
Change-Id: I73f7253581ebc894ef6dcd41bd4713f7d9f53421
In I845694d4f2109a8b9125410e8533ca69bbea50fa we changed the format of
parser tests using the 'property' option. This updates the parser
tests in PageImages to the new format used for metadata in parser tests
(in this case, adding `!! metadata` sections).
Depends-On: I845694d4f2109a8b9125410e8533ca69bbea50fa
Change-Id: Ia7060c9bfcdebe9783ea48d429442bcdbaac459e
PageImages::getPropNames can return either array or string,
and PageProps::getProperties accepts both.
But the latter's return value will be different depending
on the type of input: with an array as input, the returned
array's values will be an associative array where the index
is the propname; with a string, it's just the propvalue.
This difference matters because the code below assumes an
array with propname keys.
Bug: T323152
Change-Id: I422951ec0cd5c651b32c65e88a557d49f2f22712
Size is not a useful (and thus far, unused) value that
is expensive to compute & we want to get rid of.
Let's not expect any particular value (or it even
existing) because that may not remain true for much longer.
Bug: T323125
Change-Id: I20d5c4358e225be7759ed38afb2267d6f811fa34
The default thumbnail size (SearchResultThumbnailProvider::THUMBNAIL_SIZE),
the code to build a SearchResultThumbnail object from a File object
(SearchResultThumbnailProvider::buildSearchResultThumbnailFromFile),
and the code that provides thumbnails from NS_FILE pages (now already
provided in the hook's $results param) have essentially been adopted
in core and no longer need to be handled here.
Also updated test to reflect that NS_FILE results will no longer be
provided by this extension (since core already provides them)
Depends-On: I2a679b51758020d3e822da01a1bde1ae632b0b0a
Change-Id: I2eafc8556022432929973755d8cd76010ea24f39
Bug: T306883
