Commit graph

680 commits

Author SHA1 Message Date
Umherirrender 00ec4349d4 Use PageReference on ParserFileProcessingHookHandlers::processThisTitle
Avoid deprecated Parser::getTitle
Parser::getPage can return null, so checking for that as well

Change-Id: I90f04d514934621ee7fdc0ebe519673d7ba1d82f
2023-01-03 23:32:11 +01:00
Translation updater bot a387f18f9e Localisation updates from https://translatewiki.net.
Change-Id: I86d0ba378495a9d5d143eb613fd7e12d801eefb0
2023-01-03 08:21:07 +01:00
Translation updater bot d3c6d39d63 Localisation updates from https://translatewiki.net.
Change-Id: I902e53be35da9b3a8bff004d436f08e9d6dc931d
2023-01-02 08:44:03 +01:00
Translation updater bot fca29f3ebe Localisation updates from https://translatewiki.net.
Change-Id: I53c2fd3baff515277062083bde1f9f111485e107
2022-12-21 09:17:07 +01:00
jenkins-bot 3368093c4d Merge "Temporarily disable failing heading parser test case" 2022-12-15 19:07:11 +00:00
jenkins-bot 3dfd1f636f Merge "Replace deprecated Http::get" 2022-12-14 20:50:00 +00:00
Amir Sarabadani 491eeedc28 Fix brittle test
It really shouldn't test everything. Blocking I3dc682d2dce

Change-Id: I12643edfad16acb072757ec29ae3ba08fc11d65b
2022-12-12 08:28:37 +01:00
Umherirrender de7bf883d2 Replace deprecated Http::get
Bug: T305813
Change-Id: Icd3e64fc13e291761b287c4059315df39cd88d1e
2022-12-11 15:54:20 +01:00
Translation updater bot 7a83acf385 Localisation updates from https://translatewiki.net.
Change-Id: I320a09902d406266dd09ed712d67cd2f8ddc557d
2022-11-29 08:59:04 +01:00
jenkins-bot 7245136ded Merge "Adopt getWithSet idiom for getPageImage in-process cache" 2022-11-29 06:07:56 +00:00
Bartosz Dziewoński af76b17c7e Temporarily disable failing heading parser test case
The heading markup is changing in T13555.

Change-Id: Ib92193b6b43ca4b8f8f36475ed0a7793866b50c0
2022-11-24 15:37:24 +01:00
Timo Tijhof d50f90ba78 Adopt getWithSet idiom for getPageImage in-process cache
Follows-up I9b08b4de2648bf.

Bug: T322528
Change-Id: I8e974b66e3a0cdee2c6ef5eeb38719cff60dc93c
2022-11-23 01:38:14 +00:00
Amir Sarabadani 8fe805f25e Make sure pithumbsize set width and not height
This unifies image thumbnail sizes so instead of being random image
sizes, it would be only one thumbsize.

Bug: T323223
Change-Id: Ib7a7a5bce3ce10e60819e6ca056fe30f11e969a5
2022-11-21 19:52:44 +01:00
jenkins-bot 9902ffb55c Merge "Remove size check" 2022-11-17 23:16:29 +00:00
jenkins-bot e588a4eeff Merge "Add in-process cache for result of getPageImage() DB query" 2022-11-17 16:21:41 +00:00
libraryupgrader d99802768c build: Updating mediawiki/mediawiki-codesniffer to 40.0.1
Change-Id: Idfb908cfb13308c1c3a600705b0ed60d9215008f
2022-11-17 07:15:05 +00:00
Matthias Mullie c75b00d14d Ensure array is passed to getProperties
PageImages::getPropNames can return either array or string,
and PageProps::getProperties accepts both.
But the latter's return value will be different depending
on the type of input: with an array as input, the returned
array's values will be an associative array where the index
is the propname; with a string, it's just the propvalue.

This difference matters because the code below assumes an
array with propname keys.

Bug: T323152
Change-Id: I422951ec0cd5c651b32c65e88a557d49f2f22712
2022-11-16 09:33:37 +01:00
Amir Sarabadani bb555ae71d Add in-process cache for result of getPageImage() DB query
There has been cases of different extensions calling this function
for the same page title within the same web request, leading to
duplicate queries and roundtrips. This avoids those.

Maybe in future we could have APCu cache for it.

Bug: T322528
Change-Id: I9b08b4de2648bf794bfdbfe57de9db433cfd79ee
2022-11-15 20:18:43 +01:00
Matthias Mullie 9391a1f18c Remove size check
Size is not a useful (and thus far, unused) value that
is expensive to compute & we want to get rid of.

Let's not expect any particular value (or it even
existing) because that may not remain true for much longer.

Bug: T323125
Change-Id: I20d5c4358e225be7759ed38afb2267d6f811fa34
2022-11-15 18:39:22 +01:00
jenkins-bot d7d9c0275f Merge "Only provide free images for search purposes" 2022-11-10 17:48:20 +00:00
Matthias Mullie 5dcd4d13e2 Only provide free images for search purposes
Bug: T320661
Change-Id: Ic26e7e815365f6aa81b6fbfb464d0f41b80e4ae8
2022-11-10 13:26:56 +01:00
Tim Starling 33ee32f448 Use preg_replace_callback() flag introduced in PHP 7.4
Should improve performance by avoiding the need to run the regex
twice.

Change-Id: Ic737c1c2189c1bfc046cdcb099cdcbc0edde0a97
2022-11-10 13:58:31 +11:00
libraryupgrader fd123da0a3 build: Updating minimatch to 3.0.8
* https://github.com/advisories/GHSA-f8q6-p94x-37v3

Change-Id: Ic00d887ef92f96a6e3bb5d680328f39a61d4deec
2022-10-21 10:46:26 +00:00
libraryupgrader f807a8bbf0 build: Updating mediawiki/mediawiki-phan-config to 0.12.0
Change-Id: Ibd1a0df2c1786ccd45554ddf150602af681c6247
2022-10-09 08:12:35 +00:00
libraryupgrader dc2efbb7f4 build: Updating grunt-banana-checker to 0.10.0
Change-Id: Id8357b68ffcf2c2cb46c938bc689da64778803f4
2022-10-07 02:59:39 +00:00
jenkins-bot 74ec9b8a18 Merge "Drop some code that now lives in core" 2022-10-03 11:30:52 +00:00
Translation updater bot 105d05ccf8 Localisation updates from https://translatewiki.net.
Change-Id: I37ceba59fa2150345fc6b0eb3cf64599d323800f
2022-09-30 08:54:35 +02:00
Matthias Mullie 6a6af45ab3 Drop some code that now lives in core
The default thumbnail size (SearchResultThumbnailProvider::THUMBNAIL_SIZE),
the code to build a SearchResultThumbnail object from a File object
(SearchResultThumbnailProvider::buildSearchResultThumbnailFromFile),
and the code that provides thumbnails from NS_FILE pages (now already
provided in the hook's $results param) have essentially been adopted
in core and no longer need to be handled here.

Also updated test to reflect that NS_FILE results will no longer be
provided by this extension (since core already provides them)

Depends-On: I2a679b51758020d3e822da01a1bde1ae632b0b0a
Change-Id: I2eafc8556022432929973755d8cd76010ea24f39
Bug: T306883
2022-09-27 10:46:14 +02:00
Translation updater bot 2df53d17db Localisation updates from https://translatewiki.net.
Change-Id: If0165504c77b31bf09be7b78477938a41f21f856
2022-09-26 08:15:57 +02:00
jenkins-bot 499ffd7934 Merge "Inject services into hook handler" 2022-09-09 16:43:49 +00:00
jenkins-bot bfdd3d028d Merge "Inline ParserFileProcessingHookHandlers::processFile" 2022-09-09 16:39:10 +00:00
jenkins-bot 630decba6a Merge "Update hook FQCN" 2022-09-05 19:53:20 +00:00
jenkins-bot d6a007ebd1 Merge "Allow thumbnails to be provided in a different size" 2022-09-05 19:53:10 +00:00
Translation updater bot e6a81a9072 Localisation updates from https://translatewiki.net.
Change-Id: If90d51c7d2e6cb54536b9f4e330cb8a2912f3921
2022-09-05 10:11:36 +02:00
Umherirrender c24081b609 Inject services into hook handler
Remove the self creating of the handler and remove one deep from the
caller stack

Change-Id: Ie12ff77781f5ec6c74d9289a9812ec4f40c07d95
2022-09-03 00:15:57 +02:00
Umherirrender 3a8221b364 Inline ParserFileProcessingHookHandlers::processFile
There is only one caller,
this also benefits from the type hints on that caller and
some always-false condition could be removed

Change-Id: Id06b590225b3cf3f0baf331f0aaaad9ef522532a
2022-09-02 23:52:59 +02:00
Matthias Mullie 2d95a2be65 Update hook FQCN
This hook has moved.

Depends-On: Ic9110345b4db69d268685b80ec8e4e33da95a050
Change-Id: I71bddf3978a5b6124bdd114fcb74fbabe607a64a
Bug: T306883
2022-09-01 14:39:37 +02:00
Matthias Mullie a8c8030299 Allow thumbnails to be provided in a different size
This will also be added to the interface, but first this
implementation needs to be updated to already accept the
optional new param. Doing it in different order would
cause incompatible declaration warnings.

Bug: T306883
Change-Id: Ia30afcc43a0ecec772cd0a82dd9661e61f31a651
2022-09-01 12:29:41 +00:00
Sébastien Beyou 3ab47c1061 Add a parameter to deactivate OpenGraph meta tags
This can conflict with other extensions like SemanticMetaTags or
OpenGraphMeta.

Bug: T217307
Change-Id: Idfb006583edda8545b95609f047b2f301a9caa33
2022-08-20 09:43:57 +02:00
Kosta Harlan 8adbbf5b8c
SearchResultProvideThumbnailHookHandler: Simplify code
Bug: T312746
Change-Id: Iaf3f7f56129f488088f08f65657fa33f6a6e5851
2022-07-18 10:13:42 +02:00
Kosta Harlan c7054f15c6
SearchResultProvideThumbnailHookHandler: Construct from injected services
Bug: T312746
Change-Id: I0ed66f69a4ae9350b2230b5e207a76bbcf5bb689
2022-07-11 15:12:17 +02:00
jenkins-bot debf0dab8f Merge "PageImageCandidate: Cast handlerWidth to int" 2022-07-08 18:21:37 +00:00
jenkins-bot e9c1b9fd32 Merge "Convert Hooks to HookHandlers" 2022-07-08 18:20:13 +00:00
Umherirrender 5ab11af559 Replace comment about deprecated wfFindFile
Bug: T249020
Change-Id: I202bf65e132389fb3d034524b546c4b03adc01db
2022-07-07 22:04:36 +02:00
Reedy 7e8167f3be PageImageCandidate: Cast handlerWidth to int
Bug: T312522
Change-Id: Iaf93f81acb28daa177c73de298bc9da47f2893d5
2022-07-07 11:23:24 +01:00
Reedy 84861174bc Convert Hooks to HookHandlers
Bug: T271021
Change-Id: I6022e515cf65ec089c59fb56f6fde371dc9f0e12
2022-07-07 10:21:43 +00:00
Reedy 5b0cc4163c PageImageCandidate: Apply array return type to jsonSerialize()
Bug: T311676
Change-Id: Ibf65ec1e12b746bb234f888aa4ca3820ae0f6974
2022-06-30 01:06:56 +01:00
Translation updater bot 40133efc14 Localisation updates from https://translatewiki.net.
Change-Id: Icd7b1137db11fdc992bf51036e3f6275e2720d78
2022-06-29 08:35:30 +02:00
Translation updater bot 061e159118 Localisation updates from https://translatewiki.net.
Change-Id: I7b9e486905a58575334a01696945cb4310c2dba6
2022-06-08 08:27:42 +02:00
libraryupgrader 6d7433a0c9 build: Updating grunt to 1.5.3
Change-Id: I2f2c03a2bf454188180e3accc7a422e2e361a5c4
2022-05-26 20:25:15 +00:00