wikimedia/mediawiki-extensions-PageImages
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/PageImages synced 2024-11-15 03:43:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor duplicate code in LinksUpdateHookHandlerTest

Browse source 
Change-Id: I9acaadf18e859758cd7bdcb7d260007402695060
This commit is contained in:
Thiemo Mättig 2016-03-10 16:27:40 +01:00
parent 151a5d7248
commit 6c53cac48e
1 changed files with 29 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
tests/phpunit/LinksUpdateHookHandlerTest.php
View file

@ -2,6 +2,7 @@
namespace PageImages\Tests\Hooks;
use LinksUpdate;
use PageImages\Hooks\LinksUpdateHookHandler;
use PageImages;
use ParserOutput;
@ -24,7 +25,10 @@ class LinksUpdateHookHandlerTest extends PHPUnit_Framework_TestCase {
parent::tearDown();
}
public function testOnLinksUpdate() {
/**
* @return LinksUpdate
*/
private function getLinksUpdate() {
$parserOutput = new ParserOutput();
$parserOutput->setExtensionData( 'pageImages', array(
array( 'filename' => 'A.jpg', 'fullwidth' => 100, 'fullheight' => 50 ),
@ -37,12 +41,13 @@ class LinksUpdateHookHandlerTest extends PHPUnit_Framework_TestCase {
->method( 'getParserOutput' )
->will( $this->returnValue( $parserOutput ) );
LinksUpdateHookHandler::onLinksUpdate( $linksUpdate );
$this->assertTrue( property_exists( $linksUpdate, 'mProperties' ), 'precondition' );
$this->assertSame( 'A.jpg', $linksUpdate->mProperties[PageImages::PROP_NAME] );
return $linksUpdate;
}
public function testGetMetadata() {
/**
* @return RepoGroup
*/
private function getRepoGroup() {
$file = $this->getMockBuilder( 'File' )
->disableOriginalConstructor()
->getMock();
@ -51,27 +56,33 @@ class LinksUpdateHookHandlerTest extends PHPUnit_Framework_TestCase {
->method( 'isDeleted' )
->will( $this->returnValue( true ) );
$mockRepoGroup = $this->getMockBuilder( 'RepoGroup' )
$repoGroup = $this->getMockBuilder( 'RepoGroup' )
->disableOriginalConstructor()
->getMock();
$mockRepoGroup->expects( $this->any() )
$repoGroup->expects( $this->any() )
->method( 'findFile' )
->will( $this->returnValue( $file ) );
RepoGroup::setSingleton( $mockRepoGroup );
$parserOutput = new ParserOutput();
$parserOutput->setExtensionData( 'pageImages', array(
array( 'filename' => 'A.jpg', 'fullwidth' => 100, 'fullheight' => 50 ),
) );
return $repoGroup;
}
$linksUpdate = $this->getMockBuilder( 'LinksUpdate' )
->disableOriginalConstructor()
->getMock();
$linksUpdate->expects( $this->any() )
->method( 'getParserOutput' )
->will( $this->returnValue( $parserOutput ) );
public function testOnLinksUpdate() {
$linksUpdate = $this->getLinksUpdate();
LinksUpdateHookHandler::onLinksUpdate( $linksUpdate );
$this->assertTrue( property_exists( $linksUpdate, 'mProperties' ), 'precondition' );
$this->assertSame( 'A.jpg', $linksUpdate->mProperties[PageImages::PROP_NAME] );
}
public function testFetchingExtendedMetadataFromFile() {
// Required to make wfFindFile in LinksUpdateHookHandler::getScore return something.
RepoGroup::setSingleton( $this->getRepoGroup() );
$linksUpdate = $this->getLinksUpdate();
LinksUpdateHookHandler::onLinksUpdate( $linksUpdate );
$this->assertTrue( true, 'no errors in getMetadata' );
}
}