Commit graph

1484 commits

Author SHA1 Message Date
Reedy 71fb7999f1 Fix a few remaining occurances of recovery token
Bug: T354031
Follows-Up: Icf8626799615f8b95f380db9745e1447519b150a
Change-Id: Ief577fb3e6adbf72b374d86df67529c46e4fe83e
2024-01-11 14:00:57 +00:00
James D. Forrester 217674f561 i18n: Rename the recovery code i18n messages to match
Follows-Up: Icf8626799615f8b95f380db9745e1447519b150a
Follows-Up: Ida71577719afbc1232cf1fd072503e2d3b8981bd
Change-Id: I9e788d2aa2b139cfb4c344ad424eb6a2586c33c4
2024-01-11 08:46:56 -05:00
Reedy 9039300635 TOTPEnableForm: Emphasise importance of recovery codes
Bug: T174937
Change-Id: Ida71577719afbc1232cf1fd072503e2d3b8981bd
2024-01-11 08:46:56 -05:00
jenkins-bot ed1dccc419 Merge "Standardised UI strings to use "recovery codes"" 2024-01-11 13:44:01 +00:00
Translation updater bot a3eeb983b0 Localisation updates from https://translatewiki.net.
Change-Id: Ib2517dbc1a7f27d5e56f269842857b04859e17cb
2024-01-11 10:05:22 +01:00
Translation updater bot 121a5f0686 Localisation updates from https://translatewiki.net.
Change-Id: I9999e5a24eb7200bfbc770b699487af7cf82acaf
2024-01-10 08:33:11 +01:00
Translation updater bot 10e47d353c Localisation updates from https://translatewiki.net.
Change-Id: Ia08007a989eadc291a596c2e2a4ca855fd6a22f0
2024-01-09 09:00:08 +01:00
Reedy 16058b456a Standardised UI strings to use "recovery codes"
This normalises the uses of "tokens" and "scratch"

Not changing all interal usages of "scratch"; comments
and some variables updated. Functions not updated.

Bug: T354031
Change-Id: Icf8626799615f8b95f380db9745e1447519b150a
2024-01-08 16:34:04 +00:00
jenkins-bot bf64c32647 Merge "Add test for user repository" 2024-01-08 11:33:56 +00:00
jenkins-bot a9bfc84cc2 Merge "Fix disabling two-factor authentication" 2024-01-08 11:14:03 +00:00
jenkins-bot 28132bfadd Merge "OATHAuthServices: Fix service name" 2024-01-08 11:14:00 +00:00
jenkins-bot 92a4db8312 Merge "oathauth-step1-test: Improve examples (and add links) of 2FA apps" 2024-01-08 10:58:30 +00:00
Taavi Väänänen c240ec5d7f
Add test for user repository
Change-Id: Iabd052ca2b6264254f6750b14e04df9923e732c0
2024-01-08 11:53:54 +02:00
Taavi Väänänen caf64f75ca
Fix disabling two-factor authentication
Fixes 97abce5.

Bug: T354505
Change-Id: Ifde7434a6c02e2f8d9d790834b7f316d4afa205a
2024-01-08 11:53:54 +02:00
Taavi Väänänen 7c46714b31
OATHAuthServices: Fix service name
Bug: T354505
Change-Id: Ie66a56904ad687ea8a2422bb713e54066559c6b4
2024-01-08 11:44:11 +02:00
Translation updater bot 2edc5053af Localisation updates from https://translatewiki.net.
Change-Id: I03c4c977589b5fb8e6a017b2100ba13f2d92abff
2024-01-08 09:16:04 +01:00
anterdc99 f76deba935
Add aliases for Chinese variants
What:
* Added variant Chinese (Hong Kong) (zh-hk)
* Added aliases of Special:DisableOATHForUser
* Added aliases of Special:VerifyOATHForUser

Change-Id: Ibbe04cdae9613b2417a144e58c5a90399c0bc50a
2024-01-07 17:43:49 +08:00
Translation updater bot 383a98eb6c Localisation updates from https://translatewiki.net.
Change-Id: I976a2101b04aefb18b97a4cb53d7cae4808c7ede
2024-01-05 09:13:08 +01:00
Reedy d4cc647595 oathauth-step1-test: Improve examples (and add links) of 2FA apps
Bug: T226059
Change-Id: I13ccf55016f6ca212142ce2a4290255f2890e023
2024-01-04 10:30:05 +00:00
Taavi Väänänen 0010503271
OATHUser: Cache central ID
It's useful to have the user central ID available in various places, for
example when caching used tokens to prevent replay attacks, and since
OATHUserRepository has to look it up anyway let's just store it from
there instead of looking it up again.

Change-Id: Ifb896feb7c70af638c14301511d067f24e35d6c2
2024-01-04 11:56:02 +02:00
Reedy ca3b49b86f TOTPEnableForm: Add message for step 2 before qr code image
Change-Id: Ifdacc045b5796c53061ab7b4f5ef44e4ade310a2
2024-01-03 17:07:24 +00:00
Translation updater bot e8cdd2591a Localisation updates from https://translatewiki.net.
Change-Id: Idb5e6ab88fe7b148d2de07fc7634e2e63b77e56b
2024-01-03 08:34:55 +01:00
jenkins-bot ca98c1ce00 Merge "UpdateTables: Move code into maintenance script for modernisation and simplification" 2024-01-02 15:13:27 +00:00
Reedy 86def072cf UpdateTables: Move code into maintenance script for modernisation and simplification
Change-Id: If238e6a74f9de952360526b23e8e9d2a396ebf62
2024-01-02 14:24:12 +00:00
Translation updater bot 9d4b23dfa7 Localisation updates from https://translatewiki.net.
Change-Id: I1ee4dcdc9ad8236f74bc9330c0612451c855504c
2024-01-02 10:17:00 +01:00
Reedy fc3e6695fb TOTPKey: Fix return of verify()
Change-Id: Ic5c671c3f39153b2a3c55169988d7af4b57b3cbb
2024-01-01 22:12:30 +00:00
Taavi Väänänen 62f26d8801
Special: Cleanup module handling
Bug: T242031
Change-Id: If76dc0b8a5ebab82ce155952749cf7e8dffd221d
2023-12-31 10:05:51 +02:00
Taavi Väänänen 89471a0d3a HookHandler: Use isTwoFactorAuthEnabled instead of comparing modules
Bug: T242031
Change-Id: I0c2f67bae6b13b5c4e29284160920e8ad7183f4d
2023-12-31 07:41:50 +00:00
jenkins-bot 7e8381b86f Merge "TOTP: Cleanup uses of getFirstKey, getModule" 2023-12-31 07:24:42 +00:00
jenkins-bot 47e0c211e6 Merge "TOTP: Remove getConfig()" 2023-12-31 07:24:40 +00:00
jenkins-bot 4259dabad3 Merge "Use namespaced classes" 2023-12-31 07:00:13 +00:00
Umherirrender 54a314e3ea Use namespaced classes
Done automatically via script

Change-Id: Ic47a7a57a08be4d020c69f0a4029855955201a0f
2023-12-30 00:16:48 +01:00
Translation updater bot 218e235bbf Localisation updates from https://translatewiki.net.
Change-Id: I7fdb108fcd960e13a7a04bacd2b8643352b78015
2023-12-29 19:22:32 +01:00
Translation updater bot 82fb985ab8 Localisation updates from https://translatewiki.net.
Change-Id: I54e8721d41801ca548ddeed6ad1e1515df054102
2023-12-28 14:50:13 +01:00
Taavi Väänänen 93b7dfc3ed
TOTP: Cleanup uses of getFirstKey, getModule
Bug: T242031
Change-Id: Ibaa6515421c86168412b0bb30ae5655774304326
2023-12-28 12:20:03 +02:00
Taavi Väänänen d71e0a1952
TOTP: Remove getConfig()
I'm not finding any traces on what this is needed for.

Change-Id: Idffd03e2ae1dd747d3d141f6db0563bccd69c9eb
2023-12-28 12:16:40 +02:00
Reedy 70f5d3a056 TOTPEnableForm: Remove unused variable
Follows-Up: Ifc84d86648e8437577536fa7c50ea1a4f8ac248c
Change-Id: I21688a163534dc276f2a7c7e9054ce4f3ef19b2e
2023-12-27 14:33:14 +00:00
jenkins-bot b68254ee6f Merge "TOTPEnableForm: Reorder manual step and improve oathauth-step2alt" 2023-12-27 11:30:01 +00:00
jenkins-bot 27e274723d Merge "TOTPEnableForm: Display issuer in manual account name" 2023-12-27 11:28:37 +00:00
Reedy f773fa040c TOTPEnableForm: Reorder manual step and improve oathauth-step2alt
Bug: T226060
Change-Id: I332c3cd53d5ba3351c5316a1cf67485b513520bb
2023-12-26 22:40:23 +00:00
Reedy a8e6966cb0 TOTPEnableForm: Display issuer in manual account name
Bug: T226060
Change-Id: Ifc84d86648e8437577536fa7c50ea1a4f8ac248c
2023-12-26 22:35:01 +00:00
Reedy c9b9c9601d en.json: Improve oathauth-scratchtokens
* Replace "phone" with "device"
* Advise users to mark scratch tokens as used upon usage
* Advice users they're for emergency usage when no access to device

Bug: T150564
Bug: T150868
Bug: T174937
Change-Id: Icd11a4fe00dd63430640ed9d01bc1c30f3c7ca88
2023-12-26 22:00:51 +00:00
Derk-Jan Hartman 55b465c196 Provide an alt label to the SVG qr code
The raw svg was represented to a11y dom as 256x256 images (due to
the 'use'). Convert the raw SVG to a base64 encoded img data uri and
provide it with an alt attribute describing the function.

While the qr code is duplicate with the 'manual' code below it, it is
not decorative so should not suppress alt. It's a big image and if
you use touch interaction, it would create a big blank spot. It is
useful to know for users that the QR code is there.

The img wrapping should also make the SVG usage slightly safer. It
avoids any potential remote resource usage from inside the SVG. While
this is not a direct danger right now, compromised php packages can
happen, and this limits the impact in that case.

Bug: T151550
Change-Id: I568927ace95a1fdf9cd7990bc7de8461718aa1c1
2023-12-26 14:46:45 +00:00
Translation updater bot d91b15187c Localisation updates from https://translatewiki.net.
Change-Id: I1a81dfffab785722aaf78c0eabfb8feae9daa50d
2023-12-26 14:43:16 +01:00
Taavi Väänänen 095f91815b
notifications: Store number of keys in notification data
We want to customize the message depending on the number of active
devices, for example "an authentication device was removed" vs
"two-factor has been disabled".

Bug: T353962
Change-Id: Iaeb119a7cc6c264c4e49edeb3a88453786547021
2023-12-25 13:48:56 +02:00
Taavi Väänänen 97abce5e90
Call OATHAuthUser::disable() in UserRepository::remove()
Ensures that the database and the user object will stay in sync.

Change-Id: I36ed361594e24dfdb96e23fc5b04fa342ece6df5
2023-12-25 13:19:58 +02:00
jenkins-bot 0d35e253bf Merge "OATHUserRepository: add method to create and persist a key" 2023-12-22 18:09:20 +00:00
Translation updater bot 9c5cd5d4fa Localisation updates from https://translatewiki.net.
Change-Id: Ic1529b55c30ad7d6db79533363526c1ea3f356ce
2023-12-22 17:46:31 +01:00
Taavi Väänänen 11d47134db
OATHUserRepository: add method to create and persist a key
This means that when keys will be ID-aware, a key object can be
immutable (instead of creating it without an ID and adding it in
persist()).

Change-Id: Ie1286ed71871dcedb2bd7d8d373f944be6691064
2023-12-22 17:07:52 +02:00
Taavi Väänänen 064308c1b9 OATHUser: throw when adding an invalid key instead of failing silently
Something will go wrong sooner or later if this fails silently.

Change-Id: I5c4ffec481b2c62e1c8cc68c379667641084c23b
2023-12-22 11:48:09 +00:00