Add method scope visibility

Change-Id: I6f4d4acf4fcb4aab318ca217dd4e6185f383e27e
This commit is contained in:
Umherirrender 2018-11-02 11:26:41 +01:00
parent a8bc0f58d1
commit f8b629f39b
4 changed files with 12 additions and 13 deletions

View file

@ -1,7 +1,6 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset name="MediaWiki"> <ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Squiz.Scope.MethodScope.Missing" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule> </rule>

View file

@ -61,7 +61,7 @@ abstract class ProxySpecialPage extends SpecialPage {
/** /**
* @return string * @return string
*/ */
function getName() { public function getName() {
$this->init(); $this->init();
return $this->target->getName(); return $this->target->getName();
} }
@ -70,7 +70,7 @@ abstract class ProxySpecialPage extends SpecialPage {
* @param string|bool $subpage * @param string|bool $subpage
* @return Title * @return Title
*/ */
function getPageTitle( $subpage = false ) { public function getPageTitle( $subpage = false ) {
$this->init(); $this->init();
return $this->target->getPageTitle( $subpage ); return $this->target->getPageTitle( $subpage );
} }
@ -78,7 +78,7 @@ abstract class ProxySpecialPage extends SpecialPage {
/** /**
* @return string * @return string
*/ */
function getLocalName() { public function getLocalName() {
$this->init(); $this->init();
return $this->target->getLocalName(); return $this->target->getLocalName();
} }
@ -86,7 +86,7 @@ abstract class ProxySpecialPage extends SpecialPage {
/** /**
* @return string * @return string
*/ */
function getRestriction() { public function getRestriction() {
$this->init(); $this->init();
return $this->target->getRestriction(); return $this->target->getRestriction();
} }
@ -94,7 +94,7 @@ abstract class ProxySpecialPage extends SpecialPage {
/** /**
* @return bool * @return bool
*/ */
function isListed() { public function isListed() {
$this->init(); $this->init();
return $this->target->isListed(); return $this->target->isListed();
} }
@ -103,7 +103,7 @@ abstract class ProxySpecialPage extends SpecialPage {
* @param bool $listed * @param bool $listed
* @return bool * @return bool
*/ */
function setListed( $listed ) { public function setListed( $listed ) {
$this->init(); $this->init();
return $this->target->setListed( $listed ); return $this->target->setListed( $listed );
} }
@ -112,7 +112,7 @@ abstract class ProxySpecialPage extends SpecialPage {
* @param bool|null $x * @param bool|null $x
* @return bool * @return bool
*/ */
function listed( $x = null ) { public function listed( $x = null ) {
$this->init(); $this->init();
return $this->target->listed( $x ); return $this->target->listed( $x );
} }
@ -129,7 +129,7 @@ abstract class ProxySpecialPage extends SpecialPage {
* @param bool|null $x * @param bool|null $x
* @return bool * @return bool
*/ */
function including( $x = null ) { public function including( $x = null ) {
$this->init(); $this->init();
return $this->target->including( $x ); return $this->target->including( $x );
} }
@ -154,7 +154,7 @@ abstract class ProxySpecialPage extends SpecialPage {
/** /**
* @throws PermissionsError * @throws PermissionsError
*/ */
function displayRestrictionError() { public function displayRestrictionError() {
$this->init(); $this->init();
$this->target->displayRestrictionError(); $this->target->displayRestrictionError();
} }
@ -195,7 +195,7 @@ abstract class ProxySpecialPage extends SpecialPage {
/** /**
* @return string * @return string
*/ */
function getDescription() { public function getDescription() {
$this->init(); $this->init();
return $this->target->getDescription(); return $this->target->getDescription();
} }

View file

@ -8,7 +8,7 @@ if ( getenv( 'MW_INSTALL_PATH' ) ) {
require_once "$IP/maintenance/Maintenance.php"; require_once "$IP/maintenance/Maintenance.php";
class DisableOATHAuthForUser extends Maintenance { class DisableOATHAuthForUser extends Maintenance {
function __construct() { public function __construct() {
parent::__construct(); parent::__construct();
$this->mDescription = 'Remove OATHAuth from a specific user'; $this->mDescription = 'Remove OATHAuth from a specific user';
$this->addArg( 'user', 'The username to remove OATHAuth from.' ); $this->addArg( 'user', 'The username to remove OATHAuth from.' );

View file

@ -32,7 +32,7 @@ if ( getenv( 'MW_INSTALL_PATH' ) ) {
require_once "$IP/maintenance/Maintenance.php"; require_once "$IP/maintenance/Maintenance.php";
class UpdateScratchTokenFormat extends Maintenance { class UpdateScratchTokenFormat extends Maintenance {
function __construct() { public function __construct() {
parent::__construct(); parent::__construct();
$this->mDescription = 'Script to update scratch_token column format'; $this->mDescription = 'Script to update scratch_token column format';
$this->requireExtension( 'OATHAuth' ); $this->requireExtension( 'OATHAuth' );