From 8992e6f541cd7adf8111ccd87f25a481d3759b33 Mon Sep 17 00:00:00 2001
From: Reedy <reedy@wikimedia.org>
Date: Thu, 2 Aug 2012 03:04:42 +0100
Subject: [PATCH] Fix tabindex of token so it's not the same as password (which
 has 2)

Setting it to 3, has the effect of doing the LDAP first and then the token,
which fits the user model

Order of boxes is Username, password, domain, token

These then have a tab index of 1, 2, 3, 2

Tabbing down takes you in the order username, password, token, labs, which is... irritating, to say the least!

Change-Id: Idabb70c963d16f2cd223c5d94e0211ccaf6fdedd
---
 OATHUser.php | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/OATHUser.php b/OATHUser.php
index acb70fee..892ad122 100644
--- a/OATHUser.php
+++ b/OATHUser.php
@@ -282,13 +282,16 @@ class OATHUser {
 	}
 
 	/**
-	 * @param $template
+	 * @param $template UserloginTemplate
 	 * @return bool
 	 */
 	static function ModifyUITemplate( &$template ) {
-		// FIXME: First assignment of $input unused
-		$input = array( 'msg' => 'oathauth-token', 'type' => 'text', 'name' => 'token', 'value' => '', 'helptext' => 'oathauth-tokenhelp' );
-		$input = '<td class="mw-label"><label for="wpOATHToken">' . wfMsgHtml( 'oathauth-token' ) . '</label></td><td class="mw-input">' . Html::input( 'wpOATHToken', null, 'password', array( 'class' => 'loginPassword', 'id' => 'wpOATHToken', 'tabindex' => '2', 'size' => '20' ) ) . '</td>';
+		$input = '<td class="mw-label"><label for="wpOATHToken">'
+			. wfMsgHtml( 'oathauth-token' )
+			. '</label></td><td class="mw-input">'
+			. Html::input( 'wpOATHToken', null, 'password', array(
+				'class' => 'loginPassword', 'id' => 'wpOATHToken', 'tabindex' => '3', 'size' => '20'
+			) ) . '</td>';
 		$template->set( 'extrafields', $input );
 
 		return true;