wikimedia/mediawiki-extensions-OATHAuth
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/OATHAuth synced 2024-11-30 19:14:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add URL encoding to TOTP QR code URL

Browse source 
Add RFC 3986 URI encoding to the account label in accordance with the
Google Authenticator specification to ensure the QR code is properly
generated for usernames with special characters in them.

Bug: T136269
Change-Id: I18175c9a3c9a45346fa7a227a5209194385c6696
This commit is contained in:
Tyler Romeo 2016-05-26 12:17:00 -04:00
parent 079877734c
commit 7b8a68fd5a
No known key found for this signature in database
GPG key ID: 405D34A7C86B42DF
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
special/SpecialOATHEnable.php
View file

@ -82,9 +82,9 @@ class SpecialOATHEnable extends FormSpecialPage {
array( 'ext.oathauth' ), array( 'ext.oathauth' ),
new XmlJsCode( new XmlJsCode(
'function () {' 'function () {'
. '$("#qrcode").qrcode("otpauth://totp/' . '$("#qrcode").qrcode("otpauth://totp/'
. $this->OATHUser->getAccount() . rawurlencode( $this->OATHUser->getAccount() )
. '?secret=' . $secret. '");' . '?secret=' . $secret . '");'
. '}' . '}'
) )
) ) ) )