Commit graph

29 commits

Author SHA1 Message Date
Marcin Cieślak 20c756ac0b Fix bug 23600: column "recentchanges.rc_timestamp" should be in GROUP BY
PostgreSQL error:

Query: SELECT rc_namespace,rc_title,rc_timestamp,COUNT(*) AS edits FROM recentchanges WHERE rc_user_text = 'Dnessett' AND ((rc_new = 1) OR (rc_log_type = 'upload' AND rc_log_action = 'upload')) GROUP BY rc_namespace, rc_title ORDER BY rc_timestamp DESC Function: SpecialNuke::getNewPages Error: 1 ERROR: column "recentchanges.rc_timestamp" must appear in the GROUP BY clause or be used in an aggregate function 

Backtrace:

#0 /usr/local/src/mediawiki/MW_1_13_2/phase3/includes/db/Database.php(561): DatabasePostgres->reportQueryError('ERROR: column ...', 1, 'SELECT rc_name...', 'SpecialNuke::ge...', false)
#1 /usr/local/src/mediawiki/MW_1_13_2/phase3/includes/db/Database.php(969): Database->query('SELECT rc_name...', 'SpecialNuke::ge...')
#2 /usr/local/src/mediawiki/MW_1_13_2/phase3/extensions/Nuke/Nuke_body.php(132): Database->select('recentchanges', Array, Array, 'SpecialNuke::ge...', Array)
#3 /usr/local/src/mediawiki/MW_1_13_2/phase3/extensions/Nuke/Nuke_body.php(68): SpecialNuke->getNewPages('Dnessett')
#4 /usr/local/src/mediawiki/MW_1_13_2/phase3/extensions/Nuke/Nuke_body.php(42): SpecialNuke->listForm('Dnessett', 'Mass removal of...')
#5 /usr/local/src/mediawiki/MW_1_13_2/phase3/includes/SpecialPage.php(534): SpecialNuke->execute(NULL)
#6 /usr/local/src/mediawiki/MW_1_13_2/phase3/includes/Wiki.php(224): SpecialPage::executePath(Object(Title))
#7 /usr/local/src/mediawiki/MW_1_13_2/phase3/includes/Wiki.php(55): MediaWiki->initializeSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#8 /usr/local/src/mediawiki/MW_1_13_2/phase3/index.php(93): MediaWiki->initialize(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest))
#9 {main}

Thanks-To:

13:15 [freenode] -!- Tuju [~tuju@176.75.219.213.sta.estpak.ee]
13:15 [freenode] -!-  ircname  : Juha Tuomala
13:15 [freenode] -!-  channels : #mediawiki 
13:15 [freenode] -!-  server   : kornbluth.freenode.net [Frankfurt, Germany]
13:15 [freenode] -!-  account  : Tuju
13:15 [freenode] -!- End of WHOIS
2012-03-08 13:28:01 +00:00
Jeroen De Dauw 4e3aa8fcd3 Follow up to r108871; -m 2012-02-12 14:45:29 +00:00
Sam Reed 2d918ec529 Revert most of r108602
For such a minor cosmetic fix, having to do a query per result row is just daft
2012-01-13 22:59:39 +00:00
Sam Reed a45af09c07 Minor stylistic changes
Don't attempt to return values returned by void methods

Kill freeResult

Minor documentation
2012-01-13 22:45:24 +00:00
Jeroen De Dauw 7fbbea0f0c fix bug 16985 based on attached patch by Nakon 2012-01-11 09:34:47 +00:00
Robin Pepermans 9924f686cd Make the messages labels for the input 2011-12-18 18:44:30 +00:00
Robin Pepermans b8e937db7e follow-up r105066: makeKnownLinkObj() is deprecated 2011-12-03 19:28:35 +00:00
Robin Pepermans 57a9ab8331 Split the default reason for single users and multiple users; easier for translators. The "nuke-multiplepeople" was substituted as parameter one (in the user language!!). Also include a link to the contributions in parameter 1 of "nuke-defaultreason".
Some other small changes: whitespace fixes, update getLang() -> getLanguage(), call Linker statically, increase the reason input box size
2011-12-03 12:28:29 +00:00
Sam Reed 44bb215160 "else if" -> "elseif" 2011-11-25 00:20:54 +00:00
Jeroen De Dauw 6133cddd5b got rid of inline js and made use of jQuery 2011-11-10 17:40:32 +00:00
Jeroen De Dauw 531d451e3c killed globals 2011-11-10 17:22:05 +00:00
Jeroen De Dauw b89d07b5c4 implemented sql like match feature as suggested in bug 5835 and fixed regression causing the list of pages to be not shown when not specifying a user 2011-11-10 17:04:38 +00:00
Jeroen De Dauw 2848522f3a Follow up to r82136; 2011-10-18 22:46:31 +00:00
Sam Reed 21041dd44b Fix whitespace
Add comments
2011-09-27 16:17:06 +00:00
Alexandre Emsenhuber 282af6de94 Now that the hooks ArticleDelete and ArticleDeleteComplete are called from WikiPage::doDeleteArticle() and not anymore from Article::doDelete(), let's call the former and handle ourself the output 2011-07-10 07:00:09 +00:00
Brian Wolff 46c369b58c revert 70005 - Causes bug where if a revision is imported on an already existing page, special:nuke
will delete the whole page, where it is expected to only delete the page if the user is only one to contribute.

Also breaks listing file uploads (reported by Manuelt15 on irc).
2011-02-26 00:35:45 +00:00
Jeroen De Dauw e14680fe0b Added a changable limit and the option to not filter the recent changes on a single user 2011-02-14 20:21:02 +00:00
Sam Reed ad4ac718be Like r81204, fixup other usages of getThumbnail in extensions (One extension, Nuke, is one we care about...) 2011-01-30 08:11:59 +00:00
Sam Reed ed86c3b901 Remove unused variable, it's done explicitally inline further down 2011-01-23 09:51:55 +00:00
Ryan Kaldari ad3f2f39a7 quick fix for bug 26185 2010-12-01 20:46:05 +00:00
Sam Reed 8f5809c8cc Conditionals in loops to foreachs 2010-10-29 21:30:20 +00:00
Sam Reed 99bd0a3153 Start removing/fixing calls to deprecated methods in WMF used extensions 2010-10-29 15:14:44 +00:00
Sam Reed ea44675046 Fixup r70005 per CR (Hey, I only applied the patch ;)) 2010-07-31 19:25:54 +00:00
Sam Reed 0934e34500 *(bug 9120) Special:Nuke does not list imported page
Patch by Frank Ralf
2010-07-27 12:00:30 +00:00
Aryeh Gregor eaef492c15 Remove most named character references from output
Recommit of r66254 to trunk.  This was just

find extensions phase3 -iname '*.php' \! -iname '*.i18n.php' \! -iname 'Messages*.php' \! -iname '*_Messages.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/α/α/g;s/ä/ä/g;s/ç/ç/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/ê/ê/g;s/ë/ë/g;s/è/è/g;s/€/€/g;s/↔//g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/“/“/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/œ/œ/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/”/”/g;s/Σ/Σ/g;s/×/×/g;s/ú/ú/g;s/↑/↑/g;s/ü/ü/g;s/¥/¥/g' {} +

followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives.  The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html>.
I cleared it with Tim and Brion on IRC before committing.  It might
cause a few problems, but I tried to be careful; please report any
issues.

I skipped all messages files.  I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.

This should get rid of all named entities everywhere except messages.  I
skipped a few things like &nbsp that I noticed in manual inspection,
because they weren't well-formed XML anyway.

Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I still hate you.  Die.
2010-05-30 17:33:59 +00:00
Chad Horohoe 8276142e35 Revert r66934 (Removing wfLoadExtensionMessages() from everything). I disagree on principle...we branch extensions for this very reason. But people want trunk extensions compatible for several versions back, meh. 2010-05-27 15:56:53 +00:00
Chad Horohoe 4eef8b25fd Large commit. Removed 800+ references to no-op wfLoadExtensionMessages() 2010-05-26 22:25:32 +00:00
Platonides df7dc07005 (Bug 23600) Use single quotes for the string on SQL.
On Postgres text is quoted by single quotes and double quotes
are used for identifiers.
Thus Postgres gives out the error "Column upload does not exist".
2010-05-20 14:08:30 +00:00
Siebrand Mazeland 856ed5c0c2 Rename to remove "Special" prefix from filenames. Update Configure and Translate accordingly. 2010-04-18 11:53:49 +00:00
Renamed from SpecialNuke_body.php (Browse further)