wikimedia/mediawiki-extensions-Nuke
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Nuke synced 2024-11-23 15:57:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

SpecialNuke: Don't add actor names WHERE if no names supplied

Browse source 
Why:

- If submitting the form with no conditions, the `$actornames` variable
  will be an array with a single empty string, which means the WHERE
  clause won't find any matches

What:

- Only add actor names to the WHERE clause if the array contains names
  to check

Bug: T342785
Change-Id: I7f407695583c1d7ebaf81d116578bd336adc5c7f
This commit is contained in:
Kosta Harlan 2024-10-21 16:09:15 +02:00
parent 98aa8d9942
commit 0923015f4a
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/SpecialNuke.php
View file

@ -454,8 +454,10 @@ class SpecialNuke extends SpecialPage {
if ( $username === '' ) {
$queryBuilder->field( 'actor_name', 'rc_user_text' );
} else {
$actornames = [ $username, ...$tempnames ];
$queryBuilder->andWhere( [ 'actor_name' => $actornames ] );
$actornames = array_filter( [ $username, ...$tempnames ] );
if ( $actornames ) {
$queryBuilder->andWhere( [ 'actor_name' => $actornames ] );
}
}
if ( $namespace !== null ) {