mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer
synced 2024-11-15 11:59:22 +00:00
d204ecc99a
This heavily relied on deferreds getting resolved synchroneously, which (for .then) is no longer the case with jQuery 3. There's also a difference in how chained .then's get resolved. These tests did not wait for the deferreds to get resolved async, so that had to change. Worse even: some functionality was tested by assuming a handler would not be called (= the test in that handler would not be called), which didn't make the test run, because we never even waited for it to be called. The changes in here are basically: * make mmv.bootstrap.js correctly use .then instead of .done & fail * let mmw.bootstrap.test.js tests wait for unresolved async promises * check call counts instead of running tests inside of callbacks * limit use of fake timer to the 1 test that needs it (it interferes with async, which otherwise don't get resolved) Bug: T164473 Change-Id: I3ca4f786890ad1646f71fe336afdb61e5c3b01c7 |
||
|---|---|---|
| .. | ||
| img | ||
| logging | ||
| model | ||
| provider | ||
| routing | ||
| ui | ||
| mmv.base.js | ||
| mmv.bootstrap.autostart.js | ||
| mmv.bootstrap.js | ||
| mmv.bootstrap.less | ||
| mmv.Config.js | ||
| mmv.EmbedFileFormatter.js | ||
| mmv.globals.less | ||
| mmv.head.js | ||
| mmv.HtmlUtils.js | ||
| mmv.js | ||
| mmv.lightboximage.js | ||
| mmv.lightboxinterface.js | ||
| mmv.lightboxinterface.less | ||
| mmv.mixins.less | ||
| mmv.ThumbnailWidthCalculator.js | ||