mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer
synced 2024-11-29 18:34:25 +00:00
0d743977dd
- Fixes the bug where the options menu wouldn't open if media viewer was reopened - Adds human-readable console messages for the options actions - Makes the tooltip a tipsy one like all the other buttons - Fixes the tooltip copy, it was referring to "previews", which we said we wouldn't do anymore, in favour of "Media Viewer" Change-Id: I1590f9501cc6c406cc1f466b414062d4d6435c1b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/963
149 lines
5.9 KiB
JavaScript
149 lines
5.9 KiB
JavaScript
( function ( mw, $ ) {
|
|
QUnit.module( 'mmv.logging.DurationLogger', QUnit.newMwEnvironment({
|
|
setup: function () {
|
|
this.clock = this.sandbox.useFakeTimers();
|
|
}
|
|
} ) );
|
|
|
|
QUnit.test( 'start()', 8, function ( assert ) {
|
|
var durationLogger = new mw.mmv.durationLogger.constructor();
|
|
durationLogger.samplingFactor = 1;
|
|
|
|
try {
|
|
durationLogger.start();
|
|
} catch ( e ) {
|
|
assert.ok( true, 'Exception raised when calling start() without parameters' );
|
|
}
|
|
assert.ok( $.isEmptyObject( durationLogger.starts ), 'No events saved by DurationLogger' );
|
|
|
|
durationLogger.start( 'foo' );
|
|
assert.strictEqual( durationLogger.starts.foo, 0, 'Event start saved' );
|
|
|
|
this.clock.tick( 1000 );
|
|
durationLogger.start( 'bar' );
|
|
assert.strictEqual( durationLogger.starts.bar, 1000, 'Later event start saved' );
|
|
|
|
durationLogger.start( 'foo' );
|
|
assert.strictEqual( durationLogger.starts.foo, 0, 'Event start not overritten' );
|
|
|
|
this.clock.tick( 666 );
|
|
durationLogger.start( [ 'baz', 'bob', 'bar' ] );
|
|
assert.strictEqual( durationLogger.starts.baz, 1666, 'First simultaneous event start saved' );
|
|
assert.strictEqual( durationLogger.starts.bob, 1666, 'Second simultaneous event start saved' );
|
|
assert.strictEqual( durationLogger.starts.bar, 1000, 'Third simultaneous event start not overwritten' );
|
|
} );
|
|
|
|
QUnit.test( 'stop()', 17, function ( assert ) {
|
|
var dependenciesDeferred = $.Deferred(),
|
|
fakeEventLog = { logEvent : this.sandbox.stub() },
|
|
durationLogger = new mw.mmv.durationLogger.constructor();
|
|
|
|
durationLogger.samplingFactor = 1;
|
|
durationLogger.schemaSupportsCountry = this.sandbox.stub().returns( true );
|
|
|
|
this.sandbox.stub( mw.user, 'isAnon' ).returns( false );
|
|
this.sandbox.stub( durationLogger, 'loadDependencies' ).returns( dependenciesDeferred.promise() );
|
|
|
|
try {
|
|
durationLogger.stop();
|
|
} catch ( e ) {
|
|
assert.ok( true, 'Exception raised when calling stop() without parameters' );
|
|
}
|
|
|
|
durationLogger.setEventLog( fakeEventLog );
|
|
|
|
durationLogger.start( 'bar' );
|
|
this.clock.tick( 1000 );
|
|
durationLogger.stop( 'bar' );
|
|
|
|
assert.ok( !fakeEventLog.logEvent.called, 'Event queued if dependencies not loaded' );
|
|
|
|
// Queue a second item
|
|
|
|
durationLogger.start( 'bob' );
|
|
this.clock.tick( 4000 );
|
|
durationLogger.stop( 'bob' );
|
|
|
|
assert.ok( !fakeEventLog.logEvent.called, 'Event queued if dependencies not loaded' );
|
|
|
|
dependenciesDeferred.resolve();
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.getCall( 0 ).args[ 0 ], 'MultimediaViewerDuration', 'EventLogging schema is correct' );
|
|
assert.deepEqual( fakeEventLog.logEvent.getCall( 0 ).args[ 1 ], { type : 'bar', duration : 1000, loggedIn : true, samplingFactor : 1 },
|
|
'EventLogging data is correct' );
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.getCall( 1 ).args[ 0 ], 'MultimediaViewerDuration', 'EventLogging schema is correct' );
|
|
assert.deepEqual( fakeEventLog.logEvent.getCall( 1 ).args[ 1 ], { type : 'bob', duration : 4000, loggedIn : true, samplingFactor : 1 },
|
|
'EventLogging data is correct' );
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.callCount, 2, 'logEvent called when processing the queue' );
|
|
|
|
durationLogger.start( 'foo' );
|
|
this.clock.tick( 3000 );
|
|
durationLogger.stop( 'foo' );
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.getCall( 2 ).args[ 0 ], 'MultimediaViewerDuration', 'EventLogging schema is correct' );
|
|
assert.deepEqual( fakeEventLog.logEvent.getCall( 2 ).args[ 1 ], { type : 'foo', duration : 3000, loggedIn : true, samplingFactor : 1 },
|
|
'EventLogging data is correct' );
|
|
|
|
assert.strictEqual( durationLogger.starts.bar, undefined, 'Start value deleted after stop' );
|
|
|
|
durationLogger.setGeo( { country : 'FR' } );
|
|
mw.user.isAnon.returns( true );
|
|
|
|
durationLogger.start( 'baz' );
|
|
this.clock.tick( 2000 );
|
|
durationLogger.stop( 'baz' );
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.getCall( 3 ).args[ 0 ], 'MultimediaViewerDuration', 'EventLogging schema is correct' );
|
|
assert.deepEqual( fakeEventLog.logEvent.getCall( 3 ).args[ 1 ], { type : 'baz', duration : 2000, loggedIn : false, country : 'FR', samplingFactor : 1 },
|
|
'EventLogging data is correct' );
|
|
|
|
assert.strictEqual( durationLogger.starts.bar, undefined, 'Start value deleted after stop' );
|
|
|
|
durationLogger.stop( 'fooz', $.now() - 9000 );
|
|
|
|
assert.deepEqual( fakeEventLog.logEvent.getCall( 4 ).args[ 1 ], { type : 'fooz', duration : 9000, loggedIn : false, country : 'FR', samplingFactor : 1 },
|
|
'EventLogging data is correct' );
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.callCount, 5, 'logEvent has been called fives times at this point in the test' );
|
|
|
|
durationLogger.stop( 'foo' );
|
|
|
|
assert.strictEqual( fakeEventLog.logEvent.callCount, 5, 'Stop without a start doesn\'t get logged' );
|
|
} );
|
|
|
|
QUnit.test( 'loadDependencies()', 3, function ( assert ) {
|
|
var promise,
|
|
durationLogger = new mw.mmv.durationLogger.constructor();
|
|
|
|
this.sandbox.stub( mw.loader, 'using' );
|
|
|
|
mw.loader.using.withArgs( [ 'ext.eventLogging', 'schema.MultimediaViewerDuration' ] ).throwsException( 'EventLogging is missing' );
|
|
|
|
promise = durationLogger.loadDependencies();
|
|
|
|
assert.strictEqual( promise.state(), 'rejected', 'Promise is rejected' );
|
|
|
|
// It's necessary to reset the stub, otherwise the original withArgs keeps running alongside the new one
|
|
mw.loader.using.restore();
|
|
this.sandbox.stub( mw.loader, 'using' );
|
|
|
|
mw.loader.using.withArgs( [ 'ext.eventLogging', 'schema.MultimediaViewerDuration' ] ).throwsException( 'EventLogging is missing' );
|
|
|
|
promise = durationLogger.loadDependencies();
|
|
|
|
assert.strictEqual( promise.state(), 'rejected', 'Promise is rejected' );
|
|
|
|
// It's necessary to reset the stub, otherwise the original withArgs keeps running alongside the new one
|
|
mw.loader.using.restore();
|
|
this.sandbox.stub( mw.loader, 'using' );
|
|
|
|
mw.loader.using.withArgs( [ 'ext.eventLogging', 'schema.MultimediaViewerDuration' ] ).callsArg( 1 );
|
|
|
|
promise = durationLogger.loadDependencies();
|
|
|
|
assert.strictEqual( promise.state(), 'resolved', 'Promise is resolved' );
|
|
} );
|
|
}( mediaWiki, jQuery ) );
|