Commit graph

633 commits

Author SHA1 Message Date
Translation updater bot 27d5897b05 Localisation updates from https://translatewiki.net.
Change-Id: I9592f4e6f9edddbf1353a5576dd8187efbfdad97
2014-03-11 20:44:50 +00:00
Mark Holmquist 2abb867b76 Don't launch in articles with no text
This is a silly bug.

Change-Id: I5d54cda34d5b7f383c182e41da13dfce141e36bb
2014-03-11 11:53:12 -07:00
jenkins-bot e2966b4079 Merge "Point the navigation E2E test to the right image" 2014-03-11 17:01:05 +00:00
Pau Giner 4ee0e06c6d Use different widths for metadata columns
This change makes the columns on the matadata panel use
a different width (2/3 and 1/3) to emphazize the description
with respect to the more advanced technical details.

Change-Id: I246e3496dd01649f360c1f80b859e2260bb1d87f
2014-03-11 16:05:14 +01:00
Gilles Dubuc 773ed3673b Point the navigation E2E test to the right image
Since we shuffled content around on Lightbox_demo,
the test was trying to read the wrong image.

Change-Id: I4ccaa0a1ab354aa4c19bc3870fb54b0ea11ff086
2014-03-11 16:02:18 +01:00
jenkins-bot 472f56d4ad Merge "Loads of fix-ups to our module definitions" 2014-03-10 21:56:50 +00:00
Translation updater bot 6b0af2fdbb Localisation updates from https://translatewiki.net.
Change-Id: I0ef2c1bfc334c152d23d97c2c05f6b7bf47efd41
2014-03-10 21:27:43 +00:00
Mark Holmquist 1cd9de75d8 Loads of fix-ups to our module definitions
I suspected the performance -> eventlogging dependencies were wrong
and took the opportunity to fix all the things.

Change-Id: Ib97c2f2deb8c9bb3435ea6ce4fee440853381856
2014-03-10 19:14:48 +00:00
jenkins-bot c350658093 Merge "Do not add icons to media viewer image list" 2014-03-10 19:02:27 +00:00
Translation updater bot 3d3afe335a Localisation updates from https://translatewiki.net.
Change-Id: Idf89c7d5b880a4eddc1f5dd7e0060187bf15ff7c
2014-03-09 20:32:49 +00:00
jenkins-bot c1fb20fedb Merge "Add checkered background to make black-on-transparent images visible" 2014-03-08 01:55:06 +00:00
Gergő Tisza 5a3d56f81b Merge MultiLightbox into LightboxInterface
Change-Id: I4363095e0504dd941793ba3addc7ee3cbe835536
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-08 01:14:07 +00:00
Gilles Dubuc c386719cdb Some refactoring to get LightboxInterface closer to a proper UI component
* remove reference to MultimediaViewer
* move hash handling to MultimediaViewer
* make it inherit from Element, remove code duplication
* cleaner event handling life cycle (register on attach,
  unregister on unattach)

Change-Id: Ida8f68dead758a6ae3c429eb85c548af61e46801
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178
2014-03-08 00:26:44 +00:00
Translation updater bot 308a377081 Localisation updates from https://translatewiki.net.
Change-Id: If34dcaae99344ff34b0c081f6972956fa24fdd8c
2014-03-07 21:41:21 +00:00
Mark Holmquist 21549d7547 Do not add icons to media viewer image list
e.g. {{refimprove}} on enwiki - there is an icon of a book that is only
meant to be illustrative on the page. It interferes with the page's image
collection and the flow.

Change-Id: Icd7e5885aaf8b31fffe07bd18cc0feb0f76b848c
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/229
2014-03-06 15:26:25 -08:00
Translation updater bot 3f73ea1076 Localisation updates from https://translatewiki.net.
Change-Id: If549af5b4bbdcfca9d8e0a255638b5a3ae2f03b3
2014-03-06 19:55:24 +00:00
Gergő Tisza d0f76bb160 Add checkered background to make black-on-transparent images visible
Bug: 57620
Change-Id: Ibabbb6d64f9d02ff5b94431a431ebb5222e344d7
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/284
2014-03-05 21:32:34 +00:00
Translation updater bot f51d22e4c3 Localisation updates from https://translatewiki.net.
Change-Id: I5f16fe4c1ed9194e9494486af05f14f410b5799e
2014-03-05 21:11:06 +00:00
jenkins-bot 0fa8f80942 Merge "Get rid of global viewer instance" 2014-03-05 17:52:18 +00:00
jenkins-bot d55e6e7417 Merge "Updated Ruby version from 2.1.0 to 2.1.1" 2014-03-05 10:55:01 +00:00
Gilles Dubuc 8beca0b106 Get rid of global viewer instance
- split event handler setup out of bootstrap and viewer creation
- simplify the tests setup/teardown

Change-Id: Icde1db81efd6191207ba35757192c800ea2d2e91
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278
2014-03-05 02:33:06 +00:00
Gergő Tisza 59bd5e0032 Add tests for promise rejection error logging
Change-Id: I20d0803f211cbc4a7f00b58d015b565ca5c3b49b
Mingle:https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/268
2014-03-05 01:15:28 +00:00
jenkins-bot 44b9fa127a Merge "Fix resize issues (Part III, Fin)" 2014-03-05 00:16:16 +00:00
Aaron Arcos 6b7de4b129 Fix resize issues (Part III, Fin)
Last round of fixes and refactorings regarding resize issues
and the Canvas component:
  * Consolidate all the width calculation logic inside the Canvas component
  * Consolidate image resizing logic in the Canvas component
  * Fix size problem with SVG images
  * Clean up comments and tests

Change-Id: I0198cc1e3a45f7287b9a7494f73a8f158303f886
Bug: 56454
Mingle: 239
2014-03-05 00:14:54 +00:00
Translation updater bot 7317d5a58d Localisation updates from https://translatewiki.net.
Change-Id: I1a9a8f0c413b11f24027cdb2ee350a35a66ac392
2014-03-04 20:44:55 +00:00
Gilles Dubuc d983a13377 Test to check that events are not trapped after the viewer is closed
Also fixes overeager preventDefault in the interface

Change-Id: I5e3b05c8546e24772016b72343e241caa2e6ef0e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274
2014-03-04 09:28:59 +01:00
vikassy 061180fdc1 Updated Ruby version from 2.1.0 to 2.1.1
Bug: 62152
Change-Id: I9c67d6a60294e155b7c75df1862d7a080c0716fc
2014-03-04 08:56:04 +05:30
jenkins-bot a5e566e5db Merge "Add rejection logging to providers" 2014-03-04 01:35:48 +00:00
jenkins-bot 8b1c36d7cd Merge "Add test for clicking prev/next" 2014-03-04 00:50:20 +00:00
jenkins-bot 5f4f62211b Merge "Add events for image views and "use this file"" 2014-03-04 00:44:21 +00:00
Gilles Dubuc b7488716d8 Add events for image views and "use this file"
Change-Id: I9ba37038e41d81bbb8dfa96b8a7766b35d24fa5a
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/54
2014-03-03 16:30:38 -08:00
jenkins-bot 0f75c29fa2 Merge "Network performance measurement CORS improvements" 2014-03-03 21:59:12 +00:00
Gergő Tisza ead038c34f Add rejection logging to providers
Make sure it is easy to debug when one of the promises rejects (and
causes the whole promise chain to fail).

I'm not really happy with this, but still seemed better than adding
the same boilerplate error logging code to each provider one-by-one.

Change-Id: Idd2b638f012ef2ff250e350e2f6a60bb8b81899b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/268
2014-03-03 21:35:01 +00:00
Translation updater bot 60db49293d Localisation updates from https://translatewiki.net.
Change-Id: I921f2f0117394629f90d03c1634dae4c19e149ff
2014-03-03 21:06:55 +00:00
Gilles Dubuc 28cb881cfa Network performance measurement CORS improvements
- Fixes feature check for IE6 and older browsers without native XHR
- Skip crossOrigin attribute for IE11 because it prevents caching

Change-Id: I99d6a3c97edac1af12750d5978a84b6e6f631b14
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232/
2014-03-03 17:17:07 +01:00
Gilles Dubuc a82728ccdb Add test for clicking prev/next
Change-Id: I02653d97500d5a876f142a518d9b53b0d4746aef
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/145
2014-03-03 09:27:23 +01:00
Translation updater bot 590c2f46db Localisation updates from https://translatewiki.net.
Change-Id: Id6279b00b69ad99c88b8cf14447cba701b2cf28b
2014-03-02 20:39:43 +00:00
Gergő Tisza a8a31b1cfc Restore normal behavior on middle-click for site link
Change-Id: I0f13cc97e69fffec64c5dd6c18f08bad44838d19
2014-03-01 00:00:31 +00:00
jenkins-bot 4dad39c117 Merge "Get rid of site-link-click waiting period" 2014-02-28 22:57:13 +00:00
jenkins-bot 31c2b4169f Merge "Fix JS error happening when closing "use this file" dialog" 2014-02-28 17:53:17 +00:00
Pau Giner a3d0a654f7 Adjustments of colours and layout
changes include:
* Aligning license and usage boxes with content above.
* Limit the maximum size for the licensing box when open.
* Adjust font sizes and colours to adjust the alance in the prominence of each part.

Change-Id: I0e4465baaf7a9f7830b95a8d731256d6b4974e17
2014-02-28 14:14:34 +01:00
Gilles Dubuc 9940833928 Get rid of site-link-click waiting period
Change-Id: Ie165cf132ed9f9e326387abba0af6d3780fa894d
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/255
2014-02-28 12:11:18 +01:00
Gilles Dubuc 430ec53d3e Fix JS error happening when closing "use this file" dialog
Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224
2014-02-28 11:52:47 +01:00
Aaron Arcos fedaa553b4 Fix resize issues (Part II)
I was going to stage this but better give you the whole enchilada,
it is not that bad, ;-). This is what I am doing:

- Delete  things that are not used anymore.
- Componentize image ui element (Canvas).

Bug: 56454
Change-Id: Ib5461639a86d9f8e0a150f6d9543a20058d31e00
Mingle: 239
2014-02-28 10:22:21 +01:00
jenkins-bot 3e09524f31 Merge "MediaViewer schema should be a dependency of mmv.bootstrap" 2014-02-28 08:55:26 +00:00
jenkins-bot 374fe5560d Merge "Create fake user when userinfo request fails" 2014-02-28 08:48:25 +00:00
Gergő Tisza 8408c82420 Clear registered events on unattach
Bug: 62033
Change-Id: Ic23a182ac2a74864831796ce493a0c51baa4fe8b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/273
2014-02-28 03:20:40 +00:00
Gergő Tisza 822e129a37 Create fake user when userinfo request fails
Quick and dirty fix for a bug that completely breaks the metadata panel.
Should be refactored later (for a ForeignDbRepo, a missing user is
normal, for anything else it should still be treated as an error
condition, although maybe not with a rejection).

Bug: 62019
Change-Id: I433ae2bd1334593d9c5bfe0272ce7207f3fdf723
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/267
2014-02-28 03:06:23 +00:00
Gergő Tisza 799e663c0b Remove multilightbox directory from JSDuck config
Merging multilightbox into mmv apparently broke our JSDuck script
(not quite sure why it did not give an error at that time), fixing.

Change-Id: Ib83008d1aea33974c93fbfb7473b2f17ab688050
2014-02-28 03:00:20 +00:00
Gilles Dubuc 812341a549 MediaViewer schema should be a dependency of mmv.bootstrap
For the thumbnail-link-click and enlarge-link-click events

Change-Id: I8fa0d286997a27b46d2d0506513254694c1927ec
2014-02-27 23:36:39 +00:00