wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-29 18:34:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
540 commits 12 branches 22 tags 39 MiB
Commit graph

121 commits

Author SHA1 Message Date
Gilles Dubuc 4d1ba92fc6 Improve the test coverage to also check prev/next scroll 
This test should now cover all the scenarios fixed in my
preceding bugfix

Bug: 59861
Change-Id: I2df6c2dac8e31186c2c976fd890aac38143391da
 2014-01-10 10:26:25 +01:00
Gilles Dubuc 380612c4bf Only scroll to the top when opening the lightbox 
Not when going prev/next.
The saved position feature was probably broken as well if you
happened to press prev/next.
This was my mistake for not noticing that attach() runs on
prev/next.

Bug: 59861
Change-Id: Ic6ff4b15a54178fb5d38640317650f5676293083
 2014-01-09 18:11:20 +01:00
Mark Holmquist 5949748ed6 Load images normally 
Removes the spinner, loads images line-by-line. Supposedly more
expected for most users.

Change-Id: Ia5fba4c8d8af681c0a95e43d34014b07e33941c4
 2014-01-08 23:42:06 +00:00
Mark Holmquist da86c5f750 Version our EL profiling 
This is just a clever way of marking messages as being useful again -
this way I don't need to go through the hassle of deleting old data.

Change-Id: I6a0574eaae063014340484ffd2552f8118abb939
 2014-01-08 09:35:35 -08:00
Mark Holmquist 3547f17960 Fix painful bug in eventlogging code 
Change-Id: I3026aadcb28e7a8325137214512163558cccf2db
 2014-01-07 17:27:28 -08:00
Mark Holmquist 0000664d80 Add tests for the link construction code 
Always a good plan.

Also refactored a little bit, but not too much. Juuuust right.

Bug: 57842
Change-Id: I787c3770e41474edafb2fd02e01fec2c7c2b5ed6
 2013-12-30 21:51:35 +00:00
Mark Holmquist f96d5498ca Introduce image size bucketing 
See the conversation on mediawiki.org:
http://ur1.ca/g14jv

We're trying this out as one option in combatting slow thumbnail load
times. It may or may not work very well.

Bug: 56695
Change-Id: If1211fdff87c0782c7355d654415bfd29d63d84a
 2013-12-27 13:39:31 -08:00
Aaron Arcos ffc8f4948d Add smoke test to class mw.LightboxInterface. 
- Moved tests that were meant for LightboxInterface objects.
  - Fixed space naming issues.

Change-Id: Ib83904eab5fa542330ea559d420efa5f1de8c3eb
 2013-12-13 10:39:13 -08:00
Mark Holmquist e68e60f464 Fix another event handler bug 
No need to register the event until the interface actually loads...

Change-Id: I1bddb5478410e1868195d63762d913a07e50c0ed
 2013-12-12 15:30:11 -08:00
Mark Holmquist 4e29e6cd01 Fix fileLink initialisation 
I guess this got torn out along the way, but I'm pretty sure this is
what I meant to do - initialize the image object with the thumbnail
URL and then replace it later.

+tests for the failure.

Change-Id: I20ef4e87c6b4b6706ad586f2aa5796736895c780
 2013-12-10 11:56:54 -08:00
jenkins-bot 9b02f8ebe4 Merge "Smoke test for MultiLightbox class." 2013-12-10 02:20:30 +00:00
Aaron Arcos 83aa9c6a6b Smoke test for MultiLightbox class. 
Change-Id: Iab8a80d842d4252a68bca2a4de92acccd835c978
 2013-12-09 18:18:42 -08:00
jenkins-bot 2cc5279e06 Merge "Move clearInterface things to mw.LightboxInterface" 2013-12-10 01:41:18 +00:00
jenkins-bot 8695964ea4 Merge "Add performance logging" 2013-12-10 01:07:39 +00:00
Mark Holmquist f144a0a403 Add performance logging 
Change-Id: If6e3aec4b2547fa9768eaaf5387729ed2b427ab1
 2013-12-09 17:06:01 -08:00
Aaron Arcos 5fd02ad8f2 Create smoke tests for the LightboxImage class. 
Change-Id: I0e5cec7bbcc4140fc6b74e3cf39c0a7b08891194
 2013-12-10 00:59:37 +00:00
Mark Holmquist 1411110b3d Move clearInterface things to mw.LightboxInterface 
Also fixes a bug where we didn't clear our arrow key listeners, and VE
would sometimes see lightbox loads accidentally.

+tests for .empty()

Bug: 58107
Change-Id: Ica8326891b2da1f94966dbe72c28e878934ca64f
 2013-12-09 16:33:34 -08:00
Aaron Arcos c38fa2fbfe Fix resize listener leak problem. 
Third try, merged latest changes and added a test.
Run loading test against a wikipedia.org image.

Change-Id: I4e5a137e0f6dbedc45ec2c8393590919e23a26be
 2013-12-09 20:45:47 +00:00
Aaron Arcos 2baf271def Smoke tests for LightboxInterface class. 
Change-Id: I5ecefc75c85e14104e951fc71556f2d06e612f71
 2013-12-04 17:16:00 -08:00
Aaron Arcos add9a9b435 Add a very simple resize test 
Add test to verify that in case of a resize event no image
replacement takes place when api data is empty/undefined.

Change-Id: I2a880ce4b2e6c158763b1473f6a9f751922187b0
 2013-12-03 23:20:51 +00:00
Aaron Arcos bed5c07039 Add tests to MultimediaViewer 
These are just smoke tests. I will add more in coming versions of this change.
Consolidated various cases in one tests. Added tests to validate for legit clicks.

Based on Idfbec829399ff6969cd01be3c13a8ed7a66a1fef

Change-Id: I366c7af9a5cf43361d8293183c9da117bc5d4971
 2013-12-02 15:19:12 -08:00