Gergő Tisza
d7706d7cb0
Fix fullscreen bug where image was replaced with self
...
Change-Id: I81dcadae96a778559564a786a5753323fb802b7c
2014-02-12 01:55:37 +00:00
Gergő Tisza
f4ab39df1e
Fix runaway prev/next issue
...
Prev/next handlers were multiplying after every click.
Change-Id: I1e21b2711cc08a6edbbd26ec844e966f7582b3c8
2014-02-11 01:12:31 +00:00
Pau Giner
cc9e2daf2f
Icons for share link and assessments
...
Added SVG assets for link (normal and hover states) and the
"assessments" trophy icon.
Change-Id: I5b5673fb8767628922c6b1ccbe658a0b3df56e0f
2014-02-10 21:48:14 +00:00
Gilles Dubuc
b9a822249d
Fix defullscreen icon duplicate CSS
...
This one slipped through the cracks again
Change-Id: If4b1e8ee3adcef6b388f3d431d6629fe7b452b81
2014-02-10 10:12:34 +01:00
Gilles Dubuc
6e896c05cc
Fix fullscreen and close icons
...
Some styles got mangled when 111372 landed
Change-Id: I44fa82ba0b65152b01872ba58f8a7e84c6106ca5
2014-02-10 10:04:50 +01:00
Mark Holmquist
a62410616d
Refactor button things into a separate class
...
https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124
Change-Id: Ib4b54164bccbe17e42b223880179531e8d9e6123
2014-02-10 09:40:50 +01:00
jenkins-bot
698f677cd3
Merge "Refactor thumbnail size calculation"
2014-02-10 08:11:33 +00:00
Gergő Tisza
06cc6cca1a
Refactor thumbnail size calculation
...
* moves generic logic into ThumbnailSizeCalculator class
* moves UI-specific logic into interface class
* fixes bug where non-bucketed sizes were served on devices with
non-standard pixel density
* fixes bug where bucketed size was compared to css size instead of screen size
for resizing
Change-Id: I8ba3380b74fcc8fb0a6ecc3f3140627411851ad0
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/196
2014-02-08 01:27:27 +00:00
Gergő Tisza
65129f9ed5
Fix perf log type for userinfo
...
Change-Id: I296a3c53005de7c27b6083662fa498f06254e946
2014-02-07 21:26:27 +00:00
Gilles Dubuc
e74fc33e89
Track detailed content loading network performance
...
Leverages the W3C Navigation Timing API when available
Change-Id: Ief1d327d1bd8928bf5f2bf0bd4c7141a0a608a53
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126
2014-02-07 19:37:22 +00:00
Gilles Dubuc
57434b5812
Refactor panel-related things into another class
...
mmv.lightboxinterface was getting way too clunky.
https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124
Change-Id: Ie3a604b532ee853f9df673cc4d38c2c7594bdefa
2014-02-07 10:09:08 -08:00
jenkins-bot
6b22712362
Merge "Some more metadata fetch reorganizing to get rid of the dependency on UI state"
2014-02-07 09:15:21 +00:00
jenkins-bot
3f9becc01b
Merge "Add Thumbnail model"
2014-02-07 09:12:15 +00:00
Gilles Dubuc
e3a1bf93ba
Show main metadata in fullscreen
...
Yay mostly-CSS work
Change-Id: Ica8dc95a8c56b56c0ee00a16b1cfbf923de04424
2014-02-07 02:43:43 +00:00
Gergő Tisza
e382095c4a
Some more metadata fetch reorganizing to get rid of the dependency on UI state
...
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155
Change-Id: I56cfa404d148d760088baa26900db04294ab4e91
2014-02-07 01:46:26 +00:00
Gergő Tisza
e33f2d263c
Add Thumbnail model
...
Also refactor size calculation a bit - I found target/requested
harder to remember.
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155
Change-Id: I4781cdd7004e9a8e36875c152e1d3a335a55b7d7
2014-02-07 01:46:26 +00:00
jenkins-bot
d1e966e903
Merge "Hide the fullscren button when fullscreen is unavailable"
2014-02-06 22:19:17 +00:00
Gilles Dubuc
4e85f31b27
Hide the fullscren button when fullscreen is unavailable
...
Change-Id: I72cff940cee1ad83f6bacfffdcfb9fdd0f16abcc
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152
2014-02-06 14:02:52 -08:00
Gergő Tisza
289ad22b19
Fix JSDuck
...
* update paths
* make generate script return failure state on failure
* fix some issues so that it does not actually fail
Change-Id: Idd42e0d8e333c461091079aa1150b1b435e6360c
2014-02-06 19:10:07 +00:00
jenkins-bot
ed912adff1
Merge "Userinfo provider"
2014-02-06 13:56:15 +00:00
Gergő Tisza
26d001ac6f
Fix repoinfo loading bug
...
Change-Id: I21741a60b88f1e34faf30ef591f3e44ff4703d94
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/190
2014-02-06 00:59:43 +00:00
Gergő Tisza
b013ddbefe
Userinfo provider
...
* userinfo api requests are cached now
* we use jsonp only if we have to (makes gender api calls measurable on WMF wikis)
* all API calls use providers now, provider.Api constructor can be used to
wrap mw.Api with metrics
Does not return a proper model, and gender API calls are not preloaded together
with the rest of the calls. Maybe next time.
Change-Id: I9b3ea73c65eef57e160ac8636d9e45d349150884
2014-02-06 00:37:39 +00:00
jenkins-bot
ec32d1e81a
Merge "Hide the controls after some time when in fullscreen mode"
2014-02-05 20:13:25 +00:00
jenkins-bot
929e287637
Merge "Revert "Exit Lightbox when clicked on backdrop""
2014-02-05 18:14:24 +00:00
MarkTraceur
3b71fecee5
Revert "Exit Lightbox when clicked on backdrop"
...
This reverts commit 4280dd8b83
.
After product discussion, we decided this was a bad idea. Sorry, Tony.
Change-Id: Ib59d75132c2a301f83d080b0f963e2a9d8b9b277
2014-02-05 18:12:43 +00:00
Gilles Dubuc
3dd716a3f2
Hide the controls after some time when in fullscreen mode
...
Also removes side-effects from several tests
Change-Id: Ifdc978f56f8c4caafadc8b192756645a9378f58a
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/150
2014-02-05 10:27:10 +01:00
jenkins-bot
923a117304
Merge "Use LESS instead of CSS"
2014-02-05 02:20:40 +00:00
Gergő Tisza
1ff0ac60cd
Fix merge problem with categories
...
Change-Id: I628bffeb4cac16cf50def6d5562fb9e2b9fa8933
2014-02-05 01:46:55 +00:00
jenkins-bot
af1c2cbeee
Merge "Add provider to for actual image loading"
2014-02-05 00:15:56 +00:00
jenkins-bot
cba179e79a
Merge "Replace old API code with providers + fix a few provider bugs"
2014-02-05 00:15:55 +00:00
jenkins-bot
97e29b9e00
Merge "Add imageinfo, thumbnail info, repoinfo provider"
2014-02-05 00:14:22 +00:00
Gergő Tisza
6068ffd58d
Add provider to for actual image loading
...
Change-Id: I9ca9bce37c97648afa07db9f004138a791c74e65
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123
2014-02-05 00:02:28 +00:00
Gergő Tisza
40d1a2508a
Replace old API code with providers + fix a few provider bugs
...
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123
Change-Id: Id7952f0a0eafa34d7c8691c63c2daccff2eea64a
2014-02-04 23:52:02 +00:00
Gergő Tisza
85a37d0e14
Add imageinfo, thumbnail info, repoinfo provider
...
Change-Id: I80ffec39ee6c9e0ea0b37be2fc48315063b5ff8a
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123
2014-02-04 23:46:02 +00:00
Mark Holmquist
9d043e7ddc
Fix categories empty method
...
+test
Change-Id: I16f19dde713709b0cf8631cb1bf0ceee6ca438a7
2014-02-04 10:10:53 -08:00
Mark Holmquist
5d61b69fbd
Use LESS instead of CSS
...
Because we're that cool of a startup apparently
Also because organization and easy code manipulation.
Change-Id: I81ca302b6848f83034f7efed2443757bb045c4f1
2014-02-03 15:02:32 -08:00
Mark Holmquist
b860ccf1b9
Move UI things into mmv/ui/
...
Change-Id: I39800ba45abe4ff1cb21c41062f8a1012eaca203
2014-02-03 14:46:04 -08:00
Gilles Dubuc
d34fec4ff2
Add categories to the interface
...
Also move some things around a liiiittle bit. Not too much.
Change-Id: I7a5b8d900f5173fa20142d205e4992361b9e81a3
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41
2014-02-03 15:09:42 +01:00
jenkins-bot
9f0641c214
Merge "Make mmv handle urlencoded hashes"
2014-02-03 10:44:42 +00:00
jenkins-bot
8024d98e71
Merge "Move providers into their own subdirectory"
2014-02-03 08:45:02 +00:00
Gilles Dubuc
67fa053687
Make mmv handle urlencoded hashes
...
Change-Id: Id05806be4586a3d6f04b92ace2c8195b8de016bc
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/153
2014-02-03 09:32:38 +01:00
tonythomas01
4280dd8b83
Exit Lightbox when clicked on backdrop
...
Now,The lightbox interface will exit when the user clicks anywhere on
the image backdrop, which is convenient
Bug: 56402
Change-Id: I261976c81b86bf029412dff2993ee7b8c6d347e1
2014-02-02 16:23:25 +05:30
Gergő Tisza
e0edec21b2
Move providers into their own subdirectory
...
Also refactor MultimediaViewer.php a bit to get rid of all the globals.
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123
Change-Id: Ieca4263ecc7652dc6bc36db63b99d3813c4653e4
2014-02-01 03:49:30 +00:00
jenkins-bot
1ae5cc10f7
Merge "Fix globalusage link"
2014-01-31 22:41:12 +00:00
jenkins-bot
5d7f86bc86
Merge "Place the metadata correctly before opening the lightbox"
2014-01-31 20:53:51 +00:00
Gergő Tisza
416f04bf3b
Fix globalusage link
...
Change-Id: Iec3aeef2e807fbc65212dbcb156ae5d9bd39bb9c
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44
2014-01-31 18:46:20 +00:00
Gilles Dubuc
b9eecfed28
Place the metadata correctly before opening the lightbox
...
The issue was happening because the metadata div
was placed without waiting for dom load. Also, the code
ignored the fact that the window size might change
between page load and when the lightbox is open.
Change-Id: Ib44720a7f989803b3f59aebcd33e94f610f51325
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/141
2014-01-31 11:35:50 +01:00
Gilles Dubuc
5d47d1da3d
Fix the "view all uses" link when there are both local and global results
...
The code was incorrectly adding the link to the first section
no matter what. This wasn't caught by the existing assertions,
so these are being improved as well.
Change-Id: I4dcbf44b504bd4cb875b4058fe5604f2a3c871b7
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44
2014-01-31 09:30:26 +01:00
Gilles Dubuc
ec29c88a6e
Swap position of caption and description
...
The design requested that the caption is displayed above the
description, not below it.
Change-Id: Ie4bd10e04b65aeaa4e367c59d3ddef790bee1e2b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/120
2014-01-31 04:04:59 +00:00
Gilles Dubuc
8bd1786ead
Revert "Replace $.fn.msg calls by mw.message"
...
This reverts commit 1804f98ee7
.
Turned out to be a caching issue, $.fn.msg() works fine
Change-Id: I087bf5cc0bbe89fdc80c64c015218a5ff9a24ee7
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/157
2014-01-30 14:11:23 +01:00