Commit graph

2961 commits

Author SHA1 Message Date
Ebrahim Byagowi 4f20e53fdc Make broken middle click during refactor work again
Change-Id: Ie4c40accd1ac21c548d4ab899ffdd6c8f95af0a5
2013-12-16 18:31:02 +00:00
Translation updater bot 7538ce87b2 Localisation updates from https://translatewiki.net.
Change-Id: I9f0b809ed8bb884e5d02cf86f782197e7702d7ff
2013-12-14 20:52:49 +00:00
Translation updater bot d98824f0a8 Localisation updates from https://translatewiki.net.
Change-Id: Ie966a7edb3560efdfa2931f501bdde535e364bc5
2013-12-13 20:14:24 +00:00
Aaron Arcos ffc8f4948d Add smoke test to class mw.LightboxInterface.
- Moved tests that were meant for LightboxInterface objects.
  - Fixed space naming issues.

Change-Id: Ib83904eab5fa542330ea559d420efa5f1de8c3eb
2013-12-13 10:39:13 -08:00
Mark Holmquist e68e60f464 Fix another event handler bug
No need to register the event until the interface actually loads...

Change-Id: I1bddb5478410e1868195d63762d913a07e50c0ed
2013-12-12 15:30:11 -08:00
Translation updater bot 794b4da238 Localisation updates from https://translatewiki.net.
Change-Id: Ic1c70e305f1ab117547e73c389c4481b90d5d581
2013-12-12 21:16:22 +00:00
Mark Holmquist 76532a156a Fixes for the scroll-up affordance
Fix click listener, add cursor: move

Change-Id: I1c51702d4c7dd63d64026747c5c75d2dfff14c58
2013-12-10 15:22:40 -08:00
Mark Holmquist 32796a3578 Extend the post-image div height for the drag affordance
Forgot to update the size here, so there's a weird break in the div
right now.

Change-Id: Iea46de723a2ea9a620a07a150560901c81ea9620
2013-12-10 15:02:22 -08:00
Translation updater bot 0fca63132c Localisation updates from https://translatewiki.net.
Change-Id: Iced973b60c4135bf98ea324480915a992c678c9d
2013-12-10 20:43:27 +00:00
Mark Holmquist 4e29e6cd01 Fix fileLink initialisation
I guess this got torn out along the way, but I'm pretty sure this is
what I meant to do - initialize the image object with the thumbnail
URL and then replace it later.

+tests for the failure.

Change-Id: I20ef4e87c6b4b6706ad586f2aa5796736895c780
2013-12-10 11:56:54 -08:00
jenkins-bot 9b02f8ebe4 Merge "Smoke test for MultiLightbox class." 2013-12-10 02:20:30 +00:00
Aaron Arcos 83aa9c6a6b Smoke test for MultiLightbox class.
Change-Id: Iab8a80d842d4252a68bca2a4de92acccd835c978
2013-12-09 18:18:42 -08:00
jenkins-bot 2cc5279e06 Merge "Move clearInterface things to mw.LightboxInterface" 2013-12-10 01:41:18 +00:00
jenkins-bot 8695964ea4 Merge "Add performance logging" 2013-12-10 01:07:39 +00:00
Mark Holmquist f144a0a403 Add performance logging
Change-Id: If6e3aec4b2547fa9768eaaf5387729ed2b427ab1
2013-12-09 17:06:01 -08:00
Aaron Arcos 5fd02ad8f2 Create smoke tests for the LightboxImage class.
Change-Id: I0e5cec7bbcc4140fc6b74e3cf39c0a7b08891194
2013-12-10 00:59:37 +00:00
Mark Holmquist 1411110b3d Move clearInterface things to mw.LightboxInterface
Also fixes a bug where we didn't clear our arrow key listeners, and VE
would sometimes see lightbox loads accidentally.

+tests for .empty()

Bug: 58107
Change-Id: Ica8326891b2da1f94966dbe72c28e878934ca64f
2013-12-09 16:33:34 -08:00
Translation updater bot 8a3e33b61c Localisation updates from https://translatewiki.net.
Change-Id: I730a3c082f47ed58c7663526ad376a427ca35920
2013-12-09 21:25:32 +00:00
Aaron Arcos c38fa2fbfe Fix resize listener leak problem.
Third try, merged latest changes and added a test.
Run loading test against a wikipedia.org image.

Change-Id: I4e5a137e0f6dbedc45ec2c8393590919e23a26be
2013-12-09 20:45:47 +00:00
Translation updater bot ec01c2a387 Localisation updates from https://translatewiki.net.
Change-Id: Iba7d7e3d88e3582dbf364c4e07a9c811ca1c2dcc
2013-12-08 20:26:17 +00:00
vldandrew 1d667263f0 Corrected page link and problems if the link is to a remote server
Additionally some other problems were corrected.

Bug: 56787
Change-Id: I01e7dc9938b52a8f809740e582d61b1e0131916d
2013-12-05 22:06:27 +02:00
Mark Holmquist 676d1ace46 Remove oojs hack
Unnecessary now that Ifea6405c2 has landed in core 

Change-Id: I4ad8238410c01308e37aa9b61cb4e8c84817801b
2013-12-05 02:47:09 +00:00
Aaron Arcos 2baf271def Smoke tests for LightboxInterface class.
Change-Id: I5ecefc75c85e14104e951fc71556f2d06e612f71
2013-12-04 17:16:00 -08:00
MatmaRex 516d0168c3 File usage dialog: Only reselect on focus, not on every click
Makes it possible to view the entire content of the box without copying
the text somewhere else, or to only copy a part of the text.

Change-Id: I8ed8beaadf7e515e57ee4f11bdaef9672c980f5b
2013-12-05 00:26:28 +00:00
Dereckson 032ea9d958 Make importml.sh less Linux-centric, more UNIX-agnostic
Bash could be located at different places on different OSes.

Bug: 57470
Change-Id: I8db54fe4b2b91b9b2f1a47756262e848cff39afe
2013-12-05 00:19:02 +00:00
jenkins-bot 68c14b7ef4 Merge "Add a very simple resize test" 2013-12-04 21:17:52 +00:00
Aaron Arcos add9a9b435 Add a very simple resize test
Add test to verify that in case of a resize event no image
replacement takes place when api data is empty/undefined.

Change-Id: I2a880ce4b2e6c158763b1473f6a9f751922187b0
2013-12-03 23:20:51 +00:00
Translation updater bot c6bd0ddabc Localisation updates from https://translatewiki.net.
Change-Id: I028eb5b51f05f8bde068f0b139f96f431c774632
2013-12-03 20:49:45 +00:00
jenkins-bot b704f294f8 Merge "Add tests to MultimediaViewer" 2013-12-02 23:27:42 +00:00
Aaron Arcos bed5c07039 Add tests to MultimediaViewer
These are just smoke tests. I will add more in coming versions of this change.
Consolidated various cases in one tests. Added tests to validate for legit clicks.

Based on Idfbec829399ff6969cd01be3c13a8ed7a66a1fef

Change-Id: I366c7af9a5cf43361d8293183c9da117bc5d4971
2013-12-02 15:19:12 -08:00
jenkins-bot 07a937571d Merge "jshint config and fixes, FINALLY" 2013-12-02 22:00:05 +00:00
Mark Holmquist 013752ccb2 Fix a bloody silly file usage dialog bug
Return false from the click handler so it doesn't fire a popstate event
because the link is to "#"

Change-Id: I08a49e1b664dc4e6b01c1f479209428578d36843
2013-12-02 13:11:26 -08:00
Mark Holmquist 198bf44c1a jshint config and fixes, FINALLY
Every patch we've submitted up until now has been magically very good
at jshint, because I'm appropriately OCD about it, but now we can actually
point at results.

Also we'll enable voting very soon.

Change-Id: I028fa78a47778c8a4050f6b77623c6bfdc4f9c5b
2013-12-02 12:50:34 -08:00
Translation updater bot 5ee6ab7f25 Localisation updates from https://translatewiki.net.
Change-Id: I615d0b03bcabb9cc9eb74984a24cde9c88c3b3cc
2013-12-02 20:39:28 +00:00
Mark Holmquist 5d916b9a45 Bump version number
The UI change is enough that I want to make this more bigger.

Change-Id: I6586d327a772dc4128fbe9354fd819f83a3fdcd8
2013-12-02 18:41:35 +00:00
Translation updater bot f47e1a0b39 Localisation updates from https://translatewiki.net.
Change-Id: I95388f8784049ad3793cff4978854390241c4e7c
2013-12-01 19:56:21 +00:00
jenkins-bot fa70bdcb74 Merge "Auto-ellipsis for filename field Bug: 56113" 2013-11-30 19:00:40 +00:00
Yaroslav Melnychuk e632d32b65 Auto-ellipsis for filename field
Bug: 56113

Change-Id: I84e28fe8fefd90c46c2bd9d2d7a25c472d8f26d3
2013-11-30 20:53:42 +02:00
jenkins-bot a36622185f Merge "Prevent multiple "Use this file" windows" 2013-11-29 21:19:13 +00:00
theopolisme 464733af21 Prevent multiple "Use this file" windows
Bug: 56501
Change-Id: Ic86feacb881d3b559d32f33fba508121f8b9ec27
2013-11-29 14:36:21 -06:00
Translation updater bot 32700e6dea Localisation updates from https://translatewiki.net.
Change-Id: If33671f824d7b699f7e258aafd3bde2288bc6418
2013-11-29 19:30:23 +00:00
MatmaRex 1ed2804863 Replace weird .select() reimplementation
Browsers have had a .select() method on <input>s and <textarea>s
since the dawn of the web.

Change-Id: Ib35415115291086300494ef1c6cb3063cd6b8e94
2013-11-28 21:31:04 +00:00
jenkins-bot 3ed21410a6 Merge "Fixes the UI refactor" 2013-11-28 21:30:27 +00:00
vldandrew 53ef9ed86d Fixes the UI refactor
Id44fea9008adb391817250c2897693f45bead717 pushed a bunch of stuff into the
subclass of LightboxInterface, but forgot to change the calls to "this" in
the dialog function to be sane.

Bug: 57678
Change-Id: I998240411b0970d43d401f739b383c0289163760
2013-11-28 13:26:31 -08:00
MatmaRex d47778b501 Kill !Boolean( variable )
That's an impressive abomination. :)

Change-Id: I1e3d64add5921924050ad97bfe2b1e6f6b1d46b1
2013-11-28 22:07:32 +01:00
Translation updater bot 53b07bedb3 Localisation updates from https://translatewiki.net.
Change-Id: Ie197b9025152031f6f2e4f52b1e71d099ae53f15
2013-11-27 19:27:21 +00:00
jenkins-bot 6687c58ae4 Merge "Previous and next functionality!" 2013-11-26 22:03:33 +00:00
jenkins-bot c0a6987e95 Merge "Push history state to support links to media viewer" 2013-11-26 21:35:21 +00:00
Mark Holmquist 85eb742277 Previous and next functionality!
Adds buttons on the side, disabled at the start and end of the list of
images, that let you browse through the images on the page!

Also arrow keys!

EXCITING!

Change-Id: Ie514cd4b16bdee8a384a89d4bd1d755a24c5cdb4
2013-11-26 21:10:16 +00:00
Mark Holmquist a4c0617b1f Push history state to support links to media viewer
Also listen for popState events so users can use their browser's back
functionality to close the lightbox or go backwards, etc.

Bug: 56469
Change-Id: Id44fea9008adb391817250c2897693f45bead717
2013-11-26 13:09:54 -08:00