wikimedia/mediawiki-extensions-MultimediaViewer
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer synced 2024-11-17 12:53:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
1169 commits 280 branches 5 tags 37 MiB
Commit graph

1169 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gilles Dubuc 4d1ba92fc6 Improve the test coverage to also check prev/next scroll 
This test should now cover all the scenarios fixed in my
preceding bugfix

Bug: 59861
Change-Id: I2df6c2dac8e31186c2c976fd890aac38143391da
 2014-01-10 10:26:25 +01:00
Mark Holmquist ae50fad5f5 Use promises 
Uses promises in the entirety of fetchImageInfo. Also removes the old
fetchRepoInfo method which was unused (basically) anyway.

Change-Id: Ie7f9a27822ecb893b99dbd755c6199769f2e6784
 2014-01-09 16:52:18 -08:00
Translation updater bot 0e160cb8bb Localisation updates from https://translatewiki.net. 
Change-Id: I6a9ed704451f43e1fa5a280fbc667384939171b4
 2014-01-09 20:28:45 +00:00
jenkins-bot cc8977de31 Merge "Fix metadata loading" 2014-01-09 18:33:32 +00:00
Gilles Dubuc 380612c4bf Only scroll to the top when opening the lightbox 
Not when going prev/next.
The saved position feature was probably broken as well if you
happened to press prev/next.
This was my mistake for not noticing that attach() runs on
prev/next.

Bug: 59861
Change-Id: Ic6ff4b15a54178fb5d38640317650f5676293083
 2014-01-09 18:11:20 +01:00
Gergő Tisza a91058adc4 Fix metadata loading 
fetchImageInfo() was used to load different property sets,
but had a single cache, so sometimes the results with less properties
overwrote the ones with more.

This is a dirty hack to deal with that. I will revisit once we
use promises.

Bug: 59817
Change-Id: I4f375bcc4e6fcfdb3e3fe7a30fc90a8fd44164c3
 2014-01-09 02:30:09 +00:00
jenkins-bot 0f719f999d Merge "Load images normally" 2014-01-09 00:58:00 +00:00
Mark Holmquist 5949748ed6 Load images normally 
Removes the spinner, loads images line-by-line. Supposedly more
expected for most users.

Change-Id: Ia5fba4c8d8af681c0a95e43d34014b07e33941c4
 2014-01-08 23:42:06 +00:00
Translation updater bot 2441856288 Localisation updates from https://translatewiki.net. 
Change-Id: Ie6c47052de9d1c690c678ff32e0aeaed9b516ada
 2014-01-08 20:34:34 +00:00
jenkins-bot 666f2b3af3 Merge "Make the behavior of the lightbox more consistent with scroll" 2014-01-08 19:36:16 +00:00
Mark Holmquist da86c5f750 Version our EL profiling 
This is just a clever way of marking messages as being useful again -
this way I don't need to go through the hassle of deleting old data.

Change-Id: I6a0574eaae063014340484ffd2552f8118abb939
 2014-01-08 09:35:35 -08:00
jenkins-bot 65db71572c Merge "Fix painful bug in eventlogging code" 2014-01-08 17:18:28 +00:00
Gilles Dubuc 26735d8bd1 Make the behavior of the lightbox more consistent with scroll 
Makes sure that the advanced description is out of view when
the lightbox opens.
Remembers the scrollTop position that was set when the lightbox
opens, in order to restore it when it closes.

Change-Id: I534f7d718528d1e5a4911c68a524eb96cadeae90
 2014-01-08 17:05:05 +01:00
Pau Giner 4c87c93d91 Use chevron for panel opening affordance 
replaces the drag image with a chevron and adds CSS classes to
adjust the opacity changes.

Change-Id: I689c7ff3c952f1ec2b8b16258dc44b1ad095f4fa
 2014-01-08 14:41:44 +01:00
Gilles Dubuc f3fd143c8a Move the arrows and the close/fullscreen button 
Looks drastic at first, but grows on you.
I based this on an extreme, the firefox inner scrollbar.
Which is huge when hovered.
I kind of wish the close button was a bit bigger, though.

Change-Id: I2f47280c4e7c4bff299149de24741e3381f0b5e9
 2014-01-08 11:33:56 +01:00
Mark Holmquist 3547f17960 Fix painful bug in eventlogging code 
Change-Id: I3026aadcb28e7a8325137214512163558cccf2db
 2014-01-07 17:27:28 -08:00
Translation updater bot 9b62de0e57 Localisation updates from https://translatewiki.net. 
Change-Id: I1271286624379479f02367bb6199bd960bbf2fab
 2014-01-07 20:45:10 +00:00
jenkins-bot 055ccb8c27 Merge "Styling fixes for media panel" 2014-01-07 19:37:44 +00:00
Pau Giner 797a2d90e0 Styling fixes for media panel 
Color and position adjustments for panel elements:
* Background
* Line separation
* License text

Change-Id: Ib8c5557503ec6a28b9761220a251cf4ac4742182
 2014-01-07 20:05:29 +01:00
jenkins-bot 5a58b12b7b Merge "Added No description message" 2014-01-07 16:00:21 +00:00
Mark Holmquist 896a7b4c40 Animate the metadata div to show the user it's there 
"Hey! Scroll down! Yeah, you!"

Also fixes the previous arrow button, which got disappeared at some point

Bug: 58431
Change-Id: I98676ee921dc1d3b5780046eabec7415c05f8f4f
 2014-01-06 18:29:37 -08:00
Mark Holmquist 27e2db75f9 Make sure the post-image div is always the same height 
Otherwise it flickers and is weird and stuff.

Bug: 58431
Change-Id: Ic7d7d0bededede9b3cedb4ebd8efdcfae2209127
 2014-01-06 17:24:45 -08:00
Mark Holmquist c17be3b124 Fixed positioning for the image 
Fix, so we can work on animating the metadata div next.

Bug: 58431
Change-Id: Ic62711f657daaa36bb82e32e98a0abee421864fc
 2014-01-06 17:14:51 -08:00
jenkins-bot 85a0474997 Merge "Bigger click targets for next and previous" 2014-01-06 23:38:02 +00:00
jenkins-bot e1efb5d16e Merge "Make the imageinfo fetch more generic" 2014-01-06 23:32:22 +00:00
jenkins-bot 1b94099d7f Merge "Fix issues pointed out by aarcos" 2014-01-06 23:07:39 +00:00
Mark Holmquist 7ec7172964 Make the imageinfo fetch more generic 
Also use it in the resize method

Change-Id: I0ee2fcf7daf4a2492981c8311f3a3fd7054d6ae2
 2014-01-06 15:07:03 -08:00
Mark Holmquist 85d08e1d27 Fix issues pointed out by aarcos 
See https://gerrit.wikimedia.org/r/#/c/95282/10/resources/ext.multimediaViewer/ext.multimediaViewer.js

A few issues with code being in two places; should probably refactor but
would prefer to get out a fix and refactor a little later.

Change-Id: Id74a01e177aeb09fe34416e7fd14759df58fda32
 2014-01-06 15:02:51 -08:00
jenkins-bot e0e768f4cd Merge "Fix image bucketing resize engine" 2014-01-06 22:27:40 +00:00
apsdehal f9ee5ec0a0 Added No description message 
'No description available' message has been added when description for the
given file is not available.

Bug: 56446
Change-Id: Ie239e5cd0d1b645ed149ea1ecc80197b0e84bc34
 2014-01-07 01:57:08 +05:30
Translation updater bot d883ffa3c9 Localisation updates from https://translatewiki.net. 
Change-Id: Iae816883bccb723dabd466f278c2d7091aabd47e
 2014-01-06 20:06:37 +00:00
Mark Holmquist f2f36376cf Fix image bucketing resize engine 
targetWidth was switched to even if the image was way smaller than it,
fixed by only changing to it if the image is too big (too-small images
should never be stretched anyway).

Change-Id: I9e3e6a358e53dbed988b730205a8afec1dbf3483
 2014-01-06 11:32:40 -08:00
apsdehal 132049976a Changed 'lightbox' to 'fullscreen interface' in i18n 
Bug: 56742
Change-Id: I451ab006b136983c052ad6961aeab38e5e326b9b
 2014-01-06 08:00:50 +00:00
Translation updater bot 2a464534e3 Localisation updates from https://translatewiki.net. 
Change-Id: Icf02a5429ef0807153b27b084494b0905845f556
 2014-01-05 20:12:05 +00:00
Translation updater bot dcde974393 Localisation updates from https://translatewiki.net. 
Change-Id: I1023f95e7ac84dc1d073782b950d814c7fe1e223
 2014-01-03 20:41:13 +00:00
Translation updater bot 3cd213a072 Localisation updates from https://translatewiki.net. 
Change-Id: I1f7dbb0a1fc4a9d631decda033cf7fb99376d2f6
 2014-01-01 19:58:07 +00:00
Mark Holmquist e9a1c8c102 Bigger click targets for next and previous 
Change-Id: Ic2bd5b80092ee34133ae6b594ac25c57ab562b03
 2013-12-31 13:18:22 -08:00
Pau Giner 4c17403070 Updated icons 
Icons have been updated and CSS adjusted for close and next/prev arrows.

Change-Id: I335914685de4046f3ab76ea44a44b1b02222f831
 2013-12-31 09:57:58 -08:00
jenkins-bot c0fef99d23 Merge "Move 'x' button, shift arrows away from screen edges" 2013-12-30 22:03:52 +00:00
Mark Holmquist 0000664d80 Add tests for the link construction code 
Always a good plan.

Also refactored a little bit, but not too much. Juuuust right.

Bug: 57842
Change-Id: I787c3770e41474edafb2fd02e01fec2c7c2b5ed6
 2013-12-30 21:51:35 +00:00
Mark Holmquist f8d9a3d522 Move 'x' button, shift arrows away from screen edges 
Bug: 58653
Change-Id: I290bca497a56240890d64b234e960d04bd4a001c
 2013-12-30 12:36:45 -08:00
Translation updater bot bf631a31a6 Localisation updates from https://translatewiki.net. 
Change-Id: I63b1cbba888602590e7000af05d320538a1515bb
 2013-12-30 19:59:06 +00:00
jenkins-bot fdc0c0c860 Merge "Added 'Learn more' message" 2013-12-30 18:20:27 +00:00
jenkins-bot 3d1dfe6b7d Merge "Introduce image size bucketing" 2013-12-30 18:19:49 +00:00
apsdehal fb4367f24c Added 'Learn more' message 
Message was added to replace 'multimediaviewer-repository' when the file was local

Bug: 56121
Change-Id: I2c6cef2cb21f88159dc56ca7c94c4be21e553db9
 2013-12-30 16:54:40 +05:30
jenkins-bot feedc430d5 Merge "Fixes for the scroll-up affordance" 2013-12-29 15:05:24 +00:00
Mark Holmquist f96d5498ca Introduce image size bucketing 
See the conversation on mediawiki.org:
http://ur1.ca/g14jv

We're trying this out as one option in combatting slow thumbnail load
times. It may or may not work very well.

Bug: 56695
Change-Id: If1211fdff87c0782c7355d654415bfd29d63d84a
 2013-12-27 13:39:31 -08:00
Translation updater bot f18208025c Localisation updates from https://translatewiki.net. 
Change-Id: If9799e366f17586e6b7a98ce1703b7214b39e9c0
 2013-12-23 20:49:07 +00:00
jenkins-bot ea7ba8faaf Merge "Include license in title attribute of link in FileUsageDialog" 2013-12-20 00:56:39 +00:00
theopolisme 343e82cc8c Include license in title attribute of link in FileUsageDialog 
The title attribute of the link that wraps the image
in "Use this file on another website" will be set to
the license and/or author of the image, if available.

Bug: 56588
Change-Id: I5f504964ec3a63e4927385cb68e90856eb4cfe37
 2013-12-19 16:00:22 -06:00