Commit graph

1225 commits

Author SHA1 Message Date
Mark Holmquist 22fa78eea3 Close tipsies when closing interface
This could probably be aggregated and done more cleanly, but for now this
will do.

Change-Id: I1918a61a29f753f7249d9c5afbe0658f4faf4d23
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/740
2014-06-27 17:01:32 -04:00
Translation updater bot bef0e9653e Localisation updates from https://translatewiki.net.
Change-Id: I49ebfb99ba67cc400635041b58fc119fbb52fd6b
2014-06-27 20:22:40 +00:00
jenkins-bot 5abf15890e Merge "Fix URL handling for global usage list" 2014-06-27 17:41:17 +00:00
jenkins-bot 58d2bed512 Merge "Fix image download test to not rely on assets outside the codebase" 2014-06-27 17:33:52 +00:00
Translation updater bot ab11b36d3e Localisation updates from https://translatewiki.net.
Change-Id: I9ac84385028e212adf0355789b864a14f3869754
2014-06-26 19:32:57 +00:00
Gergő Tisza 033e7debcf Fix image download test to not rely on assets outside the codebase
We should probably have a proper test image eventually, so that
we can use e.g. image dimensions to double-check the results, but
this way at least our tests won't get broken by unrelated changes
in other repos.

Change-Id: Iffffd94fde99c53da59217a5181ad0560fce314c
2014-06-25 22:10:56 +00:00
Gilles Dubuc eef5fe7897 Add Safari to browser tags
The test passes on Cloudbees, we can now add the tag to make
it official

Change-Id: Id0ada2fbdb7e3fea1429d0cbec52b24e5815c4ac
2014-06-25 21:43:29 +00:00
Gergő Tisza deafff7046 Fix URL handling for global usage list
Also add integration tests to make sure URL generation works OK

Bug: 63908
Bug: 64910
Bug: 66147
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/570
Change-Id: I448f42e294102a633f74c305dd0a226e7dbe955d
2014-06-25 21:41:04 +00:00
Translation updater bot 096e9850a0 Localisation updates from https://translatewiki.net.
Change-Id: I3661dadbb77f10a38cb5db410df8adc164155b4d
2014-06-25 20:40:30 +00:00
Gergő Tisza f7ae77e79e Remember last reuse tab selection
Change-Id: Ic9b5d0ecc49b6361bfaa0e83b7340648ea2e6a72
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/660
2014-06-25 02:19:49 +00:00
Gergő Tisza 7aef3afbc2 Add MS prefixed version of .unselectable
Apparently -ms-user-select is a thing now.

Change-Id: Ic059dc69b0b3ceeb089b4accdd09fa8c6b9061f2
2014-06-25 00:58:26 +00:00
Gergő Tisza 2a5b519d7a Fix for merge mistake in Ic37b4150288055c3fae8d22919ed7b1249db1f09
A class was renamed inconsistently, causing wrong aspect ratio. 

Change-Id: I9854ff1193971c65e5b36faac62c7830ed8bdb45
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/737
2014-06-24 20:31:18 +00:00
jenkins-bot 16cc658c65 Merge "Fix failing test" 2014-06-24 20:26:07 +00:00
Gergő Tisza 427d9f0272 Fix failing test
The Vector skin directory was renamed to uppercase, apparently.

Change-Id: Ied94356f13a661101ee3ba101503229c4bce5a79
2014-06-24 20:19:38 +00:00
Translation updater bot eab0b3d85f Localisation updates from https://translatewiki.net.
Change-Id: I503340ae53ac48e660eda87833c78af4649eecf2
2014-06-24 20:00:36 +00:00
Translation updater bot ca5243eecb Localisation updates from https://translatewiki.net.
Change-Id: Id80c4123a9b946ed7d866cfb1b2fccf4ef22b196
2014-06-23 19:55:41 +00:00
Translation updater bot d4e35e0876 Localisation updates from https://translatewiki.net.
Change-Id: I15034497e1fccd89f9cc5299ae7b222c3c6990d5
2014-06-22 19:30:26 +00:00
Translation updater bot e264878e2b Localisation updates from https://translatewiki.net.
Change-Id: I18e61151057d0e0cdc006a7e03a72790bd875d54
2014-06-20 19:49:40 +00:00
jenkins-bot 5b7a75f61e Merge "Fix commons detection, use URL" 2014-06-19 22:12:59 +00:00
Mark Holmquist b921b3e7c8 Fix commons detection, use URL
URLs don't change, they aren't ever localised, etc.

Hopefully this is the end of this problem.

Change-Id: Ib5b41e2e64a5af65f342783cfd41f35559fbfd60
2014-06-19 15:04:51 -07:00
jenkins-bot 0db603b372 Merge "Make the metadata panel opening affordance more obvious" 2014-06-19 21:52:42 +00:00
Gergő Tisza 5e3808a14e Make the metadata panel opening affordance more obvious
- rearrange DOM structure of above-fold part of the metadata panel:
  - rename .mw-mmv-controls to .mw-mmv-above-fold
  - the above-fold part is a single positioned div now, with height
    explitcitly set
  - less LESS gymnastics, above-fold height is a single variable
  - add paddings to the p elements instead of the containers
  - make all title elements align to baseline (except the logo which
    would look horrible)
- discard some CSS which was superfluous
  - overspecified sizes/positions
  - some top/bottoms for staticly positioned elements
- get rid of the .mw-mmv-drag-affordance div, since a full-width bar
  wouldn't really make sense on the bottom of the above-fold section
- flip the chevron and place it to the bottom of the above-fold part;
  add colors etc. per spec
- fix stripe button horizontal spacing

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/706
Change-Id: Ic37b4150288055c3fae8d22919ed7b1249db1f09
2014-06-19 21:14:56 +00:00
Translation updater bot d6188af75a Localisation updates from https://translatewiki.net.
Change-Id: I341892fbba8e7932a65d114091193242cd247723
2014-06-19 19:28:41 +00:00
Gergő Tisza 0a265d7e96 Fullscreen improvements
- fix sizing error so that the image actually fits the screen
- hide some stuff that didn't work properly in fullscreen anyway
  (commons/survey buttons just exited fullscreen, reuse menu
  did not fade with the metadata panel, view terms link didn't do
  anything)
- move metadata scroller CSS rules into metadata scroller LESS file
- disable invite animation which broke the opacity transition
- move opacity transition to the main metadata panel element;
  remove background-color transition which is pointless since there
  is an opacity transition

Change-Id: Ib26160cc6431ea007dab8441c634d0faf9ee1d0a
2014-06-19 18:11:26 +00:00
Gilles Dubuc 4e752dd08d Track optin/optout events
Change-Id: I07eeef7a2304df4b70be252929737dad84522afb
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/558
2014-06-19 11:23:03 +02:00
Gilles Dubuc 9caf00e944 Fix typo in i18n
Change-Id: Ib161e71d8f7ee00c48cd697b21c7442a815d4be6
2014-06-19 11:05:52 +02:00
jenkins-bot 0c80fcd992 Merge "Make optout link more AJAXy" 2014-06-19 09:01:54 +00:00
Gergő Tisza c01cb55f4d Make optout link more AJAXy
Make it grey, unclickable and change text while waiting for the
AJAX request.

Change-Id: Ic5c2923944658d5be04217cdfe62e1d8608a478f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/723
2014-06-19 10:42:04 +02:00
jenkins-bot 6498fb9c9c Merge "Log clicks on the original file link" 2014-06-19 08:28:23 +00:00
jenkins-bot 30a1940737 Merge "Change "learn more" to "more details about this file"" 2014-06-19 08:17:53 +00:00
Gergő Tisza e5cb2c7f85 Log clicks on the original file link
Change-Id: I3022128ce1772d67f389322379ab8700265d2d29
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/715
2014-06-19 01:21:51 +00:00
Translation updater bot c65effcb64 Localisation updates from https://translatewiki.net.
Change-Id: If12f99cf962453b94fd1ff8f05ed77766c8b5113
2014-06-18 19:56:20 +00:00
Gergő Tisza 2616546468 Change "learn more" to "more details about this file"
Several people complained that "Learn more on Wikimedia Commons"
is not clear: it can be interpreted as a link to the Commons
main page, the text does not suggest that the link will be related
to this specific file. The new wording tries to address this.

Change-Id: Ia605cc30c4ca57598f7cebdde60061800a10b6e7
2014-06-18 19:10:11 +00:00
jenkins-bot d9b8e2006e Merge "Log clicks to the above-the-fold file page link" 2014-06-18 11:27:04 +00:00
jenkins-bot f0cf868ea3 Merge "Tweak optout popup texts" 2014-06-18 11:19:30 +00:00
jenkins-bot 6c10f4dec6 Merge "Make max-height computation more stable" 2014-06-18 10:33:08 +00:00
jenkins-bot cffddda969 Merge "Make opacity rules compatible with IE6-8" 2014-06-18 10:12:35 +00:00
Gergő Tisza f566f6e585 Log clicks to the above-the-fold file page link
This uses best-effort logging (like most other links do), not the
blocking call that's used by the other file page link, since
analytics folks had severe misgivings about that.

Change-Id: I35204420c834fa4fce3dcf81403cb78b92811caf
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/726
2014-06-18 01:01:59 +00:00
Gergő Tisza f557dc6968 Tweak optout popup texts
Change-Id: I0478a7945db8b8bc5063e8385644a6ac7c228b79
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/720
2014-06-17 23:39:16 +00:00
Gergő Tisza c594a5610a Make max-height computation more stable
Instead of setting the parent's height as max height of the
<img> element, find the first parent which has a non-automatic
height (that would be .mw-mmv-image-wrapper).

With the old structure, the height of the parent element could
be determined by the height of the image, which would then be
written back into the max-height of the image, messing up the
aspect ratio. I did not see this in the wild, but it was easy
to reproduce by changing the timing of the resize handler (in
particular, I tried to call the resize handler before loading
the new resolution, to make the UI more responsive, and ran
into this problem). This cannot happen anymore now.

This also fix a bug on some browsers (IE 10, maybe iOS Safari)
where the size of the image could be slightly larger than the
available space, and the bottom of the image was obscured by
the metadata panel. I am still not sure how exactly that
happened, but it was related to the <img> parents with automatic
heights having incorrect height. After making sure the <img>
has a max-height derived from an element with non-automatic
height, I cannot reproduce the bug on IE 10 anymore.

Change-Id: I193aefc42e6d6072717643659a9e4c0c8b7c7e93
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/698
Bug: 66244
2014-06-17 21:20:00 +00:00
Gergő Tisza 2079519eba Make opacity rules compatible with IE6-8
Change-Id: I426c7af8f5467c3e06abaea4f98b7e1495157e95
2014-06-17 21:11:33 +00:00
Gergő Tisza 2083a39dc2 Convert Mac line endings to Linux ones for some SVG files
Change-Id: If956b1b1b45555144ad9f2299a38d2375cc2e40a
2014-06-17 19:55:34 +00:00
Translation updater bot 2a5aad613c Localisation updates from https://translatewiki.net.
Change-Id: If8f11e72841531bcc06ab47b3be69444b04ee362
2014-06-16 19:52:01 +00:00
jenkins-bot 63757df8b7 Merge "Fix description of date messages" 2014-06-16 18:01:41 +00:00
Gergő Tisza de2f8f1bfb Fix description of date messages
This got swapped up - created is the one which is parsed from a
template and can have all kinds of weird values. Uploaded comes from
MediaWiki and is always a proper localized date.

Change-Id: I12f60770f9841c9b379280cdf2190275fa04e5cb
2014-06-16 18:00:50 +00:00
jenkins-bot 87e6bfc714 Merge "Updated chevron icons" 2014-06-16 09:45:09 +00:00
jenkins-bot 90b84731c1 Merge "Revert "Use localized namespace name in embed wikitext"" 2014-06-16 09:31:08 +00:00
Translation updater bot ebca2b7d02 Localisation updates from https://translatewiki.net.
Change-Id: I21db439421fe72d0da036fd627a64ed108e24449
2014-06-15 19:52:55 +00:00
Translation updater bot 138918b2aa Localisation updates from https://translatewiki.net.
Change-Id: I1119913db030dac99b5e8496665b9bc92a3be9b5
2014-06-14 19:17:08 +00:00
jenkins-bot b8b475c77c Merge "Make preview link more prominent" 2014-06-13 23:39:15 +00:00