Commit graph

1269 commits

Author SHA1 Message Date
Mark Holmquist 5e98e3bcd6 Fix bug that would cause the image to stay small
When opening the lightbox, the image might stay small
because of a race condition. This is fixed using a
deferred object.

Change-Id: I4e93c7d26da47e5177abeb1dac841bf6c25a9022
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/138
2014-01-27 10:21:38 +01:00
Translation updater bot b2d986e2b4 Localisation updates from https://translatewiki.net.
Change-Id: I5470b0001d4c807eb7309a5a24d06be23a04c9d6
2014-01-26 16:24:18 +00:00
jenkins-bot 38fe1c91b5 Merge "Move models to their own modules" 2014-01-24 23:24:26 +00:00
Translation updater bot 0b78a146b5 Merge "Localisation updates from https://translatewiki.net." 2014-01-24 20:17:15 +00:00
Translation updater bot 23bf3d0d31 Localisation updates from https://translatewiki.net.
Change-Id: I50a902ed79086306d41e5e22fc12b0830285a03d
2014-01-24 20:10:14 +00:00
Mark Holmquist 5b03c39c72 Move models to their own modules
Change-Id: Ib3d32496bfbc174dc136a269abf0b66cf0ae475d
2014-01-24 11:41:05 -08:00
Mark Holmquist 5e4a544133 Moving things around for module renames
This is a big change, but should change nothing except the sizes of some
files and where they all are.

There are no more ext.multimediaViewer strings ANYWHERE, so let's keep
it that way. :)

Change-Id: Ic0892f5894700938bfa01f3f9bc8e5ab8276eb72
2014-01-24 09:21:16 -08:00
Aaron Arcos f643430373 Fix to streching image b/60173.
It seems the problem was iOS specific. In retina displays the devicePixelRatio
turns out to be 2. This was making the images twice as wide. This was introduced
as a way to fix the resolution problem with some Apple devices, I suppose? Since this is not
fixing the problem I am removing it for the moment. Fixing the resolution issue implies
more changes that will be addressed in another iteration.

Bug: 60173
Change-Id: Iaff2aa6ba13ae85f905ab6d1569572881d8b5990
2014-01-23 16:16:13 -08:00
Translation updater bot a28988355b Localisation updates from https://translatewiki.net.
Change-Id: Icaf9874a67cf3ff427d85e4db61983258e9bd1b5
2014-01-23 20:16:13 +00:00
Mark Holmquist 64c1cc2976 Fix up jsduck docs
Documentation shouldn't be this hard :P

Change-Id: I758ec6c5b3e0ba389dbb837470fa6ceea07fa67d
2014-01-23 18:31:12 +00:00
jenkins-bot d245703241 Merge "A bunch of description fixes" 2014-01-22 23:51:50 +00:00
Mark Holmquist 22d2a69979 A bunch of description fixes
* Move description and caption to both be in the bottom left
* Make empty description grey and italic
* Fix problem where description was sometimes appended twice
* Move description UI stuff into a separate file, and make it more MVCy
* Tests for description UI stuff
* General framework, to an extent, for UI classes

Change-Id: Ibc8c576cd8a41c2e3cf7e13f1b9e093384fb4655
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/120
2014-01-22 14:46:39 -08:00
Gergő Tisza 2a70725d4e Add CC 4.0 license support
Bug: 60199
Change-Id: I1c2fa11960b2031b5dd5c4f85bf6caaa566fd3b8
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/95
2014-01-22 09:18:36 -08:00
jenkins-bot 7f67c0934a Merge "Add 'Location:' to the location message" 2014-01-22 17:13:52 +00:00
Zeljko Filipin f876b87d56 @login tag is required for tests to be able to log in at Jenkins machine
Change-Id: I4302518543a7f7e4bd02132d444f870a1fcea54f
2014-01-22 14:51:17 +01:00
Gergő Tisza fed238fcd6 Create model & providers for file usage information
Bug: 60087
Change-Id: I0e72c1e4590714e92a365f9741633221af5b0553
2014-01-21 18:04:51 -08:00
Mark Holmquist 47cad0e607 Add 'Location:' to the location message
Actually it's a totally new message, but still.

Change-Id: I5c02b9ec59bd0c8e455aae71936625a1bae48700
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/121
2014-01-21 17:35:02 -08:00
Gergő Tisza ac8d1eec0c Change working directory for JSDuck generate script
...so that it can be used without cd-ing.

Change-Id: I8e75b7348dfe0d3bd7185899bfeecbe63de11161
2014-01-22 00:33:40 +00:00
Mark Holmquist 34047e3ba3 Fix jsduck warnings
Change-Id: I91da4956c6635088a3763c2cd79d0e685bbaf859
2014-01-21 16:28:05 -08:00
Mark Holmquist 4ce1d0d206 Add main class to jsduck
Change-Id: I774303ce4f756637bea3821ae2b2ff724351b3bb
2014-01-21 13:48:10 -08:00
Mark Holmquist bdef21d593 Adding first pass at jsduck docs
Interface, data model, and image all documented.

Change-Id: Id64da283c4bbeaae930103233f9e798b5a9db51b
2014-01-21 11:44:58 -08:00
jenkins-bot 244b056249 Merge "Initial setup for Multimedia Viewer browser tests and first basic e2e test." 2014-01-20 22:55:02 +00:00
Translation updater bot bef5375818 Localisation updates from https://translatewiki.net.
Change-Id: Icd507c502006eba00c15c5633f1e919d041b9426
2014-01-19 20:16:51 +00:00
Jeff Hall 47cfaf62bd Initial setup for Multimedia Viewer browser tests and first basic e2e test.
Did some clean-up for Cucumber tags and code conventions.

Change-Id: Ifc954f60a50c41211043493fd64c2dcfa64848ff
Mingle: Multimedia card #100
Bug: 60049
2014-01-18 18:41:26 -08:00
Translation updater bot 1eba90d28d Localisation updates from https://translatewiki.net.
Change-Id: Id627ee6304a86d8bf084b0debca2c04191d8d0a9
2014-01-18 21:15:32 +00:00
Mark Holmquist f59962e4a3 Add location information to metadata div
Adds location in a human readable format, plus a link to geohack because
that's how we roll.

See https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/42

+more tests

Change-Id: Ie8c9b8a0caf0f13ad5341a84173381ce49da97f6
2014-01-17 17:22:44 -08:00
Mark Holmquist 6363b90bd8 Add caption to the interface in place of description
Also include the description on the right side of the page, but the caption
generally is more relevant and so should have the place of honour.

+tests

Change-Id: I512b3dd99207878233d501135b4dda0d0bd9cdd6
2014-01-17 16:37:56 -08:00
Mark Holmquist 328728a3ff Add tests for EventLogging timing
Change-Id: Idb44fc2c0b4f38c0e4ae9c91459735fa547d0191
2014-01-17 18:44:28 +00:00
jenkins-bot b9dc9b1c2d Merge "Refactor animation, plus test" 2014-01-17 17:47:29 +00:00
jenkins-bot 32c57f38de Merge "Display the favicon of the foreign file repo when available" 2014-01-17 17:30:59 +00:00
Gilles Dubuc ddff7de9da Display the favicon of the foreign file repo when available
The foreign repo link in the details area will display the favicon
of the foreign repo when available.

Change-Id: Id946a80beeabcd526f16872efaedbdd291444d2d
Mingle: Multimedia card #107
2014-01-17 14:30:25 +01:00
apsdehal f992a5f9f0 Reduce font-size for description in lightbox
Bug: 56445
Change-Id: I0d553d5089768df597a48fa0c696b5a8d29d34c7
2014-01-17 01:49:19 +00:00
jenkins-bot be163c9bad Merge "Added test if Lightbox is attached" 2014-01-17 01:46:09 +00:00
jenkins-bot fa63bdee3f Merge "Use JSONP for gender query to avoid cross-domain issues" 2014-01-17 01:44:56 +00:00
Mark Holmquist 9b28edb1be Refactor animation, plus test
Change-Id: I688c573b7fbd136782177f0b690d3aab994c6d10
2014-01-16 17:33:15 -08:00
jenkins-bot 29b1efe9b8 Merge "Clicking on the chevron should open/close the details" 2014-01-16 21:53:53 +00:00
apsdehal 08957fa129 Added test if Lightbox is attached
Currently LIP.resizeCallBack was called even when lightbox was not appended, so I added a test to check the same.

Change-Id: Ie3a40a5d98f12a95b1d54e130896f67b71e927fa
2014-01-16 21:12:02 +05:30
jenkins-bot 380e78ab0c Merge "Fix resize functions" 2014-01-15 22:24:45 +00:00
Translation updater bot a4b9aca3e2 Localisation updates from https://translatewiki.net.
Change-Id: I007ee2476a6986fa1bc890cadbefa818c66d8bb2
2014-01-15 21:03:18 +00:00
Gilles Dubuc c0bf3591f8 Clicking on the chevron should open/close the details
Change-Id: Ica8c5ae8c8f34374e946246878f3c8609d263a12
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/80
2014-01-15 09:21:58 +01:00
Mark Holmquist 0b46a65794 Fix resize functions
Change-Id: I074a704e76c5c42890d65d8235854a998f3e4af9
2014-01-14 21:39:22 -08:00
Gergő Tisza d24ba2d7c8 Use JSONP for gender query to avoid cross-domain issues
Querying the uploader's gender defaults to CORS, which is disallowed
for non-WMF sites and spams the javascript console with XHR errors.
JSONP works in such cases, and has no disadvantages I can think of.

Change-Id: I9b13210e03059a46407f119045540665c48585ad
2014-01-14 21:49:28 +00:00
Gilles Dubuc cbf6bd7767 Make sure that the close button is always visible
Change-Id: Ib1bf72d898220442992c5a30d90a9a683d00d110
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/81
2014-01-14 16:42:52 +01:00
jenkins-bot 03ef24563b Merge "Refactor to a data model" 2014-01-13 21:41:14 +00:00
Mark Holmquist 89417163a9 Refactor to a data model
Image information and repo information are now both stored somewhere
else entirely, so we don't need to keep accessing weird API return
values to sort things out. fetchImageInfo now uses those classes to
an extent, and we now cache thumbnail URLs for different sizes.

Change-Id: Ife8293c86683ea914b1a5a60000584b501d92e55
2014-01-12 12:50:34 -08:00
Translation updater bot a8a0f44754 Localisation updates from https://translatewiki.net.
Change-Id: Iba75dddabc38c8e26b7707d34a688e11e71d8f44
2014-01-12 20:36:08 +00:00
Translation updater bot c0adaaf4ff Localisation updates from https://translatewiki.net.
Change-Id: Ib4858f726e3a00ebee91b0e99ee804379d3ef5ba
2014-01-11 22:24:32 +00:00
Translation updater bot ed03dd0ade Localisation updates from https://translatewiki.net.
Change-Id: Icb6a2c4af3ca2d01aa6e5039c52dd81512183547
2014-01-10 22:46:03 +00:00
jenkins-bot 1061cda70e Merge "Move the arrows and the close/fullscreen button" 2014-01-10 12:19:16 +00:00
jenkins-bot 8cbfdf4d92 Merge "Improve the test coverage to also check prev/next scroll" 2014-01-10 11:24:08 +00:00