Commit graph

571 commits

Author SHA1 Message Date
Gergő Tisza 1af29bdc53 Fix metadata footer positioning in fullscreen mode
Add position:fixed to the metadata panel to stick it to the bottom
of the page.

This reverts the change in Ic37b4150288055c3fae8d22919ed7b1249db1f09
I can't recall if there was some intent behind that or it was an
accidental deletion; but this seems to work fine in Chrome and
FF.

Change-Id: Ic5fdce5fb3d6884df782f8bc9ec5c9a5c67edbd6
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/805
2014-07-23 07:32:56 +00:00
jenkins-bot b77010fadd Merge "Use image title in history" 2014-07-22 14:12:23 +00:00
Gergő Tisza e055b8bb7d Use image title in history
Changes document title (which is shown in history navigation)
to include the image name.

Bug: 67008
Change-Id: Id1b030f2b984571fb0877e35db2ca2ccc86f0130
2014-07-22 06:08:59 +00:00
Gergő Tisza 0423bfbe5a Reveal full text when metadata panel is opened
Automatically reveal/hide full text as metadata panel is opened/closed.
Also makes metadata open/close a proper event.
Changes scrollTop calculation for the fully open metadatapanel so it is not
confused by the size of the panel changing.

Also rename MetadataPanel.$controlBar to $aboveFold (that field was missed
when the corresponding CSS class got renamed).

Change-Id: I7e66ca0f45c2188dab4b78508ad7f91154187de4
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396
2014-07-18 00:47:46 +00:00
jenkins-bot 95cc9affbc Merge "Reveal full text when user clicks on title or credit" 2014-07-17 13:44:23 +00:00
Gergő Tisza f14d08fd75 Reveal full text when user clicks on title or credit
Reveal the full title + author + source when the user clicks one
of these, and make some related changes:
* expand the above-the-fold part of the metadata panel so they fit
* make the stripe buttons smaller and hide their text
* scroll the panel up if necessary
* modify tooltip texts when there is more text to show

Change-Id: I304297bc5e7be7b16e2fc4bde66ac19641b00029
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396
2014-07-17 09:42:12 -04:00
Gergő Tisza b622669a9e Size adjustments for moved-back repo icon
* make Commons icon slightly larger than "use this file" icon so
  it seems to be the same size (since the Commons icon has more
  whitespace)
* re-add size adjustments for dynamic icon; IIRC this was needed
  to make Wikipedia icons look good

Change-Id: I6cc2c66beb1d270c9367446661ef14139afa814e
2014-07-17 00:49:10 +00:00
jenkins-bot ab63450dbe Merge "Remove all survey-related code" 2014-07-16 21:31:21 +00:00
Gilles Dubuc b0d885e4dc Remove all survey-related code
Change-Id: I67285260c13a1e8d3c37365bb80a7156c0fecd4e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/794
2014-07-16 21:27:53 +00:00
Gilles Dubuc e17024549f Move repo icon back to the right-hand side
Also makes the grayscale filter work in Firefox.

Change-Id: I7dbeeb55502bc1ff0e1c969fb68310485c562765
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/792
2014-07-16 10:45:14 -04:00
Mark Holmquist 3e2759cd7b Fix a few issues in unattach
Check for tipsy-ness, and for the existence of the opt out button. The
latter doesn't affect prod, but the former might.

Change-Id: Ia5ae8b160626d27750cb3e4938c27a461b9f0c64
2014-07-15 22:15:04 +00:00
Gilles Dubuc eae6f764c2 Fix JS error caused by change in OOUI
hide() has been replaced by toggle() in the latest version of OOUI

Change-Id: Ia868ea1a41430ae566109222ebee6e778db12ad8
2014-07-15 18:02:05 -04:00
jenkins-bot 0aab988269 Merge "Remove $.browser call in jquery.hashchange" 2014-07-10 20:31:12 +00:00
Gilles Dubuc 44865d87e6 Remove $.browser call in jquery.hashchange
I've tested a wide variety of old browsers on sauce labs and only
the older IEs reported "false" for support_onhashchange.

I think the $.browser.msie check was defensive in the first place,
there's no reason why a browser that doesn't support the
onhashchange event wouldn't benefit from the iframe trick.

Change-Id: I5b3a83118ef870237a54a6d67dd930617987abf2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/590
2014-07-10 15:12:41 -04:00
Pau Giner 5edb949d01 Adjustments to repo icon
The following visual adjustments have been made:
- Make color similar to other icons in the metadata panel.
- Highlight on hover to convey interactivity.
- Adjust to the "visual center". The icon was matematically centered, but since the angular separator adds empty space to the right, a 2px correction has been added so that it looks centered taking into account that extra space.

Change-Id: Ib4db723b38a8d6fc9528fe86756220b6525da95b
2014-07-10 10:25:23 +02:00
jenkins-bot f63c00c8b6 Merge "Remove the gap the between the download button and the dropdown menu" 2014-07-07 16:30:28 +00:00
jenkins-bot 7a42b844ae Merge "Make download panel dropdown button unselectable" 2014-07-07 16:30:20 +00:00
jenkins-bot 6afa9df593 Merge "Use same text formatting for downloads as for other panels" 2014-07-07 16:29:54 +00:00
jenkins-bot 6faaa01ad3 Merge "Convert non-standard class-names (mw-mlb, multiediaviewer-)" 2014-07-07 16:29:47 +00:00
jenkins-bot 3949ee3c5d Merge "Use absolute positioning for progress bar to stop pushing down content" 2014-07-04 06:45:40 +00:00
jenkins-bot 3d8133a813 Merge "Make above-the-fold buttons take up more vertical space" 2014-07-04 06:45:35 +00:00
jenkins-bot 06b772d92f Merge "Make description page link and reuse widget more prominent" 2014-07-04 06:45:34 +00:00
Gergő Tisza f35b9411dd Use absolute positioning for progress bar to stop pushing down content
Change-Id: I518d88f005506813325f6577450eda0ab1c8cd35
2014-07-04 00:14:41 +00:00
Gergő Tisza 5e0642a431 Make above-the-fold buttons take up more vertical space
Change-Id: Id38f4a8dace2818133d659e60036cd0f826665b4
2014-07-02 23:20:41 +00:00
jenkins-bot 1294e824c9 Merge "Add functionality to TruncatedTextField to toggle full text" 2014-07-02 13:29:14 +00:00
Gergő Tisza c5c450f91b Add functionality to TruncatedTextField to toggle full text
Change-Id: I34db79faa80ee5d1b3518aafd9b866cc9cdcc45b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396
2014-07-02 15:26:21 +02:00
jenkins-bot 60a94fd394 Merge "Show help tooltip for "view original file" button on image click" 2014-07-02 12:52:33 +00:00
jenkins-bot 252746c2f6 Merge "RTL positioning tweaks" 2014-07-02 12:47:57 +00:00
jenkins-bot 8dcf759d75 Merge "Angle separator image" 2014-07-02 12:38:31 +00:00
Gergő Tisza e9d3e041cd Remove the gap the between the download button and the dropdown menu
Change-Id: I640c5e759880f4a1fcbe213d793380ad9caca23c
2014-07-02 01:06:28 +00:00
Gergő Tisza f669763ea2 Make download panel dropdown button unselectable
Avoid ugly selection colors when people double-click the dropdown
button.
(Why would people double-click the dropdown button? Not sure, but
I did, so...)

Change-Id: If505c7b62ca501a492aa7f85d2f6c92790ecd6dd
2014-07-02 01:05:17 +00:00
Gergő Tisza e25cb01a75 Use same text formatting for downloads as for other panels
Change-Id: I0280f4fe33723e9c838c85b5be3e2025be2a9a39
2014-07-02 01:05:16 +00:00
Gergő Tisza 890d7721df Convert non-standard class-names (mw-mlb, multiediaviewer-)
Change-Id: Iab48c9df461b3405ea35d2da7f98fb6812e86b59
2014-07-02 01:02:41 +00:00
Pau Giner 0a17d6ab29 Styling adjustments for download panel
- Split button has been adjusted to have the same height on both parts (button and drop-down)
- The attribution panel has been adjusted to add hover states and adjust sizes and colors

Change-Id: I3ba80776add6dbca9f0b096dfe7ad4a8779f1a0d
2014-07-01 19:04:06 +02:00
jenkins-bot f91280eac1 Merge "Add MS prefixed version of .unselectable" 2014-07-01 12:29:19 +00:00
Gergő Tisza 4adde1685a Show help tooltip for "view original file" button on image click
Change-Id: Ia9e20f55bcdd0482e78a6e9aa5a0625ec2717e78
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/712
2014-06-30 21:12:29 +00:00
jenkins-bot 3e2dda867b Merge "Adjustments for invite animation" 2014-06-30 18:49:33 +00:00
jenkins-bot 02216b5ed3 Merge "Add section for attribution of downloads" 2014-06-30 18:36:07 +00:00
jenkins-bot 39e3cdaed0 Merge "Remove next/prev tooltips" 2014-06-30 18:29:21 +00:00
Mark Holmquist 532819b5a0 Remove next/prev tooltips
Change-Id: I978914bd57d7fdc260dbc0422915e6b766c35a66
2014-06-30 14:20:41 -04:00
Reedy 5c3846a74b Drop execute bit
Change-Id: I6c9f8ea6251bf6a7ed2a5684e5eaa572530a4fb9
2014-06-30 18:34:02 +01:00
Mark Holmquist a4e6bc22d9 Add section for attribution of downloads
Click on the button to expand, click the X to collapse again.

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/598
Change-Id: I6d2512cca0184437273329e6553c6524d6953404
2014-06-30 10:38:11 -04:00
Pau Giner e7fc5857de Adjustments for invite animation
The invite animation has been adjusted to:
- Make the panel movement more subtle (reduced distance and length)
- Add an animation for the chevron and coordinate it whith th panel movement.

Change-Id: I8fbd01d23fd9bf74fc272c40acd2663f5907326a
2014-06-30 14:35:33 +02:00
Gergő Tisza eff0207199 RTL positioning tweaks
* partially undo the RTL fix from mingle #512 which looks bad,
  and use four-value syyntax for background-position instead.
* use noflip on :before rule as :before itself is not flipped
* handle better the uncertainty resulting from image name
  usually not being RTL

Change-Id: If4aa7240e9bee5c0a06f1785edb9c72964dfc60f
2014-06-28 01:22:50 +00:00
Gergő Tisza 8d05dd8a6d Make description page link and reuse widget more prominent
Rearrange the above-the-fold part of the metadata panel so that
the link to the file descriprion page and the button for the
download/share/embed widgets are easier to find.

One gotcha is that favicons are blown up to 32x32px (a small icon
in the middle of a big empty space would really look ridiculous)
so if a site uses 16x16px favicons it will look pixelated.
None of the WMF sites do that though, and if anyone else does, they
should just fix it, 16px favicons suck anyway (e.g. not retina friendly).

Change-Id: Icce12174b6ed89731fe75f8069c0b4a2b7161a34
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/732
2014-06-28 00:28:11 +00:00
Pau Giner 8236a55ec2 Angle separator image
Visual element to separate the image repo icon from the basic
details on the metadata panel.

Change-Id: I57481985b8b449347242ba2cc0838d8a564d7963
2014-06-27 22:45:14 +00:00
Mark Holmquist 22fa78eea3 Close tipsies when closing interface
This could probably be aggregated and done more cleanly, but for now this
will do.

Change-Id: I1918a61a29f753f7249d9c5afbe0658f4faf4d23
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/740
2014-06-27 17:01:32 -04:00
jenkins-bot 5abf15890e Merge "Fix URL handling for global usage list" 2014-06-27 17:41:17 +00:00
Gergő Tisza deafff7046 Fix URL handling for global usage list
Also add integration tests to make sure URL generation works OK

Bug: 63908
Bug: 64910
Bug: 66147
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/570
Change-Id: I448f42e294102a633f74c305dd0a226e7dbe955d
2014-06-25 21:41:04 +00:00
Gergő Tisza f7ae77e79e Remember last reuse tab selection
Change-Id: Ic9b5d0ecc49b6361bfaa0e83b7340648ea2e6a72
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/660
2014-06-25 02:19:49 +00:00