Commit graph

2940 commits

Author SHA1 Message Date
jenkins-bot 6c10f4dec6 Merge "Make max-height computation more stable" 2014-06-18 10:33:08 +00:00
jenkins-bot cffddda969 Merge "Make opacity rules compatible with IE6-8" 2014-06-18 10:12:35 +00:00
Gergő Tisza f566f6e585 Log clicks to the above-the-fold file page link
This uses best-effort logging (like most other links do), not the
blocking call that's used by the other file page link, since
analytics folks had severe misgivings about that.

Change-Id: I35204420c834fa4fce3dcf81403cb78b92811caf
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/726
2014-06-18 01:01:59 +00:00
Gergő Tisza f557dc6968 Tweak optout popup texts
Change-Id: I0478a7945db8b8bc5063e8385644a6ac7c228b79
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/720
2014-06-17 23:39:16 +00:00
Gergő Tisza c594a5610a Make max-height computation more stable
Instead of setting the parent's height as max height of the
<img> element, find the first parent which has a non-automatic
height (that would be .mw-mmv-image-wrapper).

With the old structure, the height of the parent element could
be determined by the height of the image, which would then be
written back into the max-height of the image, messing up the
aspect ratio. I did not see this in the wild, but it was easy
to reproduce by changing the timing of the resize handler (in
particular, I tried to call the resize handler before loading
the new resolution, to make the UI more responsive, and ran
into this problem). This cannot happen anymore now.

This also fix a bug on some browsers (IE 10, maybe iOS Safari)
where the size of the image could be slightly larger than the
available space, and the bottom of the image was obscured by
the metadata panel. I am still not sure how exactly that
happened, but it was related to the <img> parents with automatic
heights having incorrect height. After making sure the <img>
has a max-height derived from an element with non-automatic
height, I cannot reproduce the bug on IE 10 anymore.

Change-Id: I193aefc42e6d6072717643659a9e4c0c8b7c7e93
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/698
Bug: 66244
2014-06-17 21:20:00 +00:00
Gergő Tisza 2079519eba Make opacity rules compatible with IE6-8
Change-Id: I426c7af8f5467c3e06abaea4f98b7e1495157e95
2014-06-17 21:11:33 +00:00
Gergő Tisza 2083a39dc2 Convert Mac line endings to Linux ones for some SVG files
Change-Id: If956b1b1b45555144ad9f2299a38d2375cc2e40a
2014-06-17 19:55:34 +00:00
Translation updater bot 2a5aad613c Localisation updates from https://translatewiki.net.
Change-Id: If8f11e72841531bcc06ab47b3be69444b04ee362
2014-06-16 19:52:01 +00:00
jenkins-bot 63757df8b7 Merge "Fix description of date messages" 2014-06-16 18:01:41 +00:00
Gergő Tisza de2f8f1bfb Fix description of date messages
This got swapped up - created is the one which is parsed from a
template and can have all kinds of weird values. Uploaded comes from
MediaWiki and is always a proper localized date.

Change-Id: I12f60770f9841c9b379280cdf2190275fa04e5cb
2014-06-16 18:00:50 +00:00
jenkins-bot 87e6bfc714 Merge "Updated chevron icons" 2014-06-16 09:45:09 +00:00
jenkins-bot 90b84731c1 Merge "Revert "Use localized namespace name in embed wikitext"" 2014-06-16 09:31:08 +00:00
Translation updater bot ebca2b7d02 Localisation updates from https://translatewiki.net.
Change-Id: I21db439421fe72d0da036fd627a64ed108e24449
2014-06-15 19:52:55 +00:00
Translation updater bot 138918b2aa Localisation updates from https://translatewiki.net.
Change-Id: I1119913db030dac99b5e8496665b9bc92a3be9b5
2014-06-14 19:17:08 +00:00
jenkins-bot b8b475c77c Merge "Make preview link more prominent" 2014-06-13 23:39:15 +00:00
jenkins-bot a4e2dc6962 Merge "Make MediaViewer ignore images which are in 'noviewer' class" 2014-06-13 23:34:23 +00:00
Gergő Tisza 92ea8edbc5 Make MediaViewer ignore images which are in 'noviewer' class
This includes images where the <img> element has that class
(achievable with [[File:Foo.png|class=noviewer]]) and also those
where some parent element has it.

Change-Id: I666be026828ea9ecb6e8c93d3f5ad1e3c190f81e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/511
2014-06-13 23:32:32 +00:00
Pau Giner a24b67c2cb Updated chevron icons
Chevron icons for the new design of the chevron.
Beware that the active version of the chevron is white since it is assuming
it will have a blue background.

Change-Id: I3d8fa040bfecc219a735565d5ebee8e283691bee
2014-06-13 23:06:18 +00:00
Translation updater bot be4a995c26 Localisation updates from https://translatewiki.net.
Change-Id: I61881d82ea5ecec1aabb6f2af85f05e206e07e90
2014-06-13 20:50:16 +00:00
Amir E. Aharoni 76f179ffdc Simplifying the 'Esc' message
The current message is:
Close this tool. Or press 'Esc' to exit

It has several problems:
* No full stop.
* Very long.
* Strange grammar: beginning a sentence with "Or" is unusual.

I simply put the Esc in parentheses, which is a common practice
with keyboard shortcuts.

Change-Id: Ib79ba8020885200ae2aaf7830ab337936c436752
2014-06-13 13:13:21 +03:00
jenkins-bot a0cfcd48a5 Merge "Tooltips for loads of things" 2014-06-12 22:01:09 +00:00
Translation updater bot 5f0dc0afd7 Localisation updates from https://translatewiki.net.
Change-Id: If8604f2a7a6cd881d9830fe7b760196d6d1d0109
2014-06-12 21:38:22 +00:00
Mark Holmquist ea610f8256 Tooltips for loads of things
Change-Id: I993bf60909024453a14de85af6239bded02eb8a6
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/546
2014-06-12 12:27:04 -07:00
Mark Holmquist f308c9f7b0 Make preview link more prominent
Also cleaned up the SVG. I hate Illustrator so much for what it does to
SVGs.

Change-Id: I3c1b8b812ed50ad65a8c2f53835e440bfd2e77ac
2014-06-12 11:07:47 -07:00
Gergő Tisza 89f4d27e4c Revert "Use localized namespace name in embed wikitext"
Mark pointed out that using localized namespace names would cause 
problems when users try to reuse images across wikis with different 
content language. Reverting for now.

This reverts commit 59b8e5c82a.

Bug: 64710
Change-Id: I4b8b46871a1c80bce20e4017aa8adcfe3041bb4a
2014-06-12 01:26:10 +00:00
jenkins-bot a4e64c27e1 Merge "Fix CSS for hiding content" 2014-06-11 23:47:55 +00:00
Mark Holmquist 9928952c53 Fix our isAnon usage
Change-Id: I1b72b8af620b1ac223f23ce2325f00f2c24d26ac
2014-06-11 16:21:37 -07:00
jenkins-bot 76d40a0189 Merge "Change "Created on X" and "Uploaded on X" to "Created: X" etc." 2014-06-11 22:53:27 +00:00
jenkins-bot 6e5a1cb185 Merge "Add opt-out/opt-back link" 2014-06-11 22:47:29 +00:00
jenkins-bot b53f7b2e60 Merge "Add functionality to check & set opt-in flag from code, also for anons" 2014-06-11 21:48:13 +00:00
Gergő Tisza 3cebfe32bc Use Repo.isCommons() for deciding whether an image is from Commons
Change-Id: Id6b523d218a9abc9e886da4000962c6523d25dc0
2014-06-11 21:14:14 +00:00
Translation updater bot 4512224c53 Localisation updates from https://translatewiki.net.
Change-Id: I39e3f0f41cd676117e3884e68ccfc533c3bfb3f4
2014-06-11 20:38:37 +00:00
jenkins-bot 114890cc43 Merge "Add "zoom" but really just view-file" 2014-06-11 02:38:52 +00:00
Gergő Tisza 5bd730894d Add opt-out/opt-back link
Change-Id: I998b7ad3ecb0b7e815f9ff0d5f871267b91c109d
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/703
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/704
2014-06-11 02:24:17 +00:00
Gergő Tisza e8c7c537a2 Add functionality to check & set opt-in flag from code, also for anons
Adds anew mmv.Config class to centralize localStorage handling issues,
adds AJAX option setting, adds getting/setting opt-in flag from
localstorage.

Change-Id: I25762ccb8c9bccd694c30a6f1c5d3c8611a5ecbc
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/703
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/704
2014-06-11 01:11:12 +00:00
jenkins-bot 9ec13a97cd Merge "Show Commons link to logged out users" 2014-06-10 22:19:17 +00:00
Mark Holmquist b2039ad7eb Add "zoom" but really just view-file
The zoom icon should get replaced Real Soon Now - looking at you, pginer

Change-Id: I88c1d4fb95e034e0f2fe618eb7309754ea1c283e
2014-06-10 15:07:12 -07:00
jenkins-bot 4ff614cf1b Merge "Toggle metadata panel on up/down keypress" 2014-06-10 21:31:22 +00:00
Translation updater bot 1f92e7c1ac Localisation updates from https://translatewiki.net.
Change-Id: I01fc33386282e6b3b9b3abdbcd970ea2199d3634
2014-06-10 20:44:40 +00:00
Gergő Tisza 4f54b81c03 Toggle metadata panel on up/down keypress
Previously 'up' brought the panel up, and 'down' brought it down,
which might conflict with expectations on scrolling. Up/down keys
now move the metadata panel to the opposite state, no matter what
the current state was.

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/697
Change-Id: I53079d81042afb86354bf44e9dfd662adf1576cb
2014-06-10 20:10:42 +00:00
Gergő Tisza 92e68e4013 Show Commons link to logged out users
Change-Id: I899cb36a5d25342325266b68a3fd8058f3129e78
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/429
2014-06-10 00:30:14 +00:00
Gergő Tisza afbe172613 Change "Created on X" and "Uploaded on X" to "Created: X" etc.
Based on enwiki feedback by Jonesey95: "Created on…" does not work
well when the date is not a day (and we have dates like "1992" or
"circa 1400"). "Created: …" works reasonably well for everything.

Same for "Uploaded on…".

Change-Id: I46b51880be2151a467ccb90a76dde6efc5991cd5
2014-06-09 23:42:42 +00:00
Pau Giner ba5a1b7516 Icon adjustments
- open.svg icon added for the "view in browser" feature form the share panel.
- expand.svg icon updated for better icon consistency (spacing also adjusted in the CSS)

Change-Id: Id6176d8f9b4884c9aabde05f1639500d3349f9a7
2014-06-09 23:03:16 +00:00
Translation updater bot aa2c15a9c4 Localisation updates from https://translatewiki.net.
Change-Id: I95cb8298be7cb4d626df9a67b4675bbcb6f97d64
2014-06-09 20:31:23 +00:00
jenkins-bot 05c58ba0b9 Merge "Use original URL when setting download for original" 2014-06-09 18:34:38 +00:00
Mark Holmquist fc02ce0dc8 Use original URL when setting download for original
Messed with the download tests a bit too.

Change-Id: I6b7f6b5eb8642db1a81aff05663636813a21fe06
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/470
2014-06-09 18:30:07 +00:00
Translation updater bot 1a53aa16d3 Localisation updates from https://translatewiki.net.
Change-Id: Iaf51dc423cdfdbe2aa201862cc096779c711a11d
2014-06-08 19:57:26 +00:00
Gergő Tisza 1d3769e106 Fix CSS for hiding content
:not() only works with simple selectors, not composite selectors.
This caused problems for people with customized skins.
Also, this way we only require support for > (wider) instead of
support for :not.

Also fixed footer id and added monobook for good measure.

Bug: 66326
Change-Id: Ibaa0861aff711723dd336eeaa8c12e73110b1c3b
2014-06-08 02:12:11 +00:00
Translation updater bot 46aaa55dc1 Localisation updates from https://translatewiki.net.
Change-Id: Ife83fb138d9faae0100f80cb6b9b36308cce1067
2014-06-06 21:47:18 +00:00
Mark Holmquist c34e80a1b1 Fix the share/download patch
Turns out the "active" class is added in each pane's definition.

TODO: Fix that.

Jenkins, you durnk

Change-Id: I6da961618b360d96a03948d4f6688cd4e1931b66
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/679
2014-06-04 23:32:52 +00:00