Commit graph

1993 commits

Author SHA1 Message Date
Mark Holmquist 6363b90bd8 Add caption to the interface in place of description
Also include the description on the right side of the page, but the caption
generally is more relevant and so should have the place of honour.

+tests

Change-Id: I512b3dd99207878233d501135b4dda0d0bd9cdd6
2014-01-17 16:37:56 -08:00
Mark Holmquist 328728a3ff Add tests for EventLogging timing
Change-Id: Idb44fc2c0b4f38c0e4ae9c91459735fa547d0191
2014-01-17 18:44:28 +00:00
jenkins-bot b9dc9b1c2d Merge "Refactor animation, plus test" 2014-01-17 17:47:29 +00:00
jenkins-bot 32c57f38de Merge "Display the favicon of the foreign file repo when available" 2014-01-17 17:30:59 +00:00
Gilles Dubuc ddff7de9da Display the favicon of the foreign file repo when available
The foreign repo link in the details area will display the favicon
of the foreign repo when available.

Change-Id: Id946a80beeabcd526f16872efaedbdd291444d2d
Mingle: Multimedia card #107
2014-01-17 14:30:25 +01:00
apsdehal f992a5f9f0 Reduce font-size for description in lightbox
Bug: 56445
Change-Id: I0d553d5089768df597a48fa0c696b5a8d29d34c7
2014-01-17 01:49:19 +00:00
jenkins-bot be163c9bad Merge "Added test if Lightbox is attached" 2014-01-17 01:46:09 +00:00
jenkins-bot fa63bdee3f Merge "Use JSONP for gender query to avoid cross-domain issues" 2014-01-17 01:44:56 +00:00
Mark Holmquist 9b28edb1be Refactor animation, plus test
Change-Id: I688c573b7fbd136782177f0b690d3aab994c6d10
2014-01-16 17:33:15 -08:00
jenkins-bot 29b1efe9b8 Merge "Clicking on the chevron should open/close the details" 2014-01-16 21:53:53 +00:00
apsdehal 08957fa129 Added test if Lightbox is attached
Currently LIP.resizeCallBack was called even when lightbox was not appended, so I added a test to check the same.

Change-Id: Ie3a40a5d98f12a95b1d54e130896f67b71e927fa
2014-01-16 21:12:02 +05:30
jenkins-bot 380e78ab0c Merge "Fix resize functions" 2014-01-15 22:24:45 +00:00
Translation updater bot a4b9aca3e2 Localisation updates from https://translatewiki.net.
Change-Id: I007ee2476a6986fa1bc890cadbefa818c66d8bb2
2014-01-15 21:03:18 +00:00
Gilles Dubuc c0bf3591f8 Clicking on the chevron should open/close the details
Change-Id: Ica8c5ae8c8f34374e946246878f3c8609d263a12
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/80
2014-01-15 09:21:58 +01:00
Mark Holmquist 0b46a65794 Fix resize functions
Change-Id: I074a704e76c5c42890d65d8235854a998f3e4af9
2014-01-14 21:39:22 -08:00
Gergő Tisza d24ba2d7c8 Use JSONP for gender query to avoid cross-domain issues
Querying the uploader's gender defaults to CORS, which is disallowed
for non-WMF sites and spams the javascript console with XHR errors.
JSONP works in such cases, and has no disadvantages I can think of.

Change-Id: I9b13210e03059a46407f119045540665c48585ad
2014-01-14 21:49:28 +00:00
Gilles Dubuc cbf6bd7767 Make sure that the close button is always visible
Change-Id: Ib1bf72d898220442992c5a30d90a9a683d00d110
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/81
2014-01-14 16:42:52 +01:00
jenkins-bot 03ef24563b Merge "Refactor to a data model" 2014-01-13 21:41:14 +00:00
Mark Holmquist 89417163a9 Refactor to a data model
Image information and repo information are now both stored somewhere
else entirely, so we don't need to keep accessing weird API return
values to sort things out. fetchImageInfo now uses those classes to
an extent, and we now cache thumbnail URLs for different sizes.

Change-Id: Ife8293c86683ea914b1a5a60000584b501d92e55
2014-01-12 12:50:34 -08:00
Translation updater bot a8a0f44754 Localisation updates from https://translatewiki.net.
Change-Id: Iba75dddabc38c8e26b7707d34a688e11e71d8f44
2014-01-12 20:36:08 +00:00
Translation updater bot c0adaaf4ff Localisation updates from https://translatewiki.net.
Change-Id: Ib4858f726e3a00ebee91b0e99ee804379d3ef5ba
2014-01-11 22:24:32 +00:00
Translation updater bot ed03dd0ade Localisation updates from https://translatewiki.net.
Change-Id: Icb6a2c4af3ca2d01aa6e5039c52dd81512183547
2014-01-10 22:46:03 +00:00
jenkins-bot 1061cda70e Merge "Move the arrows and the close/fullscreen button" 2014-01-10 12:19:16 +00:00
jenkins-bot 8cbfdf4d92 Merge "Improve the test coverage to also check prev/next scroll" 2014-01-10 11:24:08 +00:00
Gilles Dubuc 4d1ba92fc6 Improve the test coverage to also check prev/next scroll
This test should now cover all the scenarios fixed in my
preceding bugfix

Bug: 59861
Change-Id: I2df6c2dac8e31186c2c976fd890aac38143391da
2014-01-10 10:26:25 +01:00
Mark Holmquist ae50fad5f5 Use promises
Uses promises in the entirety of fetchImageInfo. Also removes the old
fetchRepoInfo method which was unused (basically) anyway.

Change-Id: Ie7f9a27822ecb893b99dbd755c6199769f2e6784
2014-01-09 16:52:18 -08:00
Translation updater bot 0e160cb8bb Localisation updates from https://translatewiki.net.
Change-Id: I6a9ed704451f43e1fa5a280fbc667384939171b4
2014-01-09 20:28:45 +00:00
jenkins-bot cc8977de31 Merge "Fix metadata loading" 2014-01-09 18:33:32 +00:00
Gilles Dubuc 380612c4bf Only scroll to the top when opening the lightbox
Not when going prev/next.
The saved position feature was probably broken as well if you
happened to press prev/next.
This was my mistake for not noticing that attach() runs on
prev/next.

Bug: 59861
Change-Id: Ic6ff4b15a54178fb5d38640317650f5676293083
2014-01-09 18:11:20 +01:00
Gergő Tisza a91058adc4 Fix metadata loading
fetchImageInfo() was used to load different property sets,
but had a single cache, so sometimes the results with less properties
overwrote the ones with more.

This is a dirty hack to deal with that. I will revisit once we
use promises.

Bug: 59817
Change-Id: I4f375bcc4e6fcfdb3e3fe7a30fc90a8fd44164c3
2014-01-09 02:30:09 +00:00
jenkins-bot 0f719f999d Merge "Load images normally" 2014-01-09 00:58:00 +00:00
Mark Holmquist 5949748ed6 Load images normally
Removes the spinner, loads images line-by-line. Supposedly more
expected for most users.

Change-Id: Ia5fba4c8d8af681c0a95e43d34014b07e33941c4
2014-01-08 23:42:06 +00:00
Translation updater bot 2441856288 Localisation updates from https://translatewiki.net.
Change-Id: Ie6c47052de9d1c690c678ff32e0aeaed9b516ada
2014-01-08 20:34:34 +00:00
jenkins-bot 666f2b3af3 Merge "Make the behavior of the lightbox more consistent with scroll" 2014-01-08 19:36:16 +00:00
Mark Holmquist da86c5f750 Version our EL profiling
This is just a clever way of marking messages as being useful again -
this way I don't need to go through the hassle of deleting old data.

Change-Id: I6a0574eaae063014340484ffd2552f8118abb939
2014-01-08 09:35:35 -08:00
jenkins-bot 65db71572c Merge "Fix painful bug in eventlogging code" 2014-01-08 17:18:28 +00:00
Gilles Dubuc 26735d8bd1 Make the behavior of the lightbox more consistent with scroll
Makes sure that the advanced description is out of view when
the lightbox opens.
Remembers the scrollTop position that was set when the lightbox
opens, in order to restore it when it closes.

Change-Id: I534f7d718528d1e5a4911c68a524eb96cadeae90
2014-01-08 17:05:05 +01:00
Pau Giner 4c87c93d91 Use chevron for panel opening affordance
replaces the drag image with a chevron and adds CSS classes to
adjust the opacity changes.

Change-Id: I689c7ff3c952f1ec2b8b16258dc44b1ad095f4fa
2014-01-08 14:41:44 +01:00
Gilles Dubuc f3fd143c8a Move the arrows and the close/fullscreen button
Looks drastic at first, but grows on you.
I based this on an extreme, the firefox inner scrollbar.
Which is huge when hovered.
I kind of wish the close button was a bit bigger, though.

Change-Id: I2f47280c4e7c4bff299149de24741e3381f0b5e9
2014-01-08 11:33:56 +01:00
Mark Holmquist 3547f17960 Fix painful bug in eventlogging code
Change-Id: I3026aadcb28e7a8325137214512163558cccf2db
2014-01-07 17:27:28 -08:00
Translation updater bot 9b62de0e57 Localisation updates from https://translatewiki.net.
Change-Id: I1271286624379479f02367bb6199bd960bbf2fab
2014-01-07 20:45:10 +00:00
jenkins-bot 055ccb8c27 Merge "Styling fixes for media panel" 2014-01-07 19:37:44 +00:00
Pau Giner 797a2d90e0 Styling fixes for media panel
Color and position adjustments for panel elements:
* Background
* Line separation
* License text

Change-Id: Ib8c5557503ec6a28b9761220a251cf4ac4742182
2014-01-07 20:05:29 +01:00
jenkins-bot 5a58b12b7b Merge "Added No description message" 2014-01-07 16:00:21 +00:00
Mark Holmquist 896a7b4c40 Animate the metadata div to show the user it's there
"Hey! Scroll down! Yeah, you!"

Also fixes the previous arrow button, which got disappeared at some point

Bug: 58431
Change-Id: I98676ee921dc1d3b5780046eabec7415c05f8f4f
2014-01-06 18:29:37 -08:00
Mark Holmquist 27e2db75f9 Make sure the post-image div is always the same height
Otherwise it flickers and is weird and stuff.

Bug: 58431
Change-Id: Ic7d7d0bededede9b3cedb4ebd8efdcfae2209127
2014-01-06 17:24:45 -08:00
Mark Holmquist c17be3b124 Fixed positioning for the image
Fix, so we can work on animating the metadata div next.

Bug: 58431
Change-Id: Ic62711f657daaa36bb82e32e98a0abee421864fc
2014-01-06 17:14:51 -08:00
jenkins-bot 85a0474997 Merge "Bigger click targets for next and previous" 2014-01-06 23:38:02 +00:00
jenkins-bot e1efb5d16e Merge "Make the imageinfo fetch more generic" 2014-01-06 23:32:22 +00:00
jenkins-bot 1b94099d7f Merge "Fix issues pointed out by aarcos" 2014-01-06 23:07:39 +00:00