Commit graph

2101 commits

Author SHA1 Message Date
Gergő Tisza 4f54b81c03 Toggle metadata panel on up/down keypress
Previously 'up' brought the panel up, and 'down' brought it down,
which might conflict with expectations on scrolling. Up/down keys
now move the metadata panel to the opposite state, no matter what
the current state was.

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/697
Change-Id: I53079d81042afb86354bf44e9dfd662adf1576cb
2014-06-10 20:10:42 +00:00
Gergő Tisza 92e68e4013 Show Commons link to logged out users
Change-Id: I899cb36a5d25342325266b68a3fd8058f3129e78
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/429
2014-06-10 00:30:14 +00:00
Gergő Tisza afbe172613 Change "Created on X" and "Uploaded on X" to "Created: X" etc.
Based on enwiki feedback by Jonesey95: "Created on…" does not work
well when the date is not a day (and we have dates like "1992" or
"circa 1400"). "Created: …" works reasonably well for everything.

Same for "Uploaded on…".

Change-Id: I46b51880be2151a467ccb90a76dde6efc5991cd5
2014-06-09 23:42:42 +00:00
Pau Giner ba5a1b7516 Icon adjustments
- open.svg icon added for the "view in browser" feature form the share panel.
- expand.svg icon updated for better icon consistency (spacing also adjusted in the CSS)

Change-Id: Id6176d8f9b4884c9aabde05f1639500d3349f9a7
2014-06-09 23:03:16 +00:00
Translation updater bot aa2c15a9c4 Localisation updates from https://translatewiki.net.
Change-Id: I95cb8298be7cb4d626df9a67b4675bbcb6f97d64
2014-06-09 20:31:23 +00:00
jenkins-bot 05c58ba0b9 Merge "Use original URL when setting download for original" 2014-06-09 18:34:38 +00:00
Mark Holmquist fc02ce0dc8 Use original URL when setting download for original
Messed with the download tests a bit too.

Change-Id: I6b7f6b5eb8642db1a81aff05663636813a21fe06
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/470
2014-06-09 18:30:07 +00:00
Translation updater bot 1a53aa16d3 Localisation updates from https://translatewiki.net.
Change-Id: Iaf51dc423cdfdbe2aa201862cc096779c711a11d
2014-06-08 19:57:26 +00:00
Gergő Tisza 1d3769e106 Fix CSS for hiding content
:not() only works with simple selectors, not composite selectors.
This caused problems for people with customized skins.
Also, this way we only require support for > (wider) instead of
support for :not.

Also fixed footer id and added monobook for good measure.

Bug: 66326
Change-Id: Ibaa0861aff711723dd336eeaa8c12e73110b1c3b
2014-06-08 02:12:11 +00:00
Translation updater bot 46aaa55dc1 Localisation updates from https://translatewiki.net.
Change-Id: Ife83fb138d9faae0100f80cb6b9b36308cce1067
2014-06-06 21:47:18 +00:00
Mark Holmquist c34e80a1b1 Fix the share/download patch
Turns out the "active" class is added in each pane's definition.

TODO: Fix that.

Jenkins, you durnk

Change-Id: I6da961618b360d96a03948d4f6688cd4e1931b66
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/679
2014-06-04 23:32:52 +00:00
Translation updater bot e31ab5bd08 Localisation updates from https://translatewiki.net.
Change-Id: I07c0860758cf12238f961c033e475b8eb7a09deb
2014-06-04 19:54:04 +00:00
Translation updater bot c4fd9842b7 Localisation updates from https://translatewiki.net.
Change-Id: I7aec562522187bbd87c87c5bdebec81e52d51791
2014-06-03 19:51:24 +00:00
Translation updater bot c5c4cbf5f5 Localisation updates from https://translatewiki.net.
Change-Id: I92c1df4667614d3309a357f109d6d9ee9d7782a8
2014-06-02 20:59:13 +00:00
jenkins-bot 5330884684 Merge "Change preference name for enabling MediaViewer" 2014-06-02 07:29:17 +00:00
Mark Holmquist ff527cd0f3 Support shared DB version of Commons definition
Supporting production is Hard Work (tm)

Change-Id: I57b1ea945711f6fe76697927641bf4e805be15cf
2014-05-30 13:12:49 -07:00
Gilles Dubuc 1db51f25ab Prioritize download
Change-Id: I0e40a54f544414befa51c5d37bda5260b9c3e135
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/665
2014-05-29 10:45:51 +02:00
Gergő Tisza f9d06141f4 Make JSHint enforce ES3 compatibility
Also fix ES3 compatibility errors.
Upstreamed issue with sinon.stub().throws():
https://github.com/cjohansen/Sinon.JS/issues/488

Change-Id: I93b0d575484089b293d94ea860d245def4646cb4
2014-05-28 22:58:33 +00:00
Translation updater bot 91e0a176ba Localisation updates from https://translatewiki.net.
Change-Id: I83ef6e069cdb72a73c47db84dfa65e9cf81b3c0c
2014-05-27 20:27:07 +00:00
Translation updater bot c7c7385106 Localisation updates from https://translatewiki.net.
Change-Id: Iec6aaeb902d041b9150bfec685ad29fcb5f4c2cf
2014-05-25 19:37:05 +00:00
Translation updater bot d9312271c8 Localisation updates from https://translatewiki.net.
Change-Id: I450e87a16698db4dafbae858a74437021b3248e9
2014-05-24 15:21:31 +00:00
Gilles Dubuc 7161ac3cc4 Record sampling factor in EventLogging calls.
Change-Id: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-22 09:30:37 +02:00
jenkins-bot 1d897bcb17 Merge "Highlight chevron when the wrong direction is pressed" 2014-05-22 00:05:11 +00:00
Gergő Tisza 1ad28140c3 Fix text selection behavior in reuse panel
The jQuery update broke onDomEvent('focus') in OOjs UI. This is a
workaround which fixes the issue by binding on the input/textarea
elements directly, instead of their parents.

This introduces the annoying side effect that the metadata panel jumps
a bit when the embed HTML text is selected. (Just for that one, yes.
Weird.) Still better for now than no selection at all.

Change-Id: Ifa4c0600d7b4c0c64487596cbcabd5b4f4a12a19
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/638
2014-05-21 22:00:46 +00:00
Tomasz W. Kozlowski 826ac9b69d Change preference name for enabling MediaViewer
Should simply say 'Enable Media Viewer' instead
of puzzling our users with 'Enable new media
viewing experience'.

Requested on Commons, Mingle card #622.

Change-Id: Ibe6c11a9fe4b3fd64de65ae50055e3fc377c3ae9
2014-05-21 14:42:30 -07:00
Translation updater bot f71a591189 Localisation updates from https://translatewiki.net.
Change-Id: Ib2770c062624f35783e50a102e7a15c976c81eed
2014-05-21 20:24:19 +00:00
Timo Tijhof 35ec99eb50 Use example.{com,net,org} instead of proprietary domains
http://foo.com/bar was making a request to some random server
responding with HTTP 500 Internal Server Error.

Change-Id: I17f2e0908b849455db5ab1790b15c2344337c24b
2014-05-20 16:34:54 +02:00
Gilles Dubuc c7fe85154b Highlight chevron when the wrong direction is pressed
Change-Id: I0d43c58a16fa805611f9fdef329b5ab6a32ed651
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/554
2014-05-19 11:01:31 +02:00
Translation updater bot 148fc7ab7f Localisation updates from https://translatewiki.net.
Change-Id: I60db3b07cb999156b33aa27985570ec7eab49fb4
2014-05-18 20:07:40 +00:00
Translation updater bot a757ed72d3 Localisation updates from https://translatewiki.net.
Change-Id: Ic066cb7c764590897e283608d585daaf2ca1a583
2014-05-17 19:56:23 +00:00
jenkins-bot 32c09c5786 Merge "Wait some more for the close button to appear" 2014-05-17 00:07:11 +00:00
jenkins-bot f5a6d67749 Merge "Fix IE9 history navigation" 2014-05-17 00:06:24 +00:00
jenkins-bot b27029f8b5 Merge "Revert "Temp fix for core bug (getFileSearchOptions() stopped working)"" 2014-05-16 23:10:20 +00:00
Gergő Tisza 863121a518 Revert "Temp fix for core bug (getFileSearchOptions() stopped working)"
This reverts commit 0ef329b8c5.

See https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/620

Change-Id: I347f0f2500b91c2afe9bcf460209e0f7daebdebd
2014-05-16 23:09:14 +00:00
jenkins-bot d19fcf60d2 Merge "Add sampling to unsampled event logging" 2014-05-16 20:45:30 +00:00
Translation updater bot e09448816d Localisation updates from https://translatewiki.net.
Change-Id: I0c51bf07209249498331d57a879ba777714af181
2014-05-16 20:00:09 +00:00
jenkins-bot 9bbb293d00 Merge "Replace deprecated jQuery.browser with jQuery.client" 2014-05-16 18:47:46 +00:00
Gergő Tisza 171b13149e Add sampling to unsampled event logging
Has issues:
- needs dependency injection
- needs to be DRY
- should not load mw.eventLogging when we are not in sample

Due to urgency this will be fixed in another commit.

Change-Id: I0df067a619109a7c945f82c8d33fa2e621217f0b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619
2014-05-16 18:43:55 +00:00
rillke 85833e06f3 Replace deprecated jQuery.browser with jQuery.client
jQuery.browser is deprecated. jQuery.client is a core RL module.

Bug: 65371
Change-Id: I040cfba574fa0514a25ec5166d82d86f6f697441
2014-05-16 20:37:27 +02:00
Gergő Tisza 0ef329b8c5 Temp fix for core bug (getFileSearchOptions() stopped working)
Change-Id: I0662f5cc5de2c421f926fe9e1bdbdde25bf1313e
2014-05-16 18:36:14 +00:00
Gilles Dubuc eedc57c1c9 Wait some more for the close button to appear
During the warmup steps Media Viewer might take some time
to open, which might be why the close button won't appear in
less than 5 seconds

Change-Id: I3b17d46c3343f2b1ff33aaaf55faa4adb71cb218
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/618
2014-05-16 11:36:12 +02:00
Gilles Dubuc bb93765dbb Fix IE9 history navigation
Change-Id: I83469fdaa069e80dc17c0c0c307bff7e9b25e468
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/617
2014-05-16 11:06:40 +02:00
jenkins-bot 44311cddd4 Merge "Revert "Minimal zoom implementation"." 2014-05-16 08:29:49 +00:00
jenkins-bot 0a65ae8a39 Merge "More prominent metadata panel invite." 2014-05-15 20:57:16 +00:00
jenkins-bot eecde58ff8 Merge "Add 1 pixel of tolerance to the basic test." 2014-05-15 20:42:52 +00:00
Pau Giner 96791886c8 More prominent metadata panel invite.
The invite animation has been made more prominent and the chevron
is highlighted. this only applies until the user opens the
panel for the first time.

Change-Id: I91d1b9bffaf302890f63b741313aa47cc4beef24
2014-05-15 20:41:13 +00:00
Gilles Dubuc c6411d3c6a Add 1 pixel of tolerance to the basic test.
This is the first failure that the E2E test is running into when being
run on IE9

Change-Id: I60fe8764196ecc60e2c365576349cf902a069ddb
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/577
2014-05-15 20:41:08 +00:00
Gergő Tisza ab7b339143 Revert "Minimal zoom implementation".
Per the design meeting, we are abandoning this feature for now - there is not enough time to ensure it is of acceptable quality.

This reverts commit 4329d453ec.

Change-Id: I27c113ffecb617d442557163722ea5181ed0b2f4
2014-05-15 20:40:41 +00:00
Gergő Tisza d74b4dce4f Fix failing focus tests
jQuery 1.9 changes how $.focus() calls are handled: instead of
directly calling the handlers, it just invokes the DOM element's
focus(), and leaves it to the browser's event handling to trigger
them. This can fail for several reasons (e.g. element is not
attached to document, element is already focused, browser bugs such
as http://bugs.jquery.com/ticket/13363 ), so we are using
triggerHandler('focus') instead, which calls the handlers directly
without simulating actual browser events. Since these are unit
tests verifying event handler attach/unattach behavior, not
acceptance tests verifying actual event handling behavior, that
should be okay.

Change-Id: I65ecda28ace4f380ad33d6212e12069e18001232
2014-05-15 19:20:47 +00:00
Gergő Tisza 4329d453ec Minimal zoom implementation
Just a link to the full-size file for now.

Since the link must be to a PNG/JPEG/GIF (so possibly a thumbnail),
and we want to cap the size, we might need to get the URL from the
API, but we need to open the new window right away to avoid popup
blockers, making this patch quite complicated.

Change-Id: I9ce9d2a2d27b75470eae2806d9f9ce2f95f4dac2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/588
2014-05-15 01:04:23 +00:00