Commit graph

738 commits

Author SHA1 Message Date
Gergő Tisza 6a0ad63085 Debounce resizes
* create a resize-end event which fires 100ms after resize ends
  (or pauses)
* move slow resize callback (fetching new thumbnail from the server)
  to resize-end

Change-Id: I1c1217ea43ffade4cfaf0c03f24574d0ebfee080
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/898
2014-09-30 14:45:00 +00:00
jenkins-bot 22966d4358 Merge "Only add country field when it's in the schema" 2014-09-29 14:05:25 +00:00
jenkins-bot 265e414c50 Merge "Remove duplicate details link in metadata panel" 2014-09-28 21:47:51 +00:00
Mark Holmquist 9187148b01 Remove duplicate details link in metadata panel
Change-Id: I2eaa221fa505e9f106fa8611adfe99677a24009b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/909
2014-09-28 21:45:55 +00:00
Mark Holmquist b0aa337fd5 Initialise dialogOpen value to false
Because it was undefined, the toggleClass method just turned the class on
if it wasn't there in the first place.

Silly jQuery, Trix are for kids.

Change-Id: I4e21e033529834a4f808270306c72f5756b69ab2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/921
2014-09-26 19:03:14 -07:00
Gergő Tisza 2e4379c66e Only add country field when it's in the schema
Change-Id: Id38ce4d20312bd15014cf37d521aac0a97bd660b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/907
2014-09-26 22:05:22 +00:00
jenkins-bot cab8fe42d5 Merge "Revert "Layout adjustments to reduce overlap with chevron"" 2014-09-26 18:46:51 +00:00
jenkins-bot f4348a844a Merge "Revert "Show initially part of the below the fold area"" 2014-09-26 17:52:33 +00:00
MarkTraceur 640984b2e9 Revert "Layout adjustments to reduce overlap with chevron"
This reverts commit b77ae2c62b.

Change-Id: Ibc9d864d5309eb23ec1b495a1311a614e907b5a8
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/912
2014-09-26 17:52:13 +00:00
Gilles be3f2a3302 Revert "Show initially part of the below the fold area"
This reverts commit 248875e703.

Change-Id: I826d2b9ff346d862e7a7e6113c19b87e718e1acd
2014-09-26 15:17:11 +00:00
jenkins-bot cdfd59feae Merge "Remove copypasted code from attribution logger" 2014-09-26 14:56:12 +00:00
Gergő Tisza af6688ef47 Remove copypasted code from attribution logger
Probably copied this from the duration logger and forgot to delete.

Change-Id: Ia59f9d8e5b384486c3d8509120223f6694a78529
2014-09-26 06:53:38 +00:00
jenkins-bot f1b9c0c391 Merge "Fix dialog class" 2014-09-25 13:44:44 +00:00
Pau Giner 958bedac36 More details button color fix
This patchset avoids the more button to become tranlucent due to som legacy styling.
The margin is also slightly adjusted to center the button in the panel.

Change-Id: Ic3936e90c891ded71d2954cd0e591012fb7bb33b
2014-09-25 07:19:22 +02:00
Mark Holmquist b691086f2b Fix dialog class
Missed this small issue - doesn't affect actual behaviour but will make a
confusing cursor display in some instances.

Change-Id: I40c3cf0c9596f40983f090974044bcd6f7d203d3
2014-09-24 16:19:03 -07:00
jenkins-bot 0caa1c4ddc Merge "Fix bug where download dialog doesn't unattach" 2014-09-24 21:15:03 +00:00
jenkins-bot 7b1d3814fe Merge "Move focus event handlers to mmv.ui.Element" 2014-09-24 21:14:59 +00:00
jenkins-bot 6c2fe0aaf5 Merge "Style fixes for the UI changes" 2014-09-24 21:14:51 +00:00
jenkins-bot 93d678dcd6 Merge "Move dialogs to the left, make arrows point right" 2014-09-24 21:14:50 +00:00
jenkins-bot 18beee316e Merge "Make the download pane into its own dialog" 2014-09-24 21:12:20 +00:00
jenkins-bot 24e2487d7e Merge "Make "more details" button bigger 'n' prettier" 2014-09-24 21:12:18 +00:00
jenkins-bot e05655d880 Merge "Make the reuse button part of the canvas" 2014-09-24 21:12:10 +00:00
Mark Holmquist f7d9c66177 Fix bug where download dialog doesn't unattach
Change-Id: I02c45bf9d0aea8e92d02cb80f266f6c83633a50c
2014-09-24 14:05:53 -07:00
Mark Holmquist 133a94cb89 Move focus event handlers to mmv.ui.Element
Needed to make sure the download dialog can use the handlers.

Change-Id: If62146f1181f0e722be691f61e5fdc133c9b3795
2014-09-24 17:08:50 +02:00
Mark Holmquist 325a8a3e27 Style fixes for the UI changes
I decided to fix them all at once since we're merging all of these
patches together anyway. I can pull changes into other patches if
absolutely necessary.

Also fixes the dialog open/close handlers for the canvas click event,
and leaves the reuse dialog open on next/prev.

Change-Id: Id1564425442aec72e5e41f2f80986d8a104dd92c
2014-09-24 17:08:02 +02:00
Mark Holmquist c6f3be42aa Move dialogs to the left, make arrows point right
Change-Id: If8fc4ca5f902b3dc3271a33c44554d4e46faadb8
2014-09-24 17:07:05 +02:00
Mark Holmquist 0d4863dd91 Make the download pane into its own dialog
Change-Id: Ia92545ed1ef7f2e4ba7934c682eef684a22ca17f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/841
2014-09-24 17:05:50 +02:00
Pau Giner b77ae2c62b Layout adjustments to reduce overlap with chevron
For files with long credit information, part of the text can get hidden
with the down-pointing chevron.
This patchset adjust sizes and margins of different elements to reduce that overlap.

Change-Id: I03f3b84d4ad0f754a0a20f2e78016711164ef433
2014-09-24 13:11:47 +02:00
jenkins-bot 01ef0368e0 Merge "Show initially part of the below the fold area" 2014-09-24 10:00:56 +00:00
Pau Giner 248875e703 Show initially part of the below the fold area
In order to communicate that there is more content below.
This is related to acceptance criteria #8 of story #830.
For more details check:  https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/830

Some further improvement to consider:
- We'll need to adjust the "more details" button margin to make it fit better in the current above the fold area (0.55 em instead of the current 0.7em).
- If the panel is open, and the user clicks outside of it (e.g., over the image), the panel should close.
- We may want to eliminate the pointing-down chevron if we don't want it to conflict with the big "more details" button.

Change-Id: If14886647aa0660a524a720e8d223eca655d5f3f
2014-09-24 11:59:39 +02:00
Mark Holmquist 7d7cd3a8e6 Make "more details" button bigger 'n' prettier
Change-Id: I81a370a910c0cec269a000c9dcaac8461d3421b0
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/830
2014-09-23 10:41:00 -07:00
Pau Giner 956cd4b47e Add shadow when scrolling panel
When the panel is scrolling a shadow is added to better communicate that
the panel moves over the image.
More details: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/193

Change-Id: I06866a3a034977002b98658a3d09b5421b583ee7
2014-09-23 17:37:41 +02:00
Mark Holmquist 59d8c5d892 Make the reuse button part of the canvas
Moves it out of stripeButtons and into canvasButtons.

Will move download to its own thing later.

Change-Id: Iaf18914b29a6283c3bade954f1adb3f206c9c911
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/834
2014-09-18 12:43:45 -07:00
Pau Giner 9865f41481 Adjust metadata panel colors
Above and below the fold areas of the panle are given slightly different
shades. A separate patchset can make the below the fold 15px visible
to increade discoverability.

Change-Id: Ib38f63131c2060002da60296f7a0d2eba9f3168d
2014-09-18 16:56:28 +02:00
Gergő Tisza 1f78d2b83c Fix patch which fixes the reuse dropdowns
See https://bugzilla.wikimedia.org/show_bug.cgi?id=70968
for explanation.

Bug: 70918
Change-Id: Ibe1c4c1e415952982049d7c581253bb5b8a2e500
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/897
2014-09-17 22:30:55 +00:00
Gergő Tisza 57b2799081 Fix garbled dropdown text
Bug: 70918
Change-Id: I84683ef373409c808ccfaa3b0c3aafef813349b7
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/897
2014-09-17 20:33:56 +00:00
jenkins-bot 8607a81e79 Merge "Fix over reported use-this-file-close event" 2014-09-15 09:19:58 +00:00
Gergő Tisza 4b6e44a2fc Make sure event handlers are set up even if onready handler is lost
Due to a jQuery bug, errors in local code (gadgets, user scripts)
can cause onready handlers to not be executed. For MMV this causes
catastrophic failure, with a black screen of death on exit.

This change makes sure that the setup code necessary for Media
Viewer to work is executed at latest when MV is invoked, even if some
onready handlers were skipped.

Opening MediaViewer via a hash-URL will still not work if the onready
handler fails, but that's hard to avoid and it is not a catastrophic
failure anymore. This change can be reverted when bug 70772 gets fixed.

Bug: 70756
Change-Id: Ida3b780791bc9dfec29303567d33e3aa4f44dd81
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/891
2014-09-12 23:49:43 +00:00
Gilles Dubuc dca82c3866 Fix over reported use-this-file-close event
Merely opening media viewer would trigger it.

Change-Id: I62f4685b821aace3d6323c511d5ad889c1745c4b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/889
2014-09-12 10:48:04 +02:00
jenkins-bot 32429a7723 Merge "Revert "Change image load check strategy"" 2014-09-12 05:38:44 +00:00
Mark Holmquist a82dfd6eb0 Remove tooltip for view-file
Change-Id: I89b2dfd43ea18a2e1fe9d2214b76218b24ce88cb
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/886
2014-09-11 10:41:45 -07:00
Gergő Tisza ea0689a7e9 Revert "Change image load check strategy"
Experimental revert of commit 
d6c142fd2b to see if it caused
the weirdness in the versus charts:
http://multimedia-metrics.wmflabs.org/dashboards/mmv#media_viewer_vs_file_page-graphs-tab

That commit affecting file page load times is extremely unlikely. 
A change in the test environment which exactly coincided with it is 
equally unlikely. This is an easy way  to tell which is the case.

Change-Id: I3581abd36d25494ca294db892480e25f6f4c5a73
2014-09-11 12:48:38 +00:00
jenkins-bot 01e05f07bf Merge "Feature detection for MV load: add SVG, remove Object.create" 2014-09-10 11:42:50 +00:00
Gilles Dubuc 2ef45b3058 Remove categories
Change-Id: I309b01592e874579d50bf5fc0810c238d47748f5
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/835
2014-09-09 13:23:50 +00:00
jenkins-bot 23c7258b31 Merge "Remove file usage" 2014-09-09 13:10:37 +00:00
Gilles Dubuc 81ab508697 Feature detection for MV load: add SVG, remove Object.create
OOJS polyfills Object.create now so there is no need to check for its
existence before loading OOJS-dependent code. On the other hand,
MediaViewer uses SVG icons extensively and the interface cannot be used
if they don't show up.

Bug: 70553
Change-Id: I716e12d4061cfc5c64ccca4563bc30a4394494af
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/863
2014-09-09 10:54:11 +00:00
Gilles Dubuc b70fa7251d Replace addEventListener call with jQuery's .on()
Bug: 70553
Change-Id: I24680e7b7759d30eca2a733d670e10c0b4bfe7ab
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/863
2014-09-09 11:18:03 +02:00
Gilles Dubuc d4666c5715 Track more metrics
- About page
- Discuss page
- Help page
- Location page
- Uploader page
- Download, share and embed tabs in detail (each clickable element)
- "Use this file" closed (previous was counted as open event)

Change-Id: I1ebcb39049ad9b521968eb2024be9b86a49e5b0c
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/851
2014-09-08 10:26:55 +02:00
jenkins-bot 79f1ee4a09 Merge "Go to the original image on image clicks" 2014-09-08 06:33:54 +00:00
Mark Holmquist f94d3362d9 Go to the original image on image clicks
Also removes original file button.

Change-Id: I6e73e46e910313fe6c5efb3087ecb693e499e064
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/831
2014-09-05 10:19:00 -07:00
jenkins-bot 0534d98b89 Merge "Log whether attribution could be presented by MediaViewer" 2014-09-05 14:41:38 +00:00
Gergő Tisza e5de2a5415 Log whether attribution could be presented by MediaViewer
Change-Id: Ib4e8fbafa16c86ff902c838cc93b1710a7ca87af
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/858
2014-09-05 14:35:35 +00:00
Gilles Dubuc caa624d711 Remove file usage
Change-Id: I538f7734e1c06a179ee98a5cd843ccee4d91349f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/835
2014-09-05 08:14:52 +02:00
jenkins-bot e7ea5cb25d Merge "Move logging-related code to its own directory" 2014-09-05 05:32:33 +00:00
Gergő Tisza c4c262bf44 Move logging-related code to its own directory
Also make sure class and file names have the same case.

Change-Id: I21042e40030051326f8c55fd62a86a54e9011a4a
2014-09-04 23:34:45 +00:00
Reza 00e1980e4b Make aside ltr so it would overflow to right always
Proposed on https://meta.wikimedia.org/w/index.php?diff=9752968&oldid=9752027

Change-Id: I9546bc40cf600cddb3af124cb5b937c3ee739d4a
2014-09-04 22:38:06 +00:00
Mark Holmquist 35b6f70ef2 Use link title as fallback for caption
This works because the title doesn't exist if there's no caption and we
won't get to this logic branch if the thumbnail is an explicit |thumb|
with a caption already.

Refactored caption-fetching a bit.

Change-Id: If84c890e7b71880db640a0993f8e3d6cd59951b8
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/513
2014-09-03 12:13:21 +00:00
Gergő Tisza 92c0ba8d99 Fix reuse panel layout issues
The OOUI inline menu widget does not use ul/li anymore; user
class name to target CSS instead.

Change-Id: Ia23f6c130145b411cb0c76a8448d725e51d5e700
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/838
2014-09-02 10:08:43 +00:00
Gilles Dubuc aa97b45c28 CSS compatibility with upcoming OOUI breaking change
Change-Id: Ic7bb6246b20706f8b7e4d7c39d6eb7fd921fde7b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/832
2014-09-01 10:02:48 +02:00
Gilles Dubuc d6c142fd2b Change image load check strategy
Using the "complete" property worked for the file page, but not
for media viewer because change the src of an img doesn't reset
the prop.

This introduces a custom event that cucumber can listen to in order
to know when the full resolution image had been loaded in media
viewer.

Change-Id: I40875166e70badbb35106c4a3536c706a7c815b4
2014-08-28 07:33:58 +02:00
jenkins-bot fb6e8ad1e2 Merge "Fix preference DB values" 2014-08-27 08:11:08 +00:00
Gergő Tisza d3869e581e Fix preference DB values
Ensure that changing the preference via the quick link and
Special:Preferences is stored identically in the DB.

Change-Id: Ia37da1c6bfbb3edf0eba56f01105e4a5f3a5e4ba
2014-08-26 10:37:38 +00:00
Mark Holmquist 62bdbd57a6 Fix link to media viewer with proper namespace
Use the canonical English namespace instead of a localized one.

Change-Id: I9fa1a2af1210c5a4a47792c3dc4616cb628cd806
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/826
Bug: 69956
2014-08-26 01:00:37 +00:00
Thiemo Mättig 2549d25e61 Use spaces in Embed as Wikitext code
The method exists. I assume this was just a mistake.

Bug: 66250
Change-Id: I3a7d19cd1afd0404ce13f947052338d37983db61
2014-08-13 15:54:37 +02:00
Gilles Dubuc ad1922988b Make selected tab default when unknown value comes from localStorage
Change-Id: I80ff90242ac386e74a80d36f0656ff9e761fa147
2014-07-29 11:56:32 -04:00
Gergő Tisza 53e965b469 Feature detect OOJS compatibility
OOJS uses es5-shim but does not use es5-sham so the following ES5
functions are not polyfilled:

Object.getPrototypeOf
Object.defineProperty
Object.getOwnPropertyDescriptor
Object.getOwnPropertyNames
Object.create
Object.defineProperties
Object.seal
Object.freeze
Object.preventExtensions
Object.isSealed
Object.isFrozen
Object.isExtensible

Grepping on them shows that Object.create is the only one in use in
OOJS, so checking for its existence should be enough to ensure that
OOJS works in the given browser.

Change-Id: Icf54a9c35b3599dd1831c10ffcd9f15573dc8b00
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/813
2014-07-28 23:54:47 +00:00
Gergő Tisza 28a7c1b8a4 Do not treat category captions as gallery captions
Categories are implemented via galleries, so they have the same
markup, but while galleries have human-written captions, category
captions just contain the file page.

Change-Id: I6a8548fe696418befc789e20b114778fc724c314
2014-07-25 01:40:58 +00:00
Gergő Tisza 1af29bdc53 Fix metadata footer positioning in fullscreen mode
Add position:fixed to the metadata panel to stick it to the bottom
of the page.

This reverts the change in Ic37b4150288055c3fae8d22919ed7b1249db1f09
I can't recall if there was some intent behind that or it was an
accidental deletion; but this seems to work fine in Chrome and
FF.

Change-Id: Ic5fdce5fb3d6884df782f8bc9ec5c9a5c67edbd6
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/805
2014-07-23 07:32:56 +00:00
jenkins-bot b77010fadd Merge "Use image title in history" 2014-07-22 14:12:23 +00:00
Gergő Tisza e055b8bb7d Use image title in history
Changes document title (which is shown in history navigation)
to include the image name.

Bug: 67008
Change-Id: Id1b030f2b984571fb0877e35db2ca2ccc86f0130
2014-07-22 06:08:59 +00:00
Gergő Tisza 0423bfbe5a Reveal full text when metadata panel is opened
Automatically reveal/hide full text as metadata panel is opened/closed.
Also makes metadata open/close a proper event.
Changes scrollTop calculation for the fully open metadatapanel so it is not
confused by the size of the panel changing.

Also rename MetadataPanel.$controlBar to $aboveFold (that field was missed
when the corresponding CSS class got renamed).

Change-Id: I7e66ca0f45c2188dab4b78508ad7f91154187de4
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396
2014-07-18 00:47:46 +00:00
jenkins-bot 95cc9affbc Merge "Reveal full text when user clicks on title or credit" 2014-07-17 13:44:23 +00:00
Gergő Tisza f14d08fd75 Reveal full text when user clicks on title or credit
Reveal the full title + author + source when the user clicks one
of these, and make some related changes:
* expand the above-the-fold part of the metadata panel so they fit
* make the stripe buttons smaller and hide their text
* scroll the panel up if necessary
* modify tooltip texts when there is more text to show

Change-Id: I304297bc5e7be7b16e2fc4bde66ac19641b00029
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396
2014-07-17 09:42:12 -04:00
Gergő Tisza b622669a9e Size adjustments for moved-back repo icon
* make Commons icon slightly larger than "use this file" icon so
  it seems to be the same size (since the Commons icon has more
  whitespace)
* re-add size adjustments for dynamic icon; IIRC this was needed
  to make Wikipedia icons look good

Change-Id: I6cc2c66beb1d270c9367446661ef14139afa814e
2014-07-17 00:49:10 +00:00
jenkins-bot ab63450dbe Merge "Remove all survey-related code" 2014-07-16 21:31:21 +00:00
Gilles Dubuc b0d885e4dc Remove all survey-related code
Change-Id: I67285260c13a1e8d3c37365bb80a7156c0fecd4e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/794
2014-07-16 21:27:53 +00:00
Gilles Dubuc e17024549f Move repo icon back to the right-hand side
Also makes the grayscale filter work in Firefox.

Change-Id: I7dbeeb55502bc1ff0e1c969fb68310485c562765
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/792
2014-07-16 10:45:14 -04:00
Mark Holmquist 3e2759cd7b Fix a few issues in unattach
Check for tipsy-ness, and for the existence of the opt out button. The
latter doesn't affect prod, but the former might.

Change-Id: Ia5ae8b160626d27750cb3e4938c27a461b9f0c64
2014-07-15 22:15:04 +00:00
Gilles Dubuc eae6f764c2 Fix JS error caused by change in OOUI
hide() has been replaced by toggle() in the latest version of OOUI

Change-Id: Ia868ea1a41430ae566109222ebee6e778db12ad8
2014-07-15 18:02:05 -04:00
jenkins-bot 0aab988269 Merge "Remove $.browser call in jquery.hashchange" 2014-07-10 20:31:12 +00:00
Gilles Dubuc 44865d87e6 Remove $.browser call in jquery.hashchange
I've tested a wide variety of old browsers on sauce labs and only
the older IEs reported "false" for support_onhashchange.

I think the $.browser.msie check was defensive in the first place,
there's no reason why a browser that doesn't support the
onhashchange event wouldn't benefit from the iframe trick.

Change-Id: I5b3a83118ef870237a54a6d67dd930617987abf2
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/590
2014-07-10 15:12:41 -04:00
Pau Giner 5edb949d01 Adjustments to repo icon
The following visual adjustments have been made:
- Make color similar to other icons in the metadata panel.
- Highlight on hover to convey interactivity.
- Adjust to the "visual center". The icon was matematically centered, but since the angular separator adds empty space to the right, a 2px correction has been added so that it looks centered taking into account that extra space.

Change-Id: Ib4db723b38a8d6fc9528fe86756220b6525da95b
2014-07-10 10:25:23 +02:00
jenkins-bot f63c00c8b6 Merge "Remove the gap the between the download button and the dropdown menu" 2014-07-07 16:30:28 +00:00
jenkins-bot 7a42b844ae Merge "Make download panel dropdown button unselectable" 2014-07-07 16:30:20 +00:00
jenkins-bot 6afa9df593 Merge "Use same text formatting for downloads as for other panels" 2014-07-07 16:29:54 +00:00
jenkins-bot 6faaa01ad3 Merge "Convert non-standard class-names (mw-mlb, multiediaviewer-)" 2014-07-07 16:29:47 +00:00
jenkins-bot 3949ee3c5d Merge "Use absolute positioning for progress bar to stop pushing down content" 2014-07-04 06:45:40 +00:00
jenkins-bot 3d8133a813 Merge "Make above-the-fold buttons take up more vertical space" 2014-07-04 06:45:35 +00:00
jenkins-bot 06b772d92f Merge "Make description page link and reuse widget more prominent" 2014-07-04 06:45:34 +00:00
Gergő Tisza f35b9411dd Use absolute positioning for progress bar to stop pushing down content
Change-Id: I518d88f005506813325f6577450eda0ab1c8cd35
2014-07-04 00:14:41 +00:00
Gergő Tisza 5e0642a431 Make above-the-fold buttons take up more vertical space
Change-Id: Id38f4a8dace2818133d659e60036cd0f826665b4
2014-07-02 23:20:41 +00:00
jenkins-bot 1294e824c9 Merge "Add functionality to TruncatedTextField to toggle full text" 2014-07-02 13:29:14 +00:00
Gergő Tisza c5c450f91b Add functionality to TruncatedTextField to toggle full text
Change-Id: I34db79faa80ee5d1b3518aafd9b866cc9cdcc45b
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396
2014-07-02 15:26:21 +02:00
jenkins-bot 60a94fd394 Merge "Show help tooltip for "view original file" button on image click" 2014-07-02 12:52:33 +00:00
jenkins-bot 252746c2f6 Merge "RTL positioning tweaks" 2014-07-02 12:47:57 +00:00
jenkins-bot 8dcf759d75 Merge "Angle separator image" 2014-07-02 12:38:31 +00:00
Gergő Tisza e9d3e041cd Remove the gap the between the download button and the dropdown menu
Change-Id: I640c5e759880f4a1fcbe213d793380ad9caca23c
2014-07-02 01:06:28 +00:00
Gergő Tisza f669763ea2 Make download panel dropdown button unselectable
Avoid ugly selection colors when people double-click the dropdown
button.
(Why would people double-click the dropdown button? Not sure, but
I did, so...)

Change-Id: If505c7b62ca501a492aa7f85d2f6c92790ecd6dd
2014-07-02 01:05:17 +00:00
Gergő Tisza e25cb01a75 Use same text formatting for downloads as for other panels
Change-Id: I0280f4fe33723e9c838c85b5be3e2025be2a9a39
2014-07-02 01:05:16 +00:00
Gergő Tisza 890d7721df Convert non-standard class-names (mw-mlb, multiediaviewer-)
Change-Id: Iab48c9df461b3405ea35d2da7f98fb6812e86b59
2014-07-02 01:02:41 +00:00
Pau Giner 0a17d6ab29 Styling adjustments for download panel
- Split button has been adjusted to have the same height on both parts (button and drop-down)
- The attribution panel has been adjusted to add hover states and adjust sizes and colors

Change-Id: I3ba80776add6dbca9f0b096dfe7ad4a8779f1a0d
2014-07-01 19:04:06 +02:00
jenkins-bot f91280eac1 Merge "Add MS prefixed version of .unselectable" 2014-07-01 12:29:19 +00:00
Gergő Tisza 4adde1685a Show help tooltip for "view original file" button on image click
Change-Id: Ia9e20f55bcdd0482e78a6e9aa5a0625ec2717e78
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/712
2014-06-30 21:12:29 +00:00
jenkins-bot 3e2dda867b Merge "Adjustments for invite animation" 2014-06-30 18:49:33 +00:00
jenkins-bot 02216b5ed3 Merge "Add section for attribution of downloads" 2014-06-30 18:36:07 +00:00
jenkins-bot 39e3cdaed0 Merge "Remove next/prev tooltips" 2014-06-30 18:29:21 +00:00
Mark Holmquist 532819b5a0 Remove next/prev tooltips
Change-Id: I978914bd57d7fdc260dbc0422915e6b766c35a66
2014-06-30 14:20:41 -04:00
Reedy 5c3846a74b Drop execute bit
Change-Id: I6c9f8ea6251bf6a7ed2a5684e5eaa572530a4fb9
2014-06-30 18:34:02 +01:00
Mark Holmquist a4e6bc22d9 Add section for attribution of downloads
Click on the button to expand, click the X to collapse again.

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/598
Change-Id: I6d2512cca0184437273329e6553c6524d6953404
2014-06-30 10:38:11 -04:00
Pau Giner e7fc5857de Adjustments for invite animation
The invite animation has been adjusted to:
- Make the panel movement more subtle (reduced distance and length)
- Add an animation for the chevron and coordinate it whith th panel movement.

Change-Id: I8fbd01d23fd9bf74fc272c40acd2663f5907326a
2014-06-30 14:35:33 +02:00
Gergő Tisza eff0207199 RTL positioning tweaks
* partially undo the RTL fix from mingle #512 which looks bad,
  and use four-value syyntax for background-position instead.
* use noflip on :before rule as :before itself is not flipped
* handle better the uncertainty resulting from image name
  usually not being RTL

Change-Id: If4aa7240e9bee5c0a06f1785edb9c72964dfc60f
2014-06-28 01:22:50 +00:00
Gergő Tisza 8d05dd8a6d Make description page link and reuse widget more prominent
Rearrange the above-the-fold part of the metadata panel so that
the link to the file descriprion page and the button for the
download/share/embed widgets are easier to find.

One gotcha is that favicons are blown up to 32x32px (a small icon
in the middle of a big empty space would really look ridiculous)
so if a site uses 16x16px favicons it will look pixelated.
None of the WMF sites do that though, and if anyone else does, they
should just fix it, 16px favicons suck anyway (e.g. not retina friendly).

Change-Id: Icce12174b6ed89731fe75f8069c0b4a2b7161a34
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/732
2014-06-28 00:28:11 +00:00
Pau Giner 8236a55ec2 Angle separator image
Visual element to separate the image repo icon from the basic
details on the metadata panel.

Change-Id: I57481985b8b449347242ba2cc0838d8a564d7963
2014-06-27 22:45:14 +00:00
Mark Holmquist 22fa78eea3 Close tipsies when closing interface
This could probably be aggregated and done more cleanly, but for now this
will do.

Change-Id: I1918a61a29f753f7249d9c5afbe0658f4faf4d23
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/740
2014-06-27 17:01:32 -04:00
jenkins-bot 5abf15890e Merge "Fix URL handling for global usage list" 2014-06-27 17:41:17 +00:00
Gergő Tisza deafff7046 Fix URL handling for global usage list
Also add integration tests to make sure URL generation works OK

Bug: 63908
Bug: 64910
Bug: 66147
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/570
Change-Id: I448f42e294102a633f74c305dd0a226e7dbe955d
2014-06-25 21:41:04 +00:00
Gergő Tisza f7ae77e79e Remember last reuse tab selection
Change-Id: Ic9b5d0ecc49b6361bfaa0e83b7340648ea2e6a72
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/660
2014-06-25 02:19:49 +00:00
Gergő Tisza 7aef3afbc2 Add MS prefixed version of .unselectable
Apparently -ms-user-select is a thing now.

Change-Id: Ic059dc69b0b3ceeb089b4accdd09fa8c6b9061f2
2014-06-25 00:58:26 +00:00
Gergő Tisza 2a5b519d7a Fix for merge mistake in Ic37b4150288055c3fae8d22919ed7b1249db1f09
A class was renamed inconsistently, causing wrong aspect ratio. 

Change-Id: I9854ff1193971c65e5b36faac62c7830ed8bdb45
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/737
2014-06-24 20:31:18 +00:00
jenkins-bot 5b7a75f61e Merge "Fix commons detection, use URL" 2014-06-19 22:12:59 +00:00
Mark Holmquist b921b3e7c8 Fix commons detection, use URL
URLs don't change, they aren't ever localised, etc.

Hopefully this is the end of this problem.

Change-Id: Ib5b41e2e64a5af65f342783cfd41f35559fbfd60
2014-06-19 15:04:51 -07:00
Gergő Tisza 5e3808a14e Make the metadata panel opening affordance more obvious
- rearrange DOM structure of above-fold part of the metadata panel:
  - rename .mw-mmv-controls to .mw-mmv-above-fold
  - the above-fold part is a single positioned div now, with height
    explitcitly set
  - less LESS gymnastics, above-fold height is a single variable
  - add paddings to the p elements instead of the containers
  - make all title elements align to baseline (except the logo which
    would look horrible)
- discard some CSS which was superfluous
  - overspecified sizes/positions
  - some top/bottoms for staticly positioned elements
- get rid of the .mw-mmv-drag-affordance div, since a full-width bar
  wouldn't really make sense on the bottom of the above-fold section
- flip the chevron and place it to the bottom of the above-fold part;
  add colors etc. per spec
- fix stripe button horizontal spacing

Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/706
Change-Id: Ic37b4150288055c3fae8d22919ed7b1249db1f09
2014-06-19 21:14:56 +00:00
Gergő Tisza 0a265d7e96 Fullscreen improvements
- fix sizing error so that the image actually fits the screen
- hide some stuff that didn't work properly in fullscreen anyway
  (commons/survey buttons just exited fullscreen, reuse menu
  did not fade with the metadata panel, view terms link didn't do
  anything)
- move metadata scroller CSS rules into metadata scroller LESS file
- disable invite animation which broke the opacity transition
- move opacity transition to the main metadata panel element;
  remove background-color transition which is pointless since there
  is an opacity transition

Change-Id: Ib26160cc6431ea007dab8441c634d0faf9ee1d0a
2014-06-19 18:11:26 +00:00
Gilles Dubuc 4e752dd08d Track optin/optout events
Change-Id: I07eeef7a2304df4b70be252929737dad84522afb
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/558
2014-06-19 11:23:03 +02:00
jenkins-bot 0c80fcd992 Merge "Make optout link more AJAXy" 2014-06-19 09:01:54 +00:00
Gergő Tisza c01cb55f4d Make optout link more AJAXy
Make it grey, unclickable and change text while waiting for the
AJAX request.

Change-Id: Ic5c2923944658d5be04217cdfe62e1d8608a478f
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/723
2014-06-19 10:42:04 +02:00
jenkins-bot 6498fb9c9c Merge "Log clicks on the original file link" 2014-06-19 08:28:23 +00:00
Gergő Tisza e5cb2c7f85 Log clicks on the original file link
Change-Id: I3022128ce1772d67f389322379ab8700265d2d29
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/715
2014-06-19 01:21:51 +00:00
jenkins-bot d9b8e2006e Merge "Log clicks to the above-the-fold file page link" 2014-06-18 11:27:04 +00:00
jenkins-bot 6c10f4dec6 Merge "Make max-height computation more stable" 2014-06-18 10:33:08 +00:00
jenkins-bot cffddda969 Merge "Make opacity rules compatible with IE6-8" 2014-06-18 10:12:35 +00:00
Gergő Tisza f566f6e585 Log clicks to the above-the-fold file page link
This uses best-effort logging (like most other links do), not the
blocking call that's used by the other file page link, since
analytics folks had severe misgivings about that.

Change-Id: I35204420c834fa4fce3dcf81403cb78b92811caf
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/726
2014-06-18 01:01:59 +00:00
Gergő Tisza c594a5610a Make max-height computation more stable
Instead of setting the parent's height as max height of the
<img> element, find the first parent which has a non-automatic
height (that would be .mw-mmv-image-wrapper).

With the old structure, the height of the parent element could
be determined by the height of the image, which would then be
written back into the max-height of the image, messing up the
aspect ratio. I did not see this in the wild, but it was easy
to reproduce by changing the timing of the resize handler (in
particular, I tried to call the resize handler before loading
the new resolution, to make the UI more responsive, and ran
into this problem). This cannot happen anymore now.

This also fix a bug on some browsers (IE 10, maybe iOS Safari)
where the size of the image could be slightly larger than the
available space, and the bottom of the image was obscured by
the metadata panel. I am still not sure how exactly that
happened, but it was related to the <img> parents with automatic
heights having incorrect height. After making sure the <img>
has a max-height derived from an element with non-automatic
height, I cannot reproduce the bug on IE 10 anymore.

Change-Id: I193aefc42e6d6072717643659a9e4c0c8b7c7e93
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/698
Bug: 66244
2014-06-17 21:20:00 +00:00
Gergő Tisza 2079519eba Make opacity rules compatible with IE6-8
Change-Id: I426c7af8f5467c3e06abaea4f98b7e1495157e95
2014-06-17 21:11:33 +00:00
Gergő Tisza 2083a39dc2 Convert Mac line endings to Linux ones for some SVG files
Change-Id: If956b1b1b45555144ad9f2299a38d2375cc2e40a
2014-06-17 19:55:34 +00:00
jenkins-bot 87e6bfc714 Merge "Updated chevron icons" 2014-06-16 09:45:09 +00:00
jenkins-bot 90b84731c1 Merge "Revert "Use localized namespace name in embed wikitext"" 2014-06-16 09:31:08 +00:00
jenkins-bot b8b475c77c Merge "Make preview link more prominent" 2014-06-13 23:39:15 +00:00
jenkins-bot a4e2dc6962 Merge "Make MediaViewer ignore images which are in 'noviewer' class" 2014-06-13 23:34:23 +00:00
Gergő Tisza 92ea8edbc5 Make MediaViewer ignore images which are in 'noviewer' class
This includes images where the <img> element has that class
(achievable with [[File:Foo.png|class=noviewer]]) and also those
where some parent element has it.

Change-Id: I666be026828ea9ecb6e8c93d3f5ad1e3c190f81e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/511
2014-06-13 23:32:32 +00:00
Pau Giner a24b67c2cb Updated chevron icons
Chevron icons for the new design of the chevron.
Beware that the active version of the chevron is white since it is assuming
it will have a blue background.

Change-Id: I3d8fa040bfecc219a735565d5ebee8e283691bee
2014-06-13 23:06:18 +00:00
Mark Holmquist ea610f8256 Tooltips for loads of things
Change-Id: I993bf60909024453a14de85af6239bded02eb8a6
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/546
2014-06-12 12:27:04 -07:00
Mark Holmquist f308c9f7b0 Make preview link more prominent
Also cleaned up the SVG. I hate Illustrator so much for what it does to
SVGs.

Change-Id: I3c1b8b812ed50ad65a8c2f53835e440bfd2e77ac
2014-06-12 11:07:47 -07:00
Gergő Tisza 89f4d27e4c Revert "Use localized namespace name in embed wikitext"
Mark pointed out that using localized namespace names would cause 
problems when users try to reuse images across wikis with different 
content language. Reverting for now.

This reverts commit 59b8e5c82a.

Bug: 64710
Change-Id: I4b8b46871a1c80bce20e4017aa8adcfe3041bb4a
2014-06-12 01:26:10 +00:00
jenkins-bot a4e64c27e1 Merge "Fix CSS for hiding content" 2014-06-11 23:47:55 +00:00
jenkins-bot 6e5a1cb185 Merge "Add opt-out/opt-back link" 2014-06-11 22:47:29 +00:00
jenkins-bot b53f7b2e60 Merge "Add functionality to check & set opt-in flag from code, also for anons" 2014-06-11 21:48:13 +00:00
Gergő Tisza 3cebfe32bc Use Repo.isCommons() for deciding whether an image is from Commons
Change-Id: Id6b523d218a9abc9e886da4000962c6523d25dc0
2014-06-11 21:14:14 +00:00
jenkins-bot 114890cc43 Merge "Add "zoom" but really just view-file" 2014-06-11 02:38:52 +00:00
Gergő Tisza 5bd730894d Add opt-out/opt-back link
Change-Id: I998b7ad3ecb0b7e815f9ff0d5f871267b91c109d
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/703
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/704
2014-06-11 02:24:17 +00:00