Commit graph

2807 commits

Author SHA1 Message Date
Matthias Mullie 93f1c9f79e Fix mmv qunit tests
This heavily relied on deferreds getting resolved synchroneously,
which (for .then) is no longer the case with jQuery 3.
There's also a difference in how chained .then's get resolved,
and $.when no longer propagates notify().

The changes in here are basically:
* fix use of $.when, manually passing along notify()
* use .then in some places, instead of .done, .fail, .progress
* fix progress bar hiding in setupProgressBar, which assumed sync
* fixed tests, mostly by using fake timers to give async stuff a
  chance to execute

Bug: T164473
Change-Id: Ib51ddd8bc6254a477861588fb16f57565353afe1
2017-05-16 16:51:52 +02:00
Matthias Mullie d204ecc99a Fix mmv.bootstrap qunit tests
This heavily relied on deferreds getting resolved synchroneously,
which (for .then) is no longer the case with jQuery 3.
There's also a difference in how chained .then's get resolved.

These tests did not wait for the deferreds to get resolved async,
so that had to change. Worse even: some functionality was tested
by assuming a handler would not be called (= the test in that
handler would not be called), which didn't make the test run,
because we never even waited for it to be called.

The changes in here are basically:
* make mmv.bootstrap.js correctly use .then instead of .done & fail
* let mmw.bootstrap.test.js tests wait for unresolved async promises
* check call counts instead of running tests inside of callbacks
* limit use of fake timer to the 1 test that needs it (it interferes
  with async, which otherwise don't get resolved)

Bug: T164473
Change-Id: I3ca4f786890ad1646f71fe336afdb61e5c3b01c7
2017-05-16 16:48:20 +02:00
Translation updater bot e87c489bba Localisation updates from https://translatewiki.net.
Change-Id: I6b9e7307ce8259059a698e6d1016f308cf321152
2017-05-12 23:04:37 +02:00
Translation updater bot b55457d5c6 Localisation updates from https://translatewiki.net.
Change-Id: Ie1b2889e874912198d243bd8cec787a7b8bb9986
2017-05-11 23:19:34 +02:00
Translation updater bot 7249237554 Localisation updates from https://translatewiki.net.
Change-Id: I672724674ceaefae843cd0e21269fc569cb2d432
2017-05-09 22:56:02 +02:00
Translation updater bot ba5ecf07fd Localisation updates from https://translatewiki.net.
Change-Id: I807e8251dc5e9f256e4397c54fd10a08c8fd474a
2017-05-07 23:06:18 +02:00
Translation updater bot 2a338ec7cd Localisation updates from https://translatewiki.net.
Change-Id: Ibb2f0386aeef035e0e4bb63e386103c5479c18bd
2017-05-04 22:55:21 +02:00
James D. Forrester 1f7d8ce518 Move default user preference setting to appropriate hook
Bug: T158346
Change-Id: I0edd6da3ba6c4c3f9d80bdba755658c828fee4a1
2017-05-03 17:37:16 +02:00
Translation updater bot ce2abbb57e Localisation updates from https://translatewiki.net.
Change-Id: I419027da9f52a52b93c739e218d65ff4200b29d6
2017-05-02 23:03:24 +02:00
Translation updater bot a458bf5167 Localisation updates from https://translatewiki.net.
Change-Id: Ic87541e7a7a1868af3f3aa0f21473370c1398634
2017-04-27 22:45:28 +02:00
Translation updater bot c76c6f45b0 Localisation updates from https://translatewiki.net.
Change-Id: Ia465826efa1d36180511bc043dc98c488d195cd2
2017-04-18 22:37:17 +02:00
Translation updater bot ddd121b18f Localisation updates from https://translatewiki.net.
Change-Id: Id918a3635b0cd93a4b48b84310a5ab4432bc49fd
2017-04-17 22:36:03 +02:00
Translation updater bot 561ef8a599 Localisation updates from https://translatewiki.net.
Change-Id: Ic06042093c98e62448fd533f73ac2ff856cd6d9d
2017-04-11 22:58:22 +02:00
Translation updater bot 8ae3d70db3 Localisation updates from https://translatewiki.net.
Change-Id: I3e80e8b00b028d3395c39924d607bf7a2cfd95e5
2017-04-09 22:51:39 +02:00
Translation updater bot b11ed6d88a Localisation updates from https://translatewiki.net.
Change-Id: If7a50aa7e24ec82e97808c6200a8d7b3bc1412b6
2017-04-05 22:41:47 +02:00
Translation updater bot 4a57482417 Localisation updates from https://translatewiki.net.
Change-Id: Ie14d67bd9f884e7a75bb2c83b89fa44e1d729fad
2017-04-04 22:48:11 +02:00
Translation updater bot c8606a2795 Localisation updates from https://translatewiki.net.
Change-Id: I1ae81b1ca1317da35da0da681b9da9ba63b54ede
2017-03-29 22:36:55 +02:00
jenkins-bot bb9b42d519 Merge "Use <button> instead of <div>" 2017-03-28 14:58:55 +00:00
Translation updater bot 4d3146b287 Localisation updates from https://translatewiki.net.
Change-Id: If56dd0eb1ea3bf72bcf7a0638d3d280e76bb4193
2017-03-27 23:35:31 +02:00
Translation updater bot cbad83e264 Localisation updates from https://translatewiki.net.
Change-Id: I5b1e53c92ef616c7a06955a9b37e60bbed56fd92
2017-03-23 22:50:38 +01:00
Prateek Saxena 45110a7090 Use <button> instead of <div>
* Buttons are semantically better.
* Neither <div> nor <button> elements can have the 'alt' attribute
  so switching to 'title' instead.

Reverts parts of I6ea62124018b1a0ec5110bb500f690cb2368f102.

Bug: T58471
Change-Id: I991b40d3387f8d6dd7cdad8ccc5cc9660b9f139a
2017-03-22 12:06:15 +05:30
Translation updater bot e3721f1e49 Localisation updates from https://translatewiki.net.
Change-Id: I52915885121a8014cb9f304138cf56ce000a849a
2017-03-18 22:49:32 +01:00
Translation updater bot 9583064d50 Localisation updates from https://translatewiki.net.
Change-Id: Ibdcd91c9cdc7cc9155e43144245a2b37f5629d8b
2017-03-16 23:21:04 +01:00
Translation updater bot 7c4120bc2d Localisation updates from https://translatewiki.net.
Change-Id: I695c0ebd100d3a5e4a3aead51cfc1c2a39c155ec
2017-03-08 22:33:54 +01:00
jenkins-bot fa8a89f43b Merge "Align to WikimediaUI style guide and code cleanup" 2017-03-07 23:53:44 +00:00
jenkins-bot fa0e81cd75 Merge "Update tests to Selenium 3" 2017-03-07 09:16:45 +00:00
Volker E 7157729ae8 Align to WikimediaUI style guide and code cleanup
Aligning to WikimediaUI style guide by replacing colors with
standard color palette equivalents, merging close colors
(ex: `#E6E6E6` & `#eee` become `#eaecf0` ) and slightly increase
contrast on a few to meet WCAG 2.0 level AA criteria.
Also:
- following other code bases like MobileFrontend or OOjs UI in
using `border-radius` property instead of obsolete mixin
- removing non-existing browser vendor prefixes in mixins
- removing non-used Less variables
- bringing CSS/Less code closer to coding standards and
- simplifying Less code where applicable

Change-Id: Icb936e14ff613471ea1da6df6341ec1b0543cfaf
2017-03-02 15:55:01 -08:00
Željko Filipin ba16982a44 Update tests to Selenium 3
Bug: T158074
Change-Id: I9c8c2d967497419b11e05752c879e6903520c70c
2017-02-27 16:00:25 +01:00
Translation updater bot b129118d53 Localisation updates from https://translatewiki.net.
Change-Id: Ica7d4515dd39ccf0154c9b564632100b1911eef0
2017-02-25 22:30:53 +01:00
James D. Forrester 436bdca6a3 build: Bump stylelint and make pass
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
Depends-On: If53a735458703f0bd2c094349edf86f38f05ccd7
2017-02-18 02:01:45 +00:00
Translation updater bot fe3f5d1964 Localisation updates from https://translatewiki.net.
Change-Id: Ie4a1e00f0a7dfff2d8751d1efd570f224020f1dd
2017-02-17 22:40:47 +01:00
Translation updater bot 88eef3d939 Localisation updates from https://translatewiki.net.
Change-Id: I0acdf0672ac207b170795d973144d44ee1ba0610
2017-02-16 22:52:17 +01:00
Translation updater bot fc725b94ae Localisation updates from https://translatewiki.net.
Change-Id: Ia181644297a96ea65843fdc72a12fa81a767ef2e
2017-02-14 22:41:11 +01:00
Translation updater bot 1932041508 Localisation updates from https://translatewiki.net.
Change-Id: Ib4d768101b28bdf0c47776c2262a4ec5a23a8ea5
2017-02-06 22:41:59 +01:00
Phantom42 3f855b5785 Fix displaying images with uppercase extension.
Bug: T154862
Change-Id: Ib74066340a869a49036215a6ea1df39daa17890c
2017-01-25 01:20:09 +02:00
jenkins-bot 6745561dc9 Merge "build: Re-use MessageDirs in banana conf" 2017-01-24 08:08:00 +00:00
Translation updater bot 312dc29246 Localisation updates from https://translatewiki.net.
Change-Id: Ice1dffdf84a0bcc9447686dea688eaf85e25584e
2017-01-23 22:36:54 +01:00
Ed Sanders e7f53c4be8 build: Re-use MessageDirs in banana conf
Change-Id: If9651d9e1c394a294cc9808dbf1656883c1dfbc6
2017-01-23 13:51:12 +00:00
Phantom42 3a0ed7b4a0 Fix displaying of transparent background
Fix checker background is not showed after resizing browser window.

Bug: T155913
Change-Id: Icc9236474d595c19566e294967a156865a3a1d31
2017-01-22 02:54:13 +02:00
Prateek Saxena f285a576b7 bootstrap: isAllowedThumb: Don't allow slideshow gallery thumbnails
Bug: T140595
Change-Id: Ia0e230c7649c399d0a43acacf55ff72db9bc0e8e
2017-01-19 14:49:54 +05:30
Translation updater bot 6def6f95b0 Localisation updates from https://translatewiki.net.
Change-Id: I1be138ef62e3c19c0e63b6a2a927823eb7e5b08f
2017-01-17 22:15:29 +01:00
Translation updater bot a0c8d23c54 Localisation updates from https://translatewiki.net.
Change-Id: I98f21c5fc54be17a856a3827ed1319902d74eb0c
2017-01-16 14:27:30 +01:00
jenkins-bot ecd7178715 Merge "build: Replace jshint/jscs with eslint" 2017-01-12 21:17:48 +00:00
Translation updater bot ea666c8252 Localisation updates from https://translatewiki.net.
Change-Id: I8e6d69c23011fbf28fed56c852ad9d4011da75f2
2017-01-11 23:16:57 +01:00
Ed Sanders d7ea64137c build: Replace jshint/jscs with eslint
Change-Id: I423add157245353031e36b7e44fee7ace7c753c7
2017-01-10 10:24:39 -08:00
Translation updater bot af9d48942e Localisation updates from https://translatewiki.net.
Change-Id: I88d220eb4f3720dafffba5cd02cdb507b84e7a6f
2017-01-09 15:52:36 +01:00
Fomafix 8869af6eed Replace $( document ).ready(...) by $(...)
In jQuery 3 $(document).ready(...) is deprecated.
https://jquery.com/upgrade-guide/3.0/#deprecated-document-ready-handlers-other-than-jquery-function

Change-Id: Iddec938b358388db11203b4b604928ecdcb3abe2
2017-01-06 16:04:56 +01:00
Translation updater bot 5045b4e38c Localisation updates from https://translatewiki.net.
Change-Id: I037dcaf41b2d6d9bffabf1b0d1dec84bb1682051
2017-01-05 23:47:07 +01:00
Translation updater bot 6fb9f1eae2 Localisation updates from https://translatewiki.net.
Change-Id: I4472860761c42ad4d94593b7d9187171af9b0867
2017-01-04 22:34:46 +01:00
Translation updater bot 0aaec94792 Localisation updates from https://translatewiki.net.
Change-Id: I1608bf2d6bb5a37cae3ed61af3400b7e953a6978
2017-01-01 10:03:41 +01:00