Commit graph

242 commits

Author SHA1 Message Date
Mark Holmquist 85d08e1d27 Fix issues pointed out by aarcos
See https://gerrit.wikimedia.org/r/#/c/95282/10/resources/ext.multimediaViewer/ext.multimediaViewer.js

A few issues with code being in two places; should probably refactor but
would prefer to get out a fix and refactor a little later.

Change-Id: Id74a01e177aeb09fe34416e7fd14759df58fda32
2014-01-06 15:02:51 -08:00
jenkins-bot e0e768f4cd Merge "Fix image bucketing resize engine" 2014-01-06 22:27:40 +00:00
apsdehal f9ee5ec0a0 Added No description message
'No description available' message has been added when description for the
given file is not available.

Bug: 56446
Change-Id: Ie239e5cd0d1b645ed149ea1ecc80197b0e84bc34
2014-01-07 01:57:08 +05:30
Translation updater bot d883ffa3c9 Localisation updates from https://translatewiki.net.
Change-Id: Iae816883bccb723dabd466f278c2d7091aabd47e
2014-01-06 20:06:37 +00:00
Mark Holmquist f2f36376cf Fix image bucketing resize engine
targetWidth was switched to even if the image was way smaller than it,
fixed by only changing to it if the image is too big (too-small images
should never be stretched anyway).

Change-Id: I9e3e6a358e53dbed988b730205a8afec1dbf3483
2014-01-06 11:32:40 -08:00
apsdehal 132049976a Changed 'lightbox' to 'fullscreen interface' in i18n
Bug: 56742
Change-Id: I451ab006b136983c052ad6961aeab38e5e326b9b
2014-01-06 08:00:50 +00:00
Translation updater bot 2a464534e3 Localisation updates from https://translatewiki.net.
Change-Id: Icf02a5429ef0807153b27b084494b0905845f556
2014-01-05 20:12:05 +00:00
Translation updater bot dcde974393 Localisation updates from https://translatewiki.net.
Change-Id: I1023f95e7ac84dc1d073782b950d814c7fe1e223
2014-01-03 20:41:13 +00:00
Translation updater bot 3cd213a072 Localisation updates from https://translatewiki.net.
Change-Id: I1f7dbb0a1fc4a9d631decda033cf7fb99376d2f6
2014-01-01 19:58:07 +00:00
Mark Holmquist e9a1c8c102 Bigger click targets for next and previous
Change-Id: Ic2bd5b80092ee34133ae6b594ac25c57ab562b03
2013-12-31 13:18:22 -08:00
Pau Giner 4c17403070 Updated icons
Icons have been updated and CSS adjusted for close and next/prev arrows.

Change-Id: I335914685de4046f3ab76ea44a44b1b02222f831
2013-12-31 09:57:58 -08:00
jenkins-bot c0fef99d23 Merge "Move 'x' button, shift arrows away from screen edges" 2013-12-30 22:03:52 +00:00
Mark Holmquist 0000664d80 Add tests for the link construction code
Always a good plan.

Also refactored a little bit, but not too much. Juuuust right.

Bug: 57842
Change-Id: I787c3770e41474edafb2fd02e01fec2c7c2b5ed6
2013-12-30 21:51:35 +00:00
Mark Holmquist f8d9a3d522 Move 'x' button, shift arrows away from screen edges
Bug: 58653
Change-Id: I290bca497a56240890d64b234e960d04bd4a001c
2013-12-30 12:36:45 -08:00
Translation updater bot bf631a31a6 Localisation updates from https://translatewiki.net.
Change-Id: I63b1cbba888602590e7000af05d320538a1515bb
2013-12-30 19:59:06 +00:00
jenkins-bot fdc0c0c860 Merge "Added 'Learn more' message" 2013-12-30 18:20:27 +00:00
jenkins-bot 3d1dfe6b7d Merge "Introduce image size bucketing" 2013-12-30 18:19:49 +00:00
apsdehal fb4367f24c Added 'Learn more' message
Message was added to replace 'multimediaviewer-repository' when the file was local

Bug: 56121
Change-Id: I2c6cef2cb21f88159dc56ca7c94c4be21e553db9
2013-12-30 16:54:40 +05:30
jenkins-bot feedc430d5 Merge "Fixes for the scroll-up affordance" 2013-12-29 15:05:24 +00:00
Mark Holmquist f96d5498ca Introduce image size bucketing
See the conversation on mediawiki.org:
http://ur1.ca/g14jv

We're trying this out as one option in combatting slow thumbnail load
times. It may or may not work very well.

Bug: 56695
Change-Id: If1211fdff87c0782c7355d654415bfd29d63d84a
2013-12-27 13:39:31 -08:00
Translation updater bot f18208025c Localisation updates from https://translatewiki.net.
Change-Id: If9799e366f17586e6b7a98ce1703b7214b39e9c0
2013-12-23 20:49:07 +00:00
jenkins-bot ea7ba8faaf Merge "Include license in title attribute of link in FileUsageDialog" 2013-12-20 00:56:39 +00:00
theopolisme 343e82cc8c Include license in title attribute of link in FileUsageDialog
The title attribute of the link that wraps the image
in "Use this file on another website" will be set to
the license and/or author of the image, if available.

Bug: 56588
Change-Id: I5f504964ec3a63e4927385cb68e90856eb4cfe37
2013-12-19 16:00:22 -06:00
Translation updater bot a4f7b6aa71 Localisation updates from https://translatewiki.net.
Change-Id: I04e726d86723f6042b4644f340990244bb2817c1
2013-12-19 20:53:31 +00:00
jenkins-bot 7e6f5462a9 Merge "Fix perf logging" 2013-12-18 23:59:21 +00:00
Mark Holmquist d134a1d32e Fix perf logging
Forgot to add the dependency -.-

Change-Id: I6f4b0712ecda09fc0c096564a19caa6ee9de73a9
2013-12-18 15:16:38 -08:00
Mark Holmquist ebf8da9514 Fix remote DB repos
Apparently they don't have server members, they only have descBaseUrl.
Annoying inconsistencies are annoying.

Bug: 57842
Change-Id: I56cbb6b8ba29cc03105942816f6fa0bad0d126f7
2013-12-18 13:04:34 -08:00
Translation updater bot 9420d9d20b Localisation updates from https://translatewiki.net.
Change-Id: I18bc409c9c8a10f6b6b8960b9e5a0726f60454f3
2013-12-18 20:25:35 +00:00
jenkins-bot 4752404338 Merge "Extend the post-image div height for the drag affordance" 2013-12-18 18:42:51 +00:00
Translation updater bot f05ecfb656 Localisation updates from https://translatewiki.net.
Change-Id: If4c035df6c47e38efc6715e91c07cef31103a856
2013-12-17 19:23:24 +00:00
Translation updater bot 35c307144d Localisation updates from https://translatewiki.net.
Change-Id: I90fd570ded70b2ebd36f532c7a8155cb33150fbe
2013-12-16 19:48:01 +00:00
Ebrahim Byagowi 4f20e53fdc Make broken middle click during refactor work again
Change-Id: Ie4c40accd1ac21c548d4ab899ffdd6c8f95af0a5
2013-12-16 18:31:02 +00:00
Translation updater bot 7538ce87b2 Localisation updates from https://translatewiki.net.
Change-Id: I9f0b809ed8bb884e5d02cf86f782197e7702d7ff
2013-12-14 20:52:49 +00:00
Translation updater bot d98824f0a8 Localisation updates from https://translatewiki.net.
Change-Id: Ie966a7edb3560efdfa2931f501bdde535e364bc5
2013-12-13 20:14:24 +00:00
Aaron Arcos ffc8f4948d Add smoke test to class mw.LightboxInterface.
- Moved tests that were meant for LightboxInterface objects.
  - Fixed space naming issues.

Change-Id: Ib83904eab5fa542330ea559d420efa5f1de8c3eb
2013-12-13 10:39:13 -08:00
Mark Holmquist e68e60f464 Fix another event handler bug
No need to register the event until the interface actually loads...

Change-Id: I1bddb5478410e1868195d63762d913a07e50c0ed
2013-12-12 15:30:11 -08:00
Translation updater bot 794b4da238 Localisation updates from https://translatewiki.net.
Change-Id: Ic1c70e305f1ab117547e73c389c4481b90d5d581
2013-12-12 21:16:22 +00:00
Mark Holmquist 76532a156a Fixes for the scroll-up affordance
Fix click listener, add cursor: move

Change-Id: I1c51702d4c7dd63d64026747c5c75d2dfff14c58
2013-12-10 15:22:40 -08:00
Mark Holmquist 32796a3578 Extend the post-image div height for the drag affordance
Forgot to update the size here, so there's a weird break in the div
right now.

Change-Id: Iea46de723a2ea9a620a07a150560901c81ea9620
2013-12-10 15:02:22 -08:00
Translation updater bot 0fca63132c Localisation updates from https://translatewiki.net.
Change-Id: Iced973b60c4135bf98ea324480915a992c678c9d
2013-12-10 20:43:27 +00:00
Mark Holmquist 4e29e6cd01 Fix fileLink initialisation
I guess this got torn out along the way, but I'm pretty sure this is
what I meant to do - initialize the image object with the thumbnail
URL and then replace it later.

+tests for the failure.

Change-Id: I20ef4e87c6b4b6706ad586f2aa5796736895c780
2013-12-10 11:56:54 -08:00
jenkins-bot 9b02f8ebe4 Merge "Smoke test for MultiLightbox class." 2013-12-10 02:20:30 +00:00
Aaron Arcos 83aa9c6a6b Smoke test for MultiLightbox class.
Change-Id: Iab8a80d842d4252a68bca2a4de92acccd835c978
2013-12-09 18:18:42 -08:00
jenkins-bot 2cc5279e06 Merge "Move clearInterface things to mw.LightboxInterface" 2013-12-10 01:41:18 +00:00
jenkins-bot 8695964ea4 Merge "Add performance logging" 2013-12-10 01:07:39 +00:00
Mark Holmquist f144a0a403 Add performance logging
Change-Id: If6e3aec4b2547fa9768eaaf5387729ed2b427ab1
2013-12-09 17:06:01 -08:00
Aaron Arcos 5fd02ad8f2 Create smoke tests for the LightboxImage class.
Change-Id: I0e5cec7bbcc4140fc6b74e3cf39c0a7b08891194
2013-12-10 00:59:37 +00:00
Mark Holmquist 1411110b3d Move clearInterface things to mw.LightboxInterface
Also fixes a bug where we didn't clear our arrow key listeners, and VE
would sometimes see lightbox loads accidentally.

+tests for .empty()

Bug: 58107
Change-Id: Ica8326891b2da1f94966dbe72c28e878934ca64f
2013-12-09 16:33:34 -08:00
Translation updater bot 8a3e33b61c Localisation updates from https://translatewiki.net.
Change-Id: I730a3c082f47ed58c7663526ad376a427ca35920
2013-12-09 21:25:32 +00:00
Aaron Arcos c38fa2fbfe Fix resize listener leak problem.
Third try, merged latest changes and added a test.
Run loading test against a wikipedia.org image.

Change-Id: I4e5a137e0f6dbedc45ec2c8393590919e23a26be
2013-12-09 20:45:47 +00:00