The 1 line of code this contained, to lazy-load mediawiki.notification,
and forward the function call is now part of mediawiki.base,
and required no dependency.
Bug: T233676
Change-Id: I15e135f7e91ef2a608f7ee915ae3f530c47e5734
Results in small UI changes, but allows us to delete a lot
of code duplication.
Depends-On: I9049f5a1c0d88680fc4a174e390dd08e27c0eee2
Change-Id: Iebe7bdc8a026b929a35e823d8107d90e7bb62b82
Given case-sensitive search, the callback didn't show up
when searching for "MakeGlobalVariablesScript", unlike for
almost every other deployed extension.
Change-Id: Ib9138446a898802150a123e140a14bfba08709e6
Use the new extension.json attribute instead.
Bug: T214211
Depends-On: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d
Change-Id: Iacb68ce9a7bab864720ef9a56f8702a4f02c129d
* Deletes the mmv.model.EmbedFileInfo class file and its test file
* Updates the extension.json and MultimediaViewerHooks.php files to reflect
these deletions (by removing entries from dependency lists)
* Refactors all instances of `new mmv.model.EmbedFileInfo()` to instead use a
POJO with appropriate properties. Conditional assignment is used for the
caption and alt properties if there is any chance they won't be available, to
keep from adding props with falsy values.
* Refactors JSDoc method annotations so that `@param` tags expecting an
EmbedFileInfo instance now expect an object; relevant properties of this
object and their types have been added to the method annotations as well.
Bug: T77320
Change-Id: Ie9f5f24136f4b73000259685474ce4d765a3ccd3
The JavaScript files from the module 'mmv' uses directly functions from
the core modules 'mediawiki.user' and 'mediawiki.util'.
This change adds the missing dependencies on these modules to ensure
that the used functions are present.
Change-Id: Iad7142a5ed52a90b433f94afa25c8ce58b26df5b
Using window.devicePixelRatio directly means we won't be supporting Windows 8
and/or IE 10 & 11. But that seems intentional based on 828f6d6ac9db.
Bug: T206099
Change-Id: I53dbce0a8ddc69c4edfd4d10f98031aa4f7cd20a
As best I can tell, adding the `ext.eventLogging` module as a dependency
for these three modules is unnecesary. One of those modules doesn't
even exist, and my greps across the entire extension show that
mmv.logging.Logger.js uses `mw.loader.using` to load the module, so a
server-side dependency isn't required.
As an aside, this extension should probably use the more abstract
`mw.track` interface instead.
Bug: T180192
Change-Id: If71277114be5a003d8f51040e52a601ace983c51
1) ExtensionJsonValidationTest::testPassesValidation
Failed asserting thatMultimediaViewer/extension.json did not pass
validation.\n
[url] Should use www.mediawiki.org domain\n
' matches expected false.
Change-Id: I90fe971f48e94f6810832fd8a784c9ca8967576b
There's no need to do any fancy isset() on every setting - extension.json
will automatically take care of that.
For $wgMediaViewerEnableByDefaultForAnonymous which depended on the value
of $wgMediaViewerEnableByDefault, treat true/false as explicit values and
null as a fallback to the other configuration setting.
Keep the documentation associated with each setting in MultimediaViewer.php
for IDEs.
Change-Id: Ib34bbf75d027b8b96b2ec1a5975fa19061fadd55
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.
Bug: T183858
Change-Id: I5524242867f06a0812fc5b455997208e11540fae
This is an old library that is broken in Chrome 61.
Rather than updating it we can just use $(window).scrollTop/Left
which works in all the browsers we currently support.
Fix MPSP.toggle to return a promise, instead of a deferred
(although this return value is not used yet).
Bug: T173618
Change-Id: Iaec56debbb808bd95cf65c1ebfe22bdf0116da68
Meanwhile I also updated a few places where a non-string was
passed to/expected from localStorage - this could’ve led to
inconsistencies because localStorage stringifies everything.
And I also removed CP.canSetMediaViewerEnabledOnClick, which
was no longer used anywhere except for a test case.
Bug: T137777
Change-Id: I21ad4ba15ca751bb03e5e2c523d09a45c0444ccf
In addition:
* .mw-mmv-reuse-copy => .mw-mmv-dialog-copy because it's not just a
reuse dialog thing anymore
* Adjust margin between attribution textbox and attribution option
widget to stay consistent with reuse dialog UI
Bug: T77295
Change-Id: I79abdc1a3c10f0a8c3ecb6f4d444a601595a903f
Clipboard icon adapted from modules/tools/images/pasting.svg from the
ContentTranslation extension.
Also adjusts some margins to better separate embed code box from embed
options
Bug: T77295
Change-Id: Ic7a11eab6ecc767ad4d80b94a7b62578d535d047
Previously, the clickable text in the generated HTML credit lines
was the entire link to the article. This is shortened to a localized
version of "Link".
Bug: T119686
Change-Id: I708f65a85bfa26c264cdd06a265096027266240c
Remove useless and misleading version number. It was last updated
in 2013 or so, when MediaViewer was still a beta feature,
and ther was a year of intensive development after that.
Bug: T137477
Change-Id: I4a7cb40852ec55d26260febd446c3d0c4bce9e3f
Some of the code encountered accessed mw.config directly,
I cleaned that up by migrating to mmv.Config, which is an
abstraction added to avoid peeking at mw.config directly.
Bug: T132064
Change-Id: I2a95ba703e6c7f46296f8e435bceec769dceebf9
Remove references to non-existing message keys.
Triggered on every startup module request:
> [resourceloader] WARNING:
> Failed to find multimediaviewer-option-header-viewer ({lang})
* multimediaviewer-option-header-viewer
(listed in 1853540cd3, but never created)
* multimediaviewer-option-header-filepage
* multimediaviewer-option-desc-viewer
* multimediaviewer-option-desc-filepage
* multimediaviewer-license-cc-by-sa-3.0-migrated
(CommonsMetaData has this aliased to "cc-by-sa-3.0")
* multimediaviewer-description-page-popup-text-local
Even if JS tries to use them, the messages do not exist. There
are no matches across all Wikimedia Git repositories for these
strings other than extension.json here (no i18n, JS or PHP files).
Bug: T118820
Change-Id: I3585f4862781799d9ba828bdc4170a68c6c36100
Drop the title and site name. Use a shortened URL
created using the pageID for the curid query parameter.
Add pageID property to mmv.model.Image, using value already
fetched from an existing API request.
Bug: T119686
Depends-On: I0f00b986e6095bdb9b8d6af6fbc5b01995227e02
Change-Id: I9189f00bfbf7639974d66cf1921773855a77a865
